Re: [Buildroot] [PATCH] package/libcamera: force-disable qcam for now

[Quentin Schulz via buildroot <buildroot@buildroot.org>]

Hi Peter,

On 3/11/25 7:15 PM, Peter Korsgaard wrote:
>>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:
> 
>   > From: Quentin Schulz <quentin.schulz@cherry.de>
>   > qcam is based on Qt6 since commit 71aa3ceec30b ("apps: qcam: Port to Qt
>   > 6") which is part of the v0.3.1 release.
> 
>   > qcam being enabled when BR2_PACKAGE_QT5BASE_WIDGETS symbol is defined
>   > breaks the build as it's missing the qt6 dependencies.
> 
>   > The migration to Qt 6 for the Buildroot package isn't straightforward
>   > though as we're hitting a meson bug[1].
> 
>   > For now, let's just always disable qcam until we can get everything
>   > fixed and migrated properly.
> 
>   > [1] https://github.com/mesonbuild/meson/issues/13018
> 
>   > Fixes: 72757d111a5d ("package/libcamera: bump to version 0.3.2")
>   > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> Committed after adding an autobuilder reference, thanks.
> 
>> ---
>   > This is suboptimal solution to unbreaking Buildroot builds of libcamera
>   > when Qt5 Widgets are enabled but that should do for Buildroot 2025.02
>   > release.
> 
>   > We should ideally work on adding proper support for qcam in a later
>   > commit, once the issue reported in
>   > https://github.com/mesonbuild/meson/issues/13018 is either fixed or
>   > worked around in Buildroot.
> 

OK so seems like the proper way to do this with meson would be to add 
moc, rcc, uic, lrelease, etc... to the cross-compilation.conf [binaries] 
section.

The issue is that a path to a tool that doesn't exist will crash meson 
instead of simply marking the tool as not found, c.f. 
https://paste.ack.tf/a12d3b Or at least, it'll crash when using a qt 
module trying to find qt tools.

I guess this can be mitigated by making use of _MESON_EXTRA_BINARIES for 
each package, that are only added when some symbols are 
enabled/dependencies met. But does it make sense since it'll likely be 
necessary for most qt6 packages?

We could also have some logic directly in package/pkg-meson.mk to add 
those paths provided the appropriate symbols are selected? (but that 
could still make meson fail if someone forgets to add the appropriate Qt 
packages as _DEPENDENCIES of said package).

Maybe there's a third option as well?

Which would best suit Buildroot?

Cheers,
Quentin
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot