Re: [PATCH for-next 2/2] RDMA/efa: Add AH cache handling on create and destroy AH

[Gal Pressman <gal.pressman@linux.dev>]

On 10/05/2026 11:30, Yonatan Nachum wrote:
> +static struct efa_ah_cache_entry *efa_ah_cache_lookup(struct efa_ah_cache *ah_cache, u16 pd,
> +						      u8 *gid)
> +	__must_hold(&ah_cache->lock)
> +{
> +	struct efa_ah_cache_key key;

Consider memsetting key to zero.

The code is fine today, but if padding will be added to the struct by
the compiler in the future, you'll likely have lookup issues.

> +
> +	memcpy(key.gid, gid, sizeof(key.gid));
> +	key.pd = pd;
> +
> +	return rhashtable_lookup_fast(&ah_cache->hashtable, &key, ah_cache_params);
> +}