Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/06/2024 09:19, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Document the RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC.

> +
> +  clocks:
> +    maxItems: 1
> +    description: RTC counter clock

Just items: with description instead.

> +
> +  clock-names:
> +    maxItems: 1

Nope, it must be specifc. Or just drop. This applies to all your patches.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - clocks
> +  - clock-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    rtc: rtc@1004ec00 {

Drop label, not used.

> +        compatible = "renesas,rzg3s-rtc";
> +        reg = <0x1004ec00 0x400>;
> +        interrupts = <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> +        interrupt-names = "alarm", "period", "carry";
> +        clocks = <&vbattclk>;
> +        clock-names = "counter";
> +        status = "disabled";

Why do you paste it eevrywhere? It does no really make sense.

Best regards,
Krzysztof