All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michał Wadowski" <wadosm@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Fix for Lenovo B50-70 inverted internal microphone bug.
Date: Tue, 14 May 2019 16:18:38 +0200	[thread overview]
Message-ID: <de267744-b620-ff52-4bbc-696bc74aa789@gmail.com> (raw)
In-Reply-To: <s5h4l5xrxxm.wl-tiwai@suse.de>

On 14.05.2019 15:02, Takashi Iwai wrote:
> On Mon, 13 May 2019 23:25:36 +0200,
> MichaX2 Wadowski wrote:
>>
>> Add patch for realtek codec in Lenovo B50-70.
>> Bugzilla: https://bugs.launchpad.net/ubuntu/+source/alsa-driver/+bug/1524215
>>
>> Signed-off-by: Michał Wadowski <wadosm@gmail.com>
> 
> Thanks for the patch.
> 
> Actually this seems problematic: the added PCI SSID (17aa:3978) does
> already exist for Ideapad Y410P.  That is, we need to replace the
> entry, not just adding.  The existing quirk is only about the noise
> fix and it didn't seem help in a later kernel version, in anyway, so
> it should be OK to replace with the new quirk.

I also saw this conflict, but I didn't know what should I do with this.
If you say that existing fix for Ideapad Y410P is not necessary now, I replace this with Lenovo B50-70 fix.

> Also, I wonder whether the existing quirk
> ALC269_FIXUP_DMIC_THINKPAD_ACPI works on your device.  Could you check
> it?
> 
> 
> thanks,
> 
> Takashi

Yes, quirk ALC269_FIXUP_DMIC_THINKPAD_ACPI works fine on my device.
My laptop uses ALC233, so I created separated quirk, but finally it does the same thing.
Should I remove ALC233_FIXUP_INV_DMIC and replace it with ALC269_FIXUP_DMIC_THINKPAD_ACPI?

thanks,
Michał
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-05-14 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 21:25 [PATCH] Fix for Lenovo B50-70 inverted internal microphone bug Michał Wadowski
2019-05-14 13:02 ` Takashi Iwai
2019-05-14 14:18   ` Michał Wadowski [this message]
2019-05-14 14:31     ` Takashi Iwai
2019-05-14 14:58       ` Michał Wadowski
2019-05-14 15:02         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de267744-b620-ff52-4bbc-696bc74aa789@gmail.com \
    --to=wadosm@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.