Re: [warrior][v2][PATCH] README: updated Maintainers list for Warrior

[akuster808 <akuster808@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2668 bytes --]



On 5/1/19 9:00 AM, Tom Rini wrote:
> On Wed, May 01, 2019 at 08:41:03AM -0700, Armin Kuster wrote:
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>>
>> [v2]
>> bump bitbake to warrior version
>> ---
>>  README                      |  2 +-
>>  meta-filesystems/README     | 12 ++++++------
>>  meta-gnome/README           | 10 +++++-----
>>  meta-initramfs/README       |  8 ++++----
>>  meta-multimedia/README      | 10 +++++-----
>>  meta-networking/MAINTAINERS | 32 +++-----------------------------
>>  meta-networking/README      |  6 +++---
>>  meta-oe/README              |  8 ++++----
>>  meta-perl/README            | 10 ++++------
>>  meta-python/README          | 12 +++++-------
>>  meta-webserver/README       |  8 ++++----
>>  meta-xfce/README            | 10 +++++-----
>>  12 files changed, 49 insertions(+), 79 deletions(-)
>>
>> diff --git a/README b/README
>> index 7318f09..881115e 100644
>> --- a/README
>> +++ b/README
>> @@ -1,6 +1,6 @@
>>  Collection of layers for the OE-core universe
>>  
>> -Main layer maintainer: Khem Raj <raj.khem@gmail.com>
>> +Warrior maintainer: Armin Kuster  <akuster808@gmail.com>
>>  
>>  This repository is a collection of layers to suppliment OE-Core
>>  with additional packages, Each layer have designated maintainer
>> diff --git a/meta-filesystems/README b/meta-filesystems/README
>> index 87cb685..842da13 100644
>> --- a/meta-filesystems/README
>> +++ b/meta-filesystems/README
>> @@ -10,30 +10,30 @@ Dependencies
>>  This layer depends on:
>>  
>>    URI: git://git.openembedded.org/bitbake
>> -  branch: master
>> +  branch: 1.42
> To be clear, where is 1.42 coming from?
> $ git checkout warrior
> Switched to branch 'warrior'
> Your branch is up-to-date with 'origin/warrior'.
> $ git grep BB_MIN_VER
> meta/classes/sanity.bbclass:    minversion = d.getVar('BB_MIN_VERSION')
> meta/conf/sanity.conf:BB_MIN_VERSION = "1.39.1"
How is this a problem of meta-openembedded?
its a core  and bitbake issue.

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=warrior&id=0c3423aae935c36e59d15d8bb60d7826cebc4e03
https://git.openembedded.org/bitbake/log/?h=1.42


>
> To be clear, I'm _not_ a fan of saying we need to go that old
> (especially since there's no CI done with that version) but I am saying
> we should be consistent with the code.

You are helping make a case for removing the reference to what bitbake
version meta-filesystems want as its the only layer that identified it
needed bitbake.

The other layers in meta-openembedded don't list it.

I will send v3 to remove any reference to bitbake.

- armin
>



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]