All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alice Mikityanska" <alice.kernel@fastmail.im>
To: "Matthieu Baerts" <matttbe@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Jakub Kicinski" <kuba@kernel.org>
Cc: "Eric Dumazet" <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	"Alice Mikityanska" <alice@isovalent.com>
Subject: Re: [PATCH net-next 4/4] selftests: net: Fix slow configurations in big_tcp_tunnels.sh
Date: Wed, 19 Aug 2026 20:21:01 +0300	[thread overview]
Message-ID: <de5dd3a9-9ebb-42fe-9007-499dde722d74@app.fastmail.com> (raw)
In-Reply-To: <4a8f39cb-655d-42dd-b776-a272e5d34466@kernel.org>

On Wed, Aug 19, 2026, at 12:25, Matthieu Baerts wrote:
> Hi Alice,
>
> On 14/08/2026 21:41, Alice Mikityanska wrote:
>> From: Alice Mikityanska <alice@isovalent.com>
>> 
>> The combination of checksum offload disabled (that causes software GSO)
>> and CONFIG_DEBUG_NET=y is inherently slow. Depending on the CPU power
>> and load, RTT may increase, limiting sk_pacing_rate, so tcp_tso_autosize
>> caps SKBs at around 40 segments, and zero BIG TCP packets are produced.
>> 
>> Increase sysctl net.ipv4.tcp_min_tso_segs and set a bigger initial value
>> of CWND in these configurations to force BIG TCP.
> Just an innocent question: would it affect the test somehow if the
> sysctl and initial cwnd is always modified, not just for a specific config?

That would guarantee that BIG TCP kicks in, but IMO it reduces the
coverage by not letting BIG TCP kick in naturally. I'd keep the defaults
in fast tests.

> (Note that apart from looking at ${KSFT_MACHINE_SLOW} in patch 2, I
> think the series looks good to me, and can probably be sent to net after
> the merge with net-next.)

Thanks! I'll wait for the selftest to be merged to net and send the follow-
ups there.

> Cheers,
> Matt

      reply	other threads:[~2026-08-19 17:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 19:41 [PATCH net-next 0/4] Improve stability of big_tcp_tunnels.sh selftest Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 1/4] selftests: net: Wait for netserver to launch Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 2/4] selftests: net: Lower threshold on debug kernels for big_tcp_tunnels.sh Alice Mikityanska
2026-08-14 23:07   ` Matthieu Baerts
2026-08-19 17:20     ` Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 3/4] selftests: net: Lower threshold with csum offload off in big_tcp_tunnels.sh Alice Mikityanska
2026-08-14 19:41 ` [PATCH net-next 4/4] selftests: net: Fix slow configurations " Alice Mikityanska
2026-08-19  9:25   ` Matthieu Baerts
2026-08-19 17:21     ` Alice Mikityanska [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de5dd3a9-9ebb-42fe-9007-499dde722d74@app.fastmail.com \
    --to=alice.kernel@fastmail.im \
    --cc=alice@isovalent.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=matttbe@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.