From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932177AbcIOXzm (ORCPT ); Thu, 15 Sep 2016 19:55:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:61244 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756943AbcIOXzd (ORCPT ); Thu, 15 Sep 2016 19:55:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,341,1470726000"; d="scan'208";a="879636097" Subject: Re: [PATCH 4/7] power, workqueue: remove keventd_up() usage To: Tejun Heo References: <1473967821-24363-1-git-send-email-tj@kernel.org> <1473967821-24363-5-git-send-email-tj@kernel.org> Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, akpm@linux-foundation.org, kernel-team@fb.com, Qiao Zhou From: "Rafael J. Wysocki" Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego 173, 80-298 Gdansk Message-ID: Date: Fri, 16 Sep 2016 01:55:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473967821-24363-5-git-send-email-tj@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/15/2016 9:30 PM, Tejun Heo wrote: > Now that workqueue can handle work item queueing/cancelling from very > early during boot, there is no need to gate cancel_delayed_work_sync() > while !keventd_up(). Remove it. > > Signed-off-by: Tejun Heo > Cc: Qiao Zhou > Cc: Rafael J. Wysocki > --- > Hello, > > This change depends on an earlier workqueue patch and is followed by a > patch to remove keventd_up(). It'd be great if it can be routed > through the wq/for-4.9 branch. I don't see any problems with that. Please feel free to add my ACK to the patch if necessary/useful. Thanks, Rafael > kernel/power/qos.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/kernel/power/qos.c b/kernel/power/qos.c > index 168ff44..97b0df7 100644 > --- a/kernel/power/qos.c > +++ b/kernel/power/qos.c > @@ -482,16 +482,7 @@ void pm_qos_update_request(struct pm_qos_request *req, > return; > } > > - /* > - * This function may be called very early during boot, for example, > - * from of_clk_init(), where irq needs to stay disabled. > - * cancel_delayed_work_sync() assumes that irq is enabled on > - * invocation and re-enables it on return. Avoid calling it until > - * workqueue is initialized. > - */ > - if (keventd_up()) > - cancel_delayed_work_sync(&req->work); > - > + cancel_delayed_work_sync(&req->work); > __pm_qos_update_request(req, new_value); > } > EXPORT_SYMBOL_GPL(pm_qos_update_request);