All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Soemoe Aung <soemoe.a@gmail.com>, Ola x Nilsson <olani@axis.com>
Cc: "bitbake-devel@lists.openembedded.org"
	<bitbake-devel@lists.openembedded.org>
Subject: Re: [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***
Date: Thu, 29 Mar 2018 17:43:09 +0000	[thread overview]
Message-ID: <de8d9c1dbc15412fbe62871ca826e78e@XBOX02.axis.com> (raw)
In-Reply-To: <CAPTBsuX3NZmgqqE4bGTQ29k=yp7F6Z_Anwawue=W+3ab1fG3Og@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4181 bytes --]

One way to create and send the patch is:

git cherry-pick 1679188f9c55c615cae780f2b5e6852dea9cf2ec # Assuming you are in the bitbake repository, not poky
git commit --amend  # To add your Signed-off-by footer
git format-patch --subject-prefix='jethro][PATCH' 'HEAD^..HEAD'
git send-email --to=openembedded-core@lists.openembedded.org --confirm=always --no-chain-reply-to --suppress-cc=all 000*

//Peter

From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-devel-bounces@lists.openembedded.org] On Behalf Of Soemoe Aung
Sent: den 28 mars 2018 18:47
To: Ola x Nilsson <Ola.x.Nilsson@axis.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 ***

Yes, that's essentially what I'm asking for. Sorry if that wasn't clear. That fix is in bitbake 1.30 but seems to be needed in 1.26 and 1.28 as well. My change literally took the html5lib file from 1.30 and copied it to the file in 1.26 and submitted it as a patch. Apologies if this was the wrong way to go about this.

What are the steps to backport this change to 1.26 and 1.28 (and also to send these changes upstream to yocto-poky)? Is there anything I need to do?

On Wed, Mar 28, 2018 at 2:41 AM, Ola x Nilsson <ola.x.nilsson@axis.com<mailto:ola.x.nilsson@axis.com>> wrote:
This has already been fixed on a few branches with

bitbake: lib/bs4: Fix imports from html5lib >= 0.9999999/1.0b8

It might be better to backport that where needed.

--
Ola Nilsson
________________________________________
From: bitbake-devel-bounces@lists.openembedded.org<mailto:bitbake-devel-bounces@lists.openembedded.org> <bitbake-devel-bounces@lists.openembedded.org<mailto:bitbake-devel-bounces@lists.openembedded.org>> on behalf of Soemoe Aung <soemoe.a@gmail.com<mailto:soemoe.a@gmail.com>>
Sent: Tuesday, March 27, 2018 23:15
To: bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org>
Subject: [bitbake-devel] [PULL] *** Fix build issue with html5lib in bitbake    1.26/1.28 ***

When I was running yocto-poky on the fido and jethro branches, I was getting build errors caused by the included html5lib in bitbake. It seems like a class is being called incorrectly there. I noticed the issue is resolved in the krogoth branch and the html5lib is indeed different there.

yocto-poky fido includes bitbake version 1.26 and jethro includes bitbake version 1.28. Looking at the bitbake source repo for these versions confirms that these files are the same. yocto-poky krogoth, which has the issue fixed, uses bitbake 1.30, which also has the issue fixed in the bitbake repo.

I originally created this patch in the yocto-poky contrib repo and was directed to send it to bitbake instead. Can someone here take a look at this and accept the changes into the 1.26 and 1.28 branches? Can you also send these changes upstream to the yocto-poky fido and jethro branches?

Let me know if you need any changes here, like creating this patch from the bitbake repo directly instead of indirectly through yocto-poky.

The following changes since commit ea6d21066a7cce2fef08ad66287170c5995bb1e2:

  bitbake: bitbake-user-manual: Fixed porno hack for hello world example (2018-01-17 22:32:46 +0000)

are available in the Git repository at:

  git://push.yoctoproject.org/poky-contrib<http://push.yoctoproject.org/poky-contrib> saung/bitbake-html5lib

Soemoe Aung (2):
  fix build error in included html5lib in bitbake
  fix html5lib fix to be the same as in the krogoth branch

 bitbake/lib/bs4/builder/_html5lib.py | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

--
2.17.0.rc0.231.g781580f067-goog
--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/bitbake-devel
--
_______________________________________________
bitbake-devel mailing list
bitbake-devel@lists.openembedded.org<mailto:bitbake-devel@lists.openembedded.org>
http://lists.openembedded.org/mailman/listinfo/bitbake-devel


[-- Attachment #2: Type: text/html, Size: 9176 bytes --]

  reply	other threads:[~2018-03-29 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 20:51 [PULL] *** Fix build issue with html5lib in bitbake *** Soemoe Aung
2018-03-27 21:15 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Soemoe Aung
2018-03-26 20:55 ` [PULL] *** Fix build issue with html5lib in bitbake *** Burton, Ross
2018-03-26 21:00   ` Soemoe Aung
2018-03-27  9:28     ` Burton, Ross
2018-03-30 15:49       ` Soemoe Aung
2018-03-26 21:02   ` Ruica Cristina
2018-03-28  9:41 ` [PULL] *** Fix build issue with html5lib in bitbake 1.26/1.28 *** Ola x Nilsson
2018-03-28 16:47   ` Soemoe Aung
2018-03-29 17:43     ` Peter Kjellerstedt [this message]
2018-03-30 15:46       ` Soemoe Aung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de8d9c1dbc15412fbe62871ca826e78e@XBOX02.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=olani@axis.com \
    --cc=soemoe.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.