From: David Laight <David.Laight@ACULAB.COM>
To: "'chris.chenfeiyang@gmail.com'" <chris.chenfeiyang@gmail.com>,
"w@1wt.eu" <w@1wt.eu>, "paulmck@kernel.org" <paulmck@kernel.org>
Cc: Feiyang Chen <chenfeiyang@loongson.cn>,
"arnd@arndb.de" <arnd@arndb.de>,
"chenhuacai@kernel.org" <chenhuacai@kernel.org>,
"jiaxun.yang@flygoat.com" <jiaxun.yang@flygoat.com>,
"loongarch@lists.linux.dev" <loongarch@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available
Date: Wed, 8 Feb 2023 22:39:18 +0000 [thread overview]
Message-ID: <de9439e489684965989ac4e96b87de41@AcuMS.aculab.com> (raw)
In-Reply-To: <b9bbf73286238bb4657d855c9d50983aa17953e2.1675851111.git.chenfeiyang@loongson.cn>
From: chris.chenfeiyang@gmail.com
> Sent: 08 February 2023 10:18
>
> loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> openrisc have statx() and stat64() but not stat() or newstat().
> Add statx() and make stat() rely on statx() to make them happy.
>
...
> +#ifdef __NR_statx
> +static __attribute__((unused))
> +int sys_stat(const char *path, struct stat *buf)
> +{
> + struct statx stat;
If seems wrong that 'stat' has type 'struct statx'
and 'buf' type 'struct stat *'.
Maybe s/stat./statx./ and s/buf->/stat->/ ?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-02-08 22:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 10:17 [PATCH v2 0/5] Add LoongArch support to nolibc chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 1/5] tools/nolibc: Include linux/fcntl.h and remove duplicate code chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available chris.chenfeiyang
2023-02-08 10:39 ` Arnd Bergmann
2023-02-09 2:06 ` Feiyang Chen
2023-02-08 10:39 ` Willy Tarreau
2023-02-09 2:02 ` Feiyang Chen
2023-02-08 11:00 ` Huacai Chen
2023-02-09 2:25 ` Feiyang Chen
2023-02-08 22:39 ` David Laight [this message]
2023-02-09 2:14 ` Feiyang Chen
2023-02-08 10:17 ` [PATCH v2 3/5] tools/nolibc: Add support for LoongArch chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 4/5] selftests/nolibc: " chris.chenfeiyang
2023-02-08 10:17 ` [PATCH v2 5/5] selftests/nolibc: Adjust indentation for Makefile chris.chenfeiyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de9439e489684965989ac4e96b87de41@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=arnd@arndb.de \
--cc=chenfeiyang@loongson.cn \
--cc=chenhuacai@kernel.org \
--cc=chris.chenfeiyang@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=paulmck@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.