From: Markus Elfring <Markus.Elfring@web.de>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Marijn Suijten <marijn.suijten@somainline.org>,
Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>
Cc: LKML <linux-kernel@vger.kernel.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>
Subject: Re: [PATCH v2 13/14] drm/msm/hdmi: ensure that HDMI is one if HPD is requested
Date: Wed, 12 Jun 2024 15:01:13 +0200 [thread overview]
Message-ID: <deaa2a50-9e16-4f23-8c13-34947ba4e4e0@web.de> (raw)
In-Reply-To: <20240522-fd-hdmi-hpd-v2-13-c30bdb7c5c7e@linaro.org>
…
> +++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
> @@ -117,11 +117,13 @@ static void msm_hdmi_bridge_atomic_pre_enable(struct drm_bridge *bridge,
>
> DBG("power up");
>
> + mutex_lock(&hdmi->state_mutex);
> if (!hdmi->power_on) {
…
> }
> + mutex_unlock(&hdmi->state_mutex);
>
> if (hdmi->hdmi_mode) {
> msm_hdmi_config_avi_infoframe(hdmi);
…
Would you become interested to apply a statement like “guard(mutex)(&hdmi->state_mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-12 13:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 10:50 [PATCH v2 00/14] drm/msm/hdmi: rework and fix the HPD even generation Dmitry Baryshkov
2024-05-22 10:50 ` [PATCH v2 01/14] drm/msm/hdmi: move the alt_iface clock to the hpd list Dmitry Baryshkov
2024-06-11 18:15 ` Jessica Zhang
2024-05-22 10:50 ` [PATCH v2 02/14] drm/msm/hdmi: simplify extp clock handling Dmitry Baryshkov
2024-06-11 18:16 ` Jessica Zhang
2024-05-22 10:50 ` [PATCH v2 03/14] drm/msm/hdmi: switch to atomic_pre_enable/post_disable Dmitry Baryshkov
2024-06-11 18:17 ` Jessica Zhang
2024-05-22 10:50 ` [PATCH v2 04/14] drm/msm/hdmi: set infoframes on all pre_enable calls Dmitry Baryshkov
2024-06-12 0:04 ` Jessica Zhang
2024-06-12 8:31 ` Dmitry Baryshkov
2024-05-22 10:50 ` [PATCH v2 05/14] drm/msm/hdmi: drop clock frequency assignment Dmitry Baryshkov
2024-06-18 23:02 ` Jessica Zhang
2024-05-22 10:50 ` [PATCH v2 06/14] drm/msm/hdmi: switch to clk_bulk API Dmitry Baryshkov
2024-06-18 23:51 ` Jessica Zhang
2024-05-22 10:50 ` [PATCH v2 07/14] drm/msm/hdmi: switch to pm_runtime_resume_and_get() Dmitry Baryshkov
2024-06-19 0:00 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 08/14] drm/msm/hdmi: add runtime PM calls to DDC transfer function Dmitry Baryshkov
2024-06-19 0:05 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 09/14] drm/msm/hdmi: implement proper runtime PM handling Dmitry Baryshkov
2024-06-19 17:36 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 10/14] drm/msm/hdmi: rename hpd_clks to pwr_clks Dmitry Baryshkov
2024-06-19 17:55 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 11/14] drm/msm/hdmi: expand the HDMI_CFG macro Dmitry Baryshkov
2024-06-19 18:11 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 12/14] drm/msm/hdmi: drop hpd-gpios support Dmitry Baryshkov
2024-06-19 18:47 ` Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 13/14] drm/msm/hdmi: ensure that HDMI is one if HPD is requested Dmitry Baryshkov
2024-06-12 13:01 ` Markus Elfring [this message]
2024-06-12 13:22 ` Dmitry Baryshkov
2024-06-12 14:32 ` [v2 " Markus Elfring
2024-06-12 16:15 ` Dmitry Baryshkov
2024-06-19 22:13 ` [PATCH v2 " Jessica Zhang
2024-05-22 10:51 ` [PATCH v2 14/14] drm/msm/hdmi: wire in hpd_enable/hpd_disable bridge ops Dmitry Baryshkov
2024-06-19 22:14 ` Jessica Zhang
2024-06-12 12:28 ` [v2 00/14] drm/msm/hdmi: rework and fix the HPD even generation Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deaa2a50-9e16-4f23-8c13-34947ba4e4e0@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.