From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C72C1C61DB9 for ; Fri, 28 Aug 2026 10:20:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wztgR-0000zE-HF; Fri, 28 Aug 2026 06:19:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wztgQ-0000yA-5I for qemu-devel@nongnu.org; Fri, 28 Aug 2026 06:19:38 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wztgL-0002eq-S5 for qemu-devel@nongnu.org; Fri, 28 Aug 2026 06:19:37 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67SA7nK23306724 for ; Fri, 28 Aug 2026 10:19:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pLeDyIe24xlxelqivhxFI+C08k7EOIn3h4F7ph1yYvc=; b=bWXYocUR7lIQ3ijM MkRbBFMz9EUllcmW4xu06IRmgdGKC5WPDsG74Yfsle7hshzSrGIbru6eG/c2bdOa k7GiR59KOF19ty/CgkFYqcjtViq7c80KU1mptISveF51cvHLmMyj37kmwu41TcdB 0bcvMj11qfFQIWNt5vCUpxmsLC+vZ4ZrQKPxq5ZGy74RtJ9NN/0t7nmwVZSyooXn Xsnt+m3X69kkVPuxQtlxJ+tyVcVWaNZEZhZdsfIX/kItHCav395xbk9sH+yJ43Bu sHZgvy+EPERUNxJ9XrVgIuFQ3fdHHSxuovxrDAoe4kvrflA5BOB6W0fwi3uc40ja scE5yQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gb42p94fc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Aug 2026 10:19:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52fb8f67601so10054101cf.3 for ; Fri, 28 Aug 2026 03:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787912371; x=1788517171; darn=nongnu.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=pLeDyIe24xlxelqivhxFI+C08k7EOIn3h4F7ph1yYvc=; b=AFelCv+V30p/BS2IbxAJ904mFu0Jxgj9pdfYF22pZ0+HszziGaJs3PM6x9YdVQrxwK S8bbb628CSRq2FL3TrGH9NE14KSgWq9Q/1ycdT/AJCPt9kBoIO0+et2Ji5qywRosq7U/ tmlYeFCaGr3rtRE+Dsqcmu99XE/MSFzgOhheeEkWbCKqkNqEjNmU6l0/NqPmXGp0/mHu cc0/P3OAGADi9XvEVL0tnrt6YxAnp2aK5vaINr4afnrINPlshtbiecITouZyY6ZEqOzO T7oy8rRP0N75m1zAl+2isne2UihgOOn73A6pvoRU4vopup/JMXfnu7Lpu+gc3Br8n2KC mDYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787912371; x=1788517171; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pLeDyIe24xlxelqivhxFI+C08k7EOIn3h4F7ph1yYvc=; b=qmAP7FSU4CtaMw21wTPFNC8la2COad8Q1PoMgtLZeuLMklnUhwtsBbKk7UdJ5FdO/I R7hClpD8gXk2Y5LQKplxBCb5iTVhHtwRyM2NhqOpCgGq/DeJZhLZ4ntx46H/ajspGdoS rSKwvpSd7gTKkso6UoCfxLAB0hXYeJBAIxGucoGwF3ftvc+baPnGImzZPCHt92E+/iBw IHqNuHwPnlkEb3vmW2ScR6pG2/AEWoYfzR35LP0IcZ5Qw2hh+P2d1I4papyU/dp3eTe6 0bGP2fVR9ouJ5yncHm8kDkzMvMMDPpkRdvhr4e3pE8Vr1HPizAnUTcts9cuk9q1S0kyj KdZQ== X-Forwarded-Encrypted: i=1; AHgh+Rop0cpEZo6onKJ5dcVizmN5JC2gaD54zjtThN9Zw0XWN1pUyvLlxtGSPr/PkMPYvV9lvl0KGrmzuPDm@nongnu.org X-Gm-Message-State: AFuF++kWovPHzWuUfZS36rOIh07xbAdF+cvNVFwhJQouEhfeRv8vdJGr uunQhzHiUTCJKlvn+0zXZUsaAzZKFvgKVy19SW1PUTSzOvCMHg6FNcmO4Nj9GI92yHm4CsqkWOy egVNKtIvJjFL+6CA+P9rV88gyiYqgdkBpKJ8B/9uFEqiroBAd4nMEaVyA5Q== X-Gm-Gg: AR+sD11g+gjFdfA9kU4Uxi/lVeBnXsVeoVqMNI5h4mkXqK9KjbYb8b8UulCIGo8L6to guBb5Nh480xrxBl3YIVwYZk/ZyswxS+sKYzBST+JclKGRjIIfrwGtMMPgjcHogYkRM3XcWYNuoG nqZVyfezhii/Dx6mWVyq/99E7O3ic2IZlrfnVnzK3qa3ssin/nixcKPw6ucS3cYwsNJXcexQdpw UkimQZWys38wgVBNq2pzTgbQH2IGDi/bkC9s7kJyMb/464vU2JieIOwMQIBaHpKkUeLPwaA+aLq 0VfwPL5tcMm14GTDGkMhf+vcvJknTPlex0xSNGFW2KIT5wPS6OyVZ3y+ik8Bv2vkkBJ+xGH4+Zl +gKpa6A3o0wAeXHyk+OzBMCaCdLyIyfKDXw== X-Received: by 2002:ac8:5d13:0:b0:52e:2d4e:8eef with SMTP id d75a77b69052e-52fb93d6dcbmr61126821cf.4.1787912370583; Fri, 28 Aug 2026 03:19:30 -0700 (PDT) X-Received: by 2002:ac8:5d13:0:b0:52e:2d4e:8eef with SMTP id d75a77b69052e-52fb93d6dcbmr61125891cf.4.1787912369979; Fri, 28 Aug 2026 03:19:29 -0700 (PDT) Received: from [192.168.69.226] (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b94dc1076sm39706795e9.3.2026.08.28.03.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 03:19:29 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 12:19:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 36/49] monitor: tighten monitor_printf*() Content-Language: en-US To: =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , qemu-devel@nongnu.org Cc: dave@treblig.org, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Markus Armbruster , Gerd Hoffmann , "Gonglei (Arei)" , zhenwei pi , Kevin Wolf , Hanna Reitz , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Pierrick Bouvier , Ani Sinha , "Michael S. Tsirkin" , Laurent Vivier , Amit Shah , Brian Cain , David Woodhouse , Paul Durrant , Richard Henderson , Marcelo Tosatti , Mark Cave-Ayland , Jiri Pirko , Jason Wang , Halil Pasic , Christian Borntraeger , Jason Herne , Eric Farman , Matthew Rosato , Ilya Leoshkevich , David Hildenbrand , Cornelia Huck , Stefano Stabellini , Anthony PERARD , "Edgar E. Iglesias" , Hyman Huang , Peter Xu , Fabiano Rosas , Samuel Thibault , Stefan Berger , Zhao Liu , Nicholas Piggin , Chinmay Rath , Glenn Miles , Harsh Prateek Bora , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Yoshinori Sato , Artyom Tarasenko , Max Filippov , Stefan Hajnoczi , qemu-block@nongnu.org, kvm@vger.kernel.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org, qemu-riscv@nongnu.org References: <20260825-qemu-no-hmp-v4-0-af60857c2fbe@redhat.com> <20260825-qemu-no-hmp-v4-36-af60857c2fbe@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20260825-qemu-no-hmp-v4-36-af60857c2fbe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: PF1cjlnBHbXp2s-hjw7G1ESl5IZjYXgF X-Authority-Analysis: v=2.4 cv=ToDWQjXh c=1 sm=1 tr=0 ts=6a9160b3 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=_7nI1AEwapyDFsg1MK8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: PF1cjlnBHbXp2s-hjw7G1ESl5IZjYXgF X-Proofpoint-Spam-Info: AW1haW4tMjYwODI4MDA4OCBTYWx0ZWRfX1tRm0OAi5txG 3qJLMT9mqNFAoq2ush3NxDqYgnd3xbP82XJBLrh8a/sJzuvq4VJta8Wg2sLK/fC6kfZ+VfBICS6 KyX2HrBmSyGT7+E1OLcPX620X4T33t8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI4MDA4OCBTYWx0ZWRfX24jhGN4/GFYI DAcHU+h6X3wNfi0xHq3KTY9sSNi08osDXhoqK7V0XBn14/Uqkmu6+jbtOpMGk1f8WptvexMU9r1 UcDtYZhMKRd4x6VuvjOXIcWq1GxLgn/ux0rDjPrvRuDDLjjWERLWxkrkDVCiOQPo1k6RTQAww48 PbImMIU9Xg+MiNGAiuPTdwgeigTtp38ojc630OUAV2bjuupsp2E5QhzzSm+rDnFaYBdkhGbkEdy WT953HvWf04qQtRu1U/KK1roNrrBmEj52QFzIGJ+JAJjI2LV1I2N2tROvtga88G81l+EQD2oo4T 7FrOEulroltAvfR7WItQzgmaKVwGXrMjQ9qy5n+FYt3QvI6+JFEGT7DSNKW5zn+3YB8wqTNIcFc QPZDwq+nqRDxO8wYT2YQ8VKl8NC05rXdn6TaBdqY1LgQxVsLyjLSp8JRk09zaCksNSj7+LAfQOa qsWN3jW6C9wA9td3CPA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-28_03,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608280088 Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/8/26 21:09, Marc-André Lureau wrote: > Rename monitor_printf->monitor_hmp_printf, monitor_vprintf-> > monitor_hmp_vprintf, and monitor_printc->monitor_hmp_printc, changing > the first parameter from Monitor * to MonitorHMP * to enforce type > safety. The implementation is also simplified: monitor_hmp_vprintf now > directly calls g_strdup_vprintf + monitor_puts, removing the virtual > dispatch via moncls->vprintf. > > The dev_print() callbacks are temporarily using the MONITOR_HMP(mon) > cast, they are fixed in the following commits. > > Signed-off-by: Marc-André Lureau > --- > audio/audio-hmp-cmds.c | 6 +- > backends/cryptodev-hmp-cmds.c | 9 +- > block/monitor/block-hmp-cmds.c | 170 +++++++++--------- > chardev/char-hmp-cmds.c | 12 +- > disas/disas-mon.c | 10 +- > docs/devel/style.rst | 2 +- > docs/devel/writing-monitor-commands.rst | 8 +- > dump/dump-hmp-cmds.c | 5 +- > hw/char/virtio-serial-bus.c | 10 +- > hw/core/machine-hmp-cmds.c | 213 +++++++++++----------- > hw/core/sysbus.c | 5 +- > hw/hexagon/hexagon_tlb.c | 44 ++--- > hw/i386/kvm/xen-stubs.c | 6 +- > hw/i386/kvm/xen_evtchn.c | 21 +-- > hw/i386/sgx-hmp-stub.c | 3 +- > hw/i386/sgx.c | 29 ++- > hw/misc/auxbus.c | 9 +- > hw/misc/mos6522-stub.c | 3 +- > hw/net/rocker/rocker-hmp-cmds.c | 146 ++++++++-------- > hw/pci/pci-hmp-cmds.c | 114 ++++++------ > hw/pci/pci-stub.c | 3 +- > hw/s390x/s390-skeys.c | 9 +- > hw/s390x/s390-stattrib.c | 20 +-- > hw/uefi/ovmf-log.c | 5 +- > hw/usb/bus.c | 11 +- > hw/usb/host-libusb.c | 21 ++- > hw/virtio/virtio-hmp-cmds.c | 297 ++++++++++++++++--------------- > hw/xen/xen-bus.c | 5 +- > include/disas/disas.h | 4 +- > include/monitor/hmp.h | 12 +- > migration/dirtyrate.c | 46 +++-- > migration/migration-hmp-cmds.c | 301 ++++++++++++++++---------------- > monitor/hmp-cmds.c | 141 +++++++-------- > monitor/hmp.c | 143 +++++++-------- > monitor/monitor-internal.h | 6 - > monitor/monitor.c | 33 ++-- > net/net-hmp-cmds.c | 31 ++-- > net/slirp.c | 31 ++-- > qom/qom-hmp-cmds.c | 27 ++- > replay/replay-debugging.c | 5 +- > stats/stats-hmp-cmds.c | 57 +++--- > stubs/hmp-cmd-info_sev.c | 3 +- > stubs/monitor-core.c | 2 +- > system/dirtylimit-hmp-cmds.c | 10 +- > system/qdev-monitor.c | 19 +- > system/runstate-hmp-cmds.c | 16 +- > system/tpm-hmp-cmds.c | 29 ++- > target/i386/cpu-apic.c | 3 +- > target/i386/monitor.c | 152 ++++++++-------- > target/i386/sev.c | 35 ++-- > target/m68k/monitor.c | 3 +- > target/ppc/monitor.c | 3 +- > target/riscv/monitor.c | 55 +++--- > target/sh4/monitor.c | 29 ++- > target/sparc/monitor.c | 3 +- > target/xtensa/monitor.c | 3 +- > tests/unit/test-util-sockets.c | 2 +- > tools/qemu-vnc/clipboard.c | 4 +- > tools/qemu-vnc/stubs.c | 2 +- > trace/trace-hmp-cmds.c | 12 +- > ui/ui-hmp-cmds.c | 115 ++++++------ > util/error-report.c | 2 +- > util/qemu-print.c | 11 +- > 63 files changed, 1219 insertions(+), 1327 deletions(-) Painful. Reviewed-by: Philippe Mathieu-Daudé