From: Julian Braha <julianbraha@gmail.com>
To: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, herbert@gondor.apana.org.au,
robh@kernel.org
Cc: krzk@kernel.org, conor+dt@kernel.org, Ruud.Derwig@synopsys.com,
rbannerm@synopsys.com, manjunath.hadli@vayavyalabs.com,
adityak@vayavyalabs.com, navami.telsang@vayavyalabs.com,
bhoomikak@vayavyalabs.com
Subject: Re: [PATCH v15 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile
Date: Thu, 2 Jul 2026 20:18:12 +0100 [thread overview]
Message-ID: <deb73385-a7a9-4ea9-8338-b7da999a5e9c@gmail.com> (raw)
In-Reply-To: <20260701122941.2149121-5-pavitrakumarm@vayavyalabs.com>
Hi Pavitrakumar,
On 7/1/26 13:29, Pavitrakumar Managutte wrote:
> +config CRYPTO_DEV_SPACC_DEBUG_TRACE_IO
> + bool "Enable Trace MMIO reads/writes stats"
> + default n
> + help
> + Say y to enable Trace MMIO reads/writes stats.
> + To Debug and trace IO register read/write oprations.
> +
Typo in "operations".
> +config CRYPTO_DEV_SPACC_DEBUG_TRACE_DDT
> + bool "Enable Trace DDT entries stats"
> + default n
> + help
> + Say y to enable Enable DDT entry stats.
> + To Debug and trace DDT opration
Another typo in "operation".
> +
> +config CRYPTO_DEV_SPACC_CONFIG_DEBUG
> + bool "Enable SPAcc debug logs"
> + default n
> + help
> + Say y to enable additional debug prints and diagnostics in the
Most of your kconfig formatting looks okay, but you strangely have 8
spaces here in your help text.
- Julian Braha
next prev parent reply other threads:[~2026-07-02 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 12:29 [PATCH v15 0/4] crypto: spacc - Add SPAcc Crypto Driver Pavitrakumar Managutte
2026-07-01 12:29 ` [PATCH v15 1/4] dt-bindings: crypto: Document support for SPAcc Pavitrakumar Managutte
2026-07-01 12:29 ` [PATCH v15 2/4] crypto: spacc - Add SPAcc ahash support Pavitrakumar Managutte
2026-07-01 12:55 ` sashiko-bot
2026-07-01 12:29 ` [PATCH v15 3/4] crypto: spacc - Add SPAcc AUTODETECT Support Pavitrakumar Managutte
2026-07-01 12:48 ` sashiko-bot
2026-07-01 12:29 ` [PATCH v15 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile Pavitrakumar Managutte
2026-07-01 13:00 ` sashiko-bot
2026-07-02 19:18 ` Julian Braha [this message]
2026-07-03 5:17 ` Pavitrakumar Managutte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb73385-a7a9-4ea9-8338-b7da999a5e9c@gmail.com \
--to=julianbraha@gmail.com \
--cc=Ruud.Derwig@synopsys.com \
--cc=adityak@vayavyalabs.com \
--cc=bhoomikak@vayavyalabs.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manjunath.hadli@vayavyalabs.com \
--cc=navami.telsang@vayavyalabs.com \
--cc=pavitrakumarm@vayavyalabs.com \
--cc=rbannerm@synopsys.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.