From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 00/13] Convert server-side NFS_ACLv3 XDR to use xdrgen
Date: Tue, 27 Oct 2026 06:56:01 -0400 [thread overview]
Message-ID: <deb7bc7a5f67003f363b0f13ff9c79b69c7e0ecb.camel@kernel.org> (raw)
In-Reply-To: <20261025151622.141025-1-cel@kernel.org>
On Sun, 2026-10-25 at 11:16 -0400, Chuck Lever wrote:
> Replace NFSD's NFS_ACLv3 XDR encoders and decoders with code that is
> mechanically generated from the protocol's RPC language description.
> No RFC defines NFS_ACL. The description in nfs_acl3.x is copied from
> draft-ietf-nfsv4-nfs-acl.
>
> Chuck Lever (13):
> Documentation: Add the RPC language description of NFS_ACLv3
> NFSD: Add infrastructure for generating NFS_ACLv3 XDR encoders and
> decoders
> NFSD: Remove '#include "xdr3.h"' from nfs3acl.c
> NFSD: New NFS_ACLv3 status codes
> NFSD: Use xdrgen XDR functions for the NFS-ACL v3 NULL procedure
> NFSD: Implement NFS-ACL v3 ACL encoding and decoding with xdrgen
> NFSD: Use xdrgen XDR functions for the NFS-ACL v3 GETACL procedure
> NFSD: Use xdrgen XDR functions for the NFS-ACL v3 SETACL procedure
> NFSD: Map every NFS_ACLv3 reply status into aclstat3
> NFSD: Remove the hand-coded XDR helpers for the NFS_ACLv3 procedures
> NFS: Move NFSACL_MAXPAGES into fs/nfs/nfs3_fs.h
> NFSD: Share the attribute conversion helpers with the NFS_ACL procs
> nfs_common: Remove the unused NFS ACL stream codecs
>
> Documentation/sunrpc/xdr/nfs_acl3.x | 273 ++++++++
> fs/nfs/nfs3_fs.h | 3 +
> fs/nfs/nfs3xdr.c | 1 +
> fs/nfs_common/nfsacl.c | 125 ----
> fs/nfsd/Makefile | 13 +-
> fs/nfsd/fattr.h | 20 +
> fs/nfsd/nfs2acl.c | 99 +--
> fs/nfsd/nfs3acl.c | 623 +++++++++++++-----
> fs/nfsd/nfs3xdr.c | 166 -----
> fs/nfsd/nfs_acl3xdr_gen.c | 839 +++++++++++++++++++++++++
> fs/nfsd/nfs_acl3xdr_gen.h | 36 ++
> fs/nfsd/nfsproc.c | 3 +-
> fs/nfsd/xdr3.h | 8 +-
> include/linux/nfsacl.h | 9 -
> include/linux/sunrpc/xdrgen/nfs_acl3.h | 284 +++++++++
> 15 files changed, 1948 insertions(+), 554 deletions(-)
> create mode 100644 Documentation/sunrpc/xdr/nfs_acl3.x
> create mode 100644 fs/nfsd/fattr.h
> create mode 100644 fs/nfsd/nfs_acl3xdr_gen.c
> create mode 100644 fs/nfsd/nfs_acl3xdr_gen.h
> create mode 100644 include/linux/sunrpc/xdrgen/nfs_acl3.h
This all looks fine to me.
Acked-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-10-27 10:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 15:16 [PATCH v1 00/13] Convert server-side NFS_ACLv3 XDR to use xdrgen Chuck Lever
2026-10-25 15:16 ` [PATCH v1 01/13] Documentation: Add the RPC language description of NFS_ACLv3 Chuck Lever
2026-10-25 15:16 ` [PATCH v1 02/13] NFSD: Add infrastructure for generating NFS_ACLv3 XDR encoders and decoders Chuck Lever
2026-10-25 15:16 ` [PATCH v1 03/13] NFSD: Remove '#include "xdr3.h"' from nfs3acl.c Chuck Lever
2026-10-25 15:16 ` [PATCH v1 04/13] NFSD: New NFS_ACLv3 status codes Chuck Lever
2026-10-25 15:16 ` [PATCH v1 05/13] NFSD: Use xdrgen XDR functions for the NFS-ACL v3 NULL procedure Chuck Lever
2026-10-25 15:16 ` [PATCH v1 06/13] NFSD: Implement NFS-ACL v3 ACL encoding and decoding with xdrgen Chuck Lever
2026-10-25 15:16 ` [PATCH v1 07/13] NFSD: Use xdrgen XDR functions for the NFS-ACL v3 GETACL procedure Chuck Lever
2026-10-25 15:16 ` [PATCH v1 08/13] NFSD: Use xdrgen XDR functions for the NFS-ACL v3 SETACL procedure Chuck Lever
2026-10-25 15:16 ` [PATCH v1 09/13] NFSD: Map every NFS_ACLv3 reply status into aclstat3 Chuck Lever
2026-10-25 15:16 ` [PATCH v1 10/13] NFSD: Remove the hand-coded XDR helpers for the NFS_ACLv3 procedures Chuck Lever
2026-10-25 15:16 ` [PATCH v1 11/13] NFS: Move NFSACL_MAXPAGES into fs/nfs/nfs3_fs.h Chuck Lever
2026-10-26 22:50 ` Anna Schumaker
2026-10-25 15:16 ` [PATCH v1 12/13] NFSD: Share the attribute conversion helpers with the NFS_ACL procs Chuck Lever
2026-10-25 15:16 ` [PATCH v1 13/13] nfs_common: Remove the unused NFS ACL stream codecs Chuck Lever
2026-10-27 10:56 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deb7bc7a5f67003f363b0f13ff9c79b69c7e0ecb.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.