From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38D653219 for ; Thu, 14 Apr 2022 19:39:36 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id t25so10837530lfg.7 for ; Thu, 14 Apr 2022 12:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=mOzDZgPKCeJFKlKho+EJ9pfBvN7kmckeP2vEOpMjjHs=; b=Sd3ErO7OkQ9pEz0AQ+nQamORwzrUBny28QC6oShE2YXaOnXjfD6nOClX3+wYdRPM0O mgNDwXW+EUFDfgFzUZXOE8/cmWB3w2fVYhV2UWB/SPJIZfrxHlXRFHMj9fFapi44c6KD Zs/bYe0gBfE2Q9CIRweCHw9k6ZPIBpE5RPvO7r4zms6FC6BiCOqG2ki/mRmDoP0IsE61 Val1oX8jQAsEyutm+o4lfKST5KyRY71jpOpiKJrx229PwR29jYdRzsBTIa/GScFhow65 LsE7eVYXSypvjlLM9HXiTmL+leHYRuvhDALHFgzTcW63l09Tv5p4xTmUIPM4BaBbUPb0 0Dig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=mOzDZgPKCeJFKlKho+EJ9pfBvN7kmckeP2vEOpMjjHs=; b=pJ8E7ETY8E55iWUjzb2pCDXNBXSN5wmtP33inRArCBF52Me81EJpad0l3+JZY56ADG LYmlu3eOCp3VCOUmBMCCdtU4O0f05Kls52ReZXmEPVtKL7xdt2VpaPghz4TnECTYd5Uy QQxuVa/5w0Ta9p0uydpwiPwyQohGbBz08unwh0YS/g2IQWuEotdeeT/0tfoWsMW7WIwV WTCZt2Hahxl0ZydVjl59kX7dIVf2kKAE8qewC3urku7oXeB0uGK5ifrwS5pEwhwisihQ pg83rPxd22GclHqm7Yn7qtFtHrfa05E2ZZ+rxh5feM9RrPn0GeJE7kOlSFLaoUsDipnw 8zYQ== X-Gm-Message-State: AOAM532lNgxCia4uVE93EO+lPnYd++pSPr263uXTL1/L/1KAqwytY6Ll EQUZPAbpHbED0FMAp3tAei0= X-Google-Smtp-Source: ABdhPJzkJADCjlo70EZY7IUyuhNy0vKezJgRvh3sNOAw1J3An09BX0DEPfgE0dur+JuCqrl8iOWDmg== X-Received: by 2002:a19:8c4b:0:b0:44a:b6a4:4873 with SMTP id i11-20020a198c4b000000b0044ab6a44873mr2753878lfj.549.1649965174316; Thu, 14 Apr 2022 12:39:34 -0700 (PDT) Received: from [192.168.1.11] ([94.103.225.17]) by smtp.gmail.com with ESMTPSA id t12-20020a2e954c000000b0024b3811ab30sm76809ljh.101.2022.04.14.12.39.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Apr 2022 12:39:34 -0700 (PDT) Message-ID: Date: Thu, 14 Apr 2022 22:39:33 +0300 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 6/7] staging: r8188eu: always log firmware info Content-Language: en-US To: Larry Finger , Michael Straube , gregkh@linuxfoundation.org Cc: phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220414083853.3422-1-straube.linux@gmail.com> <20220414083853.3422-7-straube.linux@gmail.com> <80414992-a662-e884-05ca-dcc0c8b07b99@lwfinger.net> From: Pavel Skripkin In-Reply-To: <80414992-a662-e884-05ca-dcc0c8b07b99@lwfinger.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Larry, On 4/14/22 18:36, Larry Finger wrote: > On 4/14/22 03:38, Michael Straube wrote: >> The local static variable log_version prevents logging the firmware >> information more than once, e.g. when the device is unplugged and >> plugged again. That is not necessary and complicates the code. Remove >> it. > > I think the slight complication of the code, one static variable and one if > statement, is worth not spamming the logs. My recollection is that there are > other cases besides unplugging and replugging that lead to the firmware being > reloaded. > What about pr_info_once? Anyway even with old code message printed only once per driver load With regards, Pavel Skripkin