From: okaya@codeaurora.org
To: Rajat Jain <rajatja@google.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci-owner@vger.kernel.org
Subject: Re: RFC: Counters for PCI Express AERs
Date: Thu, 17 May 2018 17:25:52 -0400 [thread overview]
Message-ID: <dee623fb19f82f3a600dd816cba9f489@codeaurora.org> (raw)
In-Reply-To: <CACK8Z6Hjxd+6qRthHEQRuo0_NXX06iDqggrVN83O0QkN=3+9gg@mail.gmail.com>
On 2018-05-17 17:05, Rajat Jain wrote:
> Hello,
>
> I have been thinking about adding counters for different kinds of AERs
> and expose them via sysfs. IMHO this would help by giving some sense
> of "link quality" for PCIe links (a lot of correctable AERs may
> indicate system is workable, but may indicate some signal integrity
> issues etc). Currently, on a correctable AER, we do log them, but
> having them in sysfs would allow userspace tools to possibly
> (periodically) poll them and raise an appropriate warning in case of
> too many errors. I know that for my purposes, getting some idea of PCI
> link quality or a way to quantize it, would help.
>
> Do you think such counters make sense or would be helpful generically?
> Also, please let me know if something like this already exists?
This question came from FB folks last year. They were told to use the
perf events for counting.
I don't honestly have a strong opinion.
>
> Thanks,
>
> Rajat
next prev parent reply other threads:[~2018-05-17 21:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 21:05 RFC: Counters for PCI Express AERs Rajat Jain
2018-05-17 21:25 ` okaya [this message]
2018-05-17 21:48 ` Rajat Jain
2018-05-17 21:52 ` Rajat Jain
2018-05-18 14:24 ` Jes Sorensen
2018-05-18 16:31 ` Rajat Jain
2018-05-23 22:20 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dee623fb19f82f3a600dd816cba9f489@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=linux-pci-owner@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.