Re: [PATCH 1/2] ASoC: cs35l56: Add support for CS35L62 for SoundWire

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

> diff --git a/sound/soc/codecs/cs35l56-sdw.c b/sound/soc/codecs/cs35l56-sdw.c
> index 0a55b93b96f96..1e442f43b306b 100644
> --- a/sound/soc/codecs/cs35l56-sdw.c
> +++ b/sound/soc/codecs/cs35l56-sdw.c
> @@ -457,6 +457,7 @@ static int cs35l56_sdw_probe(struct sdw_slave *peripheral, const struct sdw_devi
>  		regmap_config = &cs35l56_regmap_sdw;
>  		break;
>  	case 0x3563:
> +	case 0x3562:

nit-pick: is there any reason why 62 is after 63 instead of a regular
increasing order?

>  		regmap_config = &cs35l63_regmap_sdw;
>  		break;
>  	default:
> @@ -510,6 +511,7 @@ static const struct sdw_device_id cs35l56_sdw_id[] = {
>  	SDW_SLAVE_ENTRY(0x01FA, 0x3556, 0x3556),
>  	SDW_SLAVE_ENTRY(0x01FA, 0x3557, 0x3557),
>  	SDW_SLAVE_ENTRY(0x01FA, 0x3563, 0x3563),
> +	SDW_SLAVE_ENTRY(0x01FA, 0x3562, 0x3562),

same here, the devices were in increasing order until this patch.

>  	{},
>  };
>  MODULE_DEVICE_TABLE(sdw, cs35l56_sdw_id);
> diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c
> index d5817e4208479..f20bcdfd35af0 100644
> --- a/sound/soc/codecs/cs35l56-shared.c
> +++ b/sound/soc/codecs/cs35l56-shared.c
> @@ -96,6 +96,7 @@ int cs35l56_set_patch(struct cs35l56_base *cs35l56_base)
>  					    ARRAY_SIZE(cs35l56_patch_fw));
>  		break;
>  	case 0x63:
> +	case 0x62:

and here...


>  	case 0x35A630:
> +	case 0x35A620:

here as well

Maybe it's because the 62 support comes later, but no one will remember
this timeline and the code looks odd to me.