From: Jani Nikula <jani.nikula@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] tests/intel/i915_pm_rpm: Stop setting the i915.mmio_debug modparam
Date: Wed, 18 Nov 2026 12:18:12 +0200 [thread overview]
Message-ID: <df24b14ed751f4ebe61a51d91ddcd365992f9e63@intel.com> (raw)
In-Reply-To: <20261116143448.29338-1-ville.syrjala@linux.intel.com>
On Mon, 16 Nov 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The i915.mmio_debug modparam is going first change from an
> int to a boolean, and then move to the display mode (once
> that split finally happens). The kernel will reject a -1
> value for a boolean modparam, so the test would start to
> fail when the type changes. Stop setting the modparam on
> the i915 module in the test to avoid that. With the modparam
> removed the test will work on any version of the driver.
>
> The modparam will anyway default to -1 (as in mmio_debug is
> always enabled) if the kernel was built with DRM_I915_DEBUG_MMIO=y,
> or I915_DEBUG (which selects the former). So explicitly setting
> the modparam in the test would only benefit someone running the
> test on a non-debug build of the driver. I915_DEBUG should
> be enabled in the i915 CI builds.
>
> If someone really wants to set modparams in the test perhaps igt
> should grow a more generic mechanism for doing that eg. via
> environment variables...
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
> ---
> tests/intel/i915_pm_rpm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/i915_pm_rpm.c b/tests/intel/i915_pm_rpm.c
> index b4da27b21b20..ca4f645c18eb 100644
> --- a/tests/intel/i915_pm_rpm.c
> +++ b/tests/intel/i915_pm_rpm.c
> @@ -1432,7 +1432,7 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
> igt_i915_driver_unload();
>
> igt_kmsg(KMSG_INFO "Reloading i915 w/o display\n");
> - igt_assert_eq(igt_i915_driver_load("disable_display=1 mmio_debug=-1"), 0);
> + igt_assert_eq(igt_i915_driver_load("disable_display=1"), 0);
>
> igt_assert(setup_environment(false));
> pci_dev = igt_device_get_pci_device(drm_fd);
> @@ -1443,7 +1443,7 @@ int igt_main_args("", long_options, help_str, opt_handler, NULL)
> igt_i915_driver_unload();
>
> igt_kmsg(KMSG_INFO "Reloading i915 as normal\n");
> - igt_assert_eq(igt_i915_driver_load("mmio_debug=-1"), 0);
> + igt_assert_eq(igt_i915_driver_load(""), 0);
>
> igt_assert(setup_environment(true));
> pci_dev = igt_device_get_pci_device(drm_fd);
--
Jani Nikula, Intel
prev parent reply other threads:[~2026-11-18 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 14:34 [PATCH i-g-t] tests/intel/i915_pm_rpm: Stop setting the i915.mmio_debug modparam Ville Syrjala
2026-11-17 0:31 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-11-17 9:57 ` [PATCH i-g-t] " Kamil Konieczny
2026-11-17 13:47 ` ✓ Xe.CI.FULL: success for " Patchwork
2026-11-18 10:18 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df24b14ed751f4ebe61a51d91ddcd365992f9e63@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.