From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<alsa-devel@alsa-project.org>, <broonie@kernel.org>
Cc: hdegoede@redhat.com, tiwai@suse.com, amadeuszx.slawinski@linux.intel.com
Subject: Re: [PATCH 0/4] ASoC: Intel: Mark BE DAIs as nonatomic for hsw and
Date: Mon, 27 Jun 2022 18:13:00 +0200 [thread overview]
Message-ID: <df278ec8-656c-3b3c-9746-33fa53878af5@intel.com> (raw)
In-Reply-To: <650468f2-4a68-d1fa-157c-827fda5f1ed5@linux.intel.com>
On 2022-06-27 5:59 PM, Pierre-Louis Bossart wrote:
> On 6/27/22 10:41, Cezary Rojewski wrote:
>> So the framework is still fixing the flag for the driver. Ideally we
>> would like to have all the drivers assign correct values to ->nonatomic
>> flag themselves.
>>
>> Now when I think about it, the message seems useful - at least as
>> dev_dbg(). It _guides_ driver developer to the desired approach: setting
>> the ->nonatomic flag for BE to '1' if the corresponding FE is already
>> configured as such.
>
> that would result in unnecessary changes to all machine drivers to get
> rid of the message...
I would have rather used the word _optional_ here. dev_dbg() is a
diplomatic solution.
As I'm responsible for catpt and avs drivers, this very series fixes the
issue for the former. AVS driver have had the flag set appropriately
from the get go, so no fixes needed.
next prev parent reply other threads:[~2022-06-27 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 13:43 [PATCH 0/4] ASoC: Intel: Mark BE DAIs as nonatomic for hsw and Cezary Rojewski
2022-06-24 13:43 ` [PATCH 1/4] ASoC: Intel: hsw_rt5640: Mark BE DAI as nonatomic Cezary Rojewski
2022-06-24 13:43 ` [PATCH 2/4] ASoC: Intel: bdw_rt286: " Cezary Rojewski
2022-06-24 13:43 ` [PATCH 3/4] ASoC: Intel: bdw_rt5650: " Cezary Rojewski
2022-06-24 13:43 ` [PATCH 4/4] ASoC: Intel: bdw_rt5677: " Cezary Rojewski
2022-06-24 13:52 ` [PATCH 0/4] ASoC: Intel: Mark BE DAIs as nonatomic for hsw and Pierre-Louis Bossart
2022-06-25 8:29 ` Cezary Rojewski
2022-06-27 14:45 ` Pierre-Louis Bossart
2022-06-27 15:41 ` Cezary Rojewski
2022-06-27 15:59 ` Pierre-Louis Bossart
2022-06-27 16:13 ` Cezary Rojewski [this message]
2022-07-08 15:44 ` Mark Brown
2022-07-09 8:51 ` Cezary Rojewski
2022-07-15 18:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df278ec8-656c-3b3c-9746-33fa53878af5@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.