From: Krzysztof Kozlowski <krzk@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Conor Dooley <conor+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: renesas: Add R8A78000 X5H DTs
Date: Tue, 9 Sep 2025 10:38:16 +0200 [thread overview]
Message-ID: <df2dcd5d-bafc-483a-8ef5-f58ff225fc91@kernel.org> (raw)
In-Reply-To: <CAMuHMdXd6yhi2SBHBvq+0LF4kBnjm3igVb21TYaKoWSvjPGcEg@mail.gmail.com>
On 09/09/2025 09:51, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> Thanks for your quick review!
>
> On Tue, 9 Sept 2025 at 09:46, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Tue, Sep 09, 2025 at 01:45:09AM +0000, Kuninori Morimoto wrote:
>
>>> + extal_clk: extal {
>>
>> Use some sane prefix.
>>
>> https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml
>>
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + /* This value must be overridden by the board */
>>> + clock-frequency = <0>;
>>
>> Drop instead
>
> clock-frequency is a required property?
And it should be provided by the board or fail the DTS. I think now it
hides the dtbs_check warnings for no real gain/reason.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-09 8:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 1:44 [PATCH 0/4] arm64: add R8A78000 support Kuninori Morimoto
2025-09-09 1:44 ` [PATCH 1/4] dt-bindings: soc: renesas: Document R-Car X5H Ironhide Kuninori Morimoto
2025-09-09 7:48 ` Krzysztof Kozlowski
2025-09-09 1:45 ` [PATCH 2/4] soc: renesas: Identify R-Car X5H Kuninori Morimoto
2025-09-09 1:45 ` [PATCH 3/4] arm64: dts: renesas: Add R8A78000 X5H DTs Kuninori Morimoto
2025-09-09 7:46 ` Krzysztof Kozlowski
2025-09-09 7:51 ` Geert Uytterhoeven
2025-09-09 8:38 ` Krzysztof Kozlowski [this message]
2025-09-09 8:50 ` Geert Uytterhoeven
2025-09-09 8:55 ` Krzysztof Kozlowski
2025-09-09 1:45 ` [PATCH 4/4] arm64: renesas: Add R8A78000 Ironhide board code Kuninori Morimoto
2025-09-09 7:47 ` Krzysztof Kozlowski
2025-09-09 23:39 ` Kuninori Morimoto
2025-09-10 7:11 ` Krzysztof Kozlowski
2025-09-10 12:45 ` Geert Uytterhoeven
2025-09-11 7:16 ` Krzysztof Kozlowski
2025-09-11 7:24 ` Geert Uytterhoeven
2025-09-11 8:45 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2dcd5d-bafc-483a-8ef5-f58ff225fc91@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.