From: Takis <panagiotis.issaris@gmail.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: ipw2100-admin@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipw2200: Missing kmalloc check
Date: Mon, 5 Sep 2005 16:26:21 +0200 [thread overview]
Message-ID: <df33fe7c050905072642a9c938@mail.gmail.com> (raw)
In-Reply-To: <431C31A5.3080804@gmail.com>
On 9/5/05, Jiri Slaby <jirislaby@gmail.com> wrote:
> > rxq = (struct ipw_rx_queue *)kmalloc(sizeof(*rxq), GFP_KERNEL);
> >+ if (unlikely(!rxq)) {
> >+ IPW_ERROR("memory allocation failed\n");
> >+ return NULL;
> >+ }
> > memset(rxq, 0, sizeof(*rxq));
> >
> >
> and use kzalloc instead of kmalloc and memset 0?
Yes, but Morton's tree hasn't got the ipw2200 yet, while Linus'
Linux-tree hasn't pulled in the patches containing kzalloc. I'll send
a new patch as soon as the kzalloc patch get in Linus' tree or ipw in
Marton's.
With friendly regards,
Takis
next prev parent reply other threads:[~2005-09-05 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-05 2:14 [PATCH] ipw2200: Missing kmalloc check Panagiotis Issaris
2005-09-05 11:53 ` Jiri Slaby
2005-09-05 14:26 ` Takis [this message]
2005-10-28 20:57 ` Jeff Garzik
2005-11-07 18:32 ` Rolf Eike Beer
2005-11-07 20:35 ` Takis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df33fe7c050905072642a9c938@mail.gmail.com \
--to=panagiotis.issaris@gmail.com \
--cc=ipw2100-admin@linux.intel.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.