From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B69C43334 for ; Sat, 9 Jul 2022 16:23:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6489F845D6; Sat, 9 Jul 2022 18:23:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="iBpAEZav"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 85AC0845D9; Sat, 9 Jul 2022 18:23:00 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B9EA8449B for ; Sat, 9 Jul 2022 18:22:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ej1-x632.google.com with SMTP id h23so2314396ejj.12 for ; Sat, 09 Jul 2022 09:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=k8XxlMoRiKMhXotEnKqVXrJ6HmwlqFBG3mexAXC3E/Q=; b=iBpAEZavVnOL7HSpPTRxH2naPYsYuuH66jrlpm/ANhN463RpS5+HCZgfHPxJk13e5g uEPyG8N5FVRsS1ZWAOSeeSmSNIHVBIerkqe45h3JFU1rjUp4t4OGbMYhSHElTRMTDmsf ihGnDtvLsZlVtD4/N6K577BU+fahIs0EjorLoVbYyINO1pPFGE7BuHwHx+Y5mVtlxqYl fqNEevs+Lg6Edc5Fufgn9GyWwNdAuMQN89cQIkO1IngNkVX6izPo3c3UAt6ahoPnSi5b chzsxh3ArpkXnALtSFzuaRRwtsZEgHiws0OzzSMD4cfN2jRYQ+whh7LGtFt/9FlRZy2x 4BRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=k8XxlMoRiKMhXotEnKqVXrJ6HmwlqFBG3mexAXC3E/Q=; b=5Gn73u0rjusKZUOme1Vpe0DlFh7n0JkmU0GpZq0RU892QAPz5QsQaOHaP7LRKaqFqa rjBIKHj4IaoJNcn2E32tVH6guH22IkIGwgHT7jivzne1Q3FDLO6R0sIXCKlf+ZsA6+1S lOzx1qN2tQEgHeHnAeLHNI/G2S2ZWzRlEyhD1djgk9/9O3idWfSKUyhpq7fz8AZRf35k Y8kcZNKhkC1uFVOMWDq5dHy1EdFg9qr6pbsWVryJ29GJFyKmSY4vSf602MvLtOgGlLg/ qZVYbri1THhM2goSU0uUodPmTJqW3Fch+/kVQz/KFtMWGkycM58Ccw1/sbYKXlggKPKt Dg2A== X-Gm-Message-State: AJIora911ou/+caJhO3nqDE0S9ZxlVZO2vbGm+aKfEXUzUDNAb59Q4Ix 4y/AuVxBZpDr2qOS7CXVN9E= X-Google-Smtp-Source: AGRyM1vUoDU5YP58+L3AQU72MfZhSSIEgxi91N1h/v5kXYFd2oEePgE7iij3Ooijyo2thAQaGOaBNQ== X-Received: by 2002:a17:907:3d93:b0:726:3ade:a299 with SMTP id he19-20020a1709073d9300b007263adea299mr9712535ejc.635.1657383777456; Sat, 09 Jul 2022 09:22:57 -0700 (PDT) Received: from [192.168.10.30] (i5E8605B8.versanet.de. [94.134.5.184]) by smtp.gmail.com with ESMTPSA id fn15-20020a1709069d0f00b006fecf74395bsm746397ejc.8.2022.07.09.09.22.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Jul 2022 09:22:55 -0700 (PDT) Message-ID: Date: Sat, 9 Jul 2022 18:22:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PULL] u-boot-mips for u-boot/next (v2022.10) Content-Language: en-US To: Tom Rini Cc: Weijie Gao , u-boot@lists.denx.de References: <20220708152148.21816-1-daniel.schwierzeck@gmail.com> <20220708165046.GN1146598@bill-the-cat> <236ddd8a-3c7f-96fa-7949-b23e114dc8a6@gmail.com> <20220709124302.GH1146598@bill-the-cat> From: Daniel Schwierzeck In-Reply-To: <20220709124302.GH1146598@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 09.07.22 14:43, Tom Rini wrote: > On Sat, Jul 09, 2022 at 02:01:01PM +0200, Daniel Schwierzeck wrote: >> Hi Tom, >> >> On 08.07.22 18:50, Tom Rini wrote: >>> On Fri, Jul 08, 2022 at 05:21:48PM +0200, Daniel SchwierzeckHi Tom, wrote: >>>> >>>> Gitlab CI: >>>> https://source.denx.de/u-boot/custodians/u-boot-mips/-/pipelines/12656 >>>> >>>> Azure: >>>> https://dev.azure.com/danielschwierzeck/u-boot/_build/results?buildId=30&view=results >>>> >>>> >>>> The following changes since commit 2d2c61ff0460740d9ec5a44dbef9255a8c690696: >>>> >>>> Merge tag 'efi-2022-07-rc7' of https://source.denx.de/u-boot/custodians/u-boot-efi (2022-07-06 09:17:08 -0400) >>>> >>>> are available in the Git repository at: >>>> >>>> https://source.denx.de/u-boot/custodians/u-boot-mips.git/ tags/mips-pull-2022-07-08 >>>> >>>> for you to fetch changes up to e5fc4022af3cfd59e3459276305671a595ac5ff0: >>>> >>>> MAINTAINERS: update maintainer for MediaTek MIPS platform (2022-07-08 15:13:29 +0200) >>>> >>>> ---------------------------------------------------------------- >>>> - MIPS: add drivers and board support for Mediatek MT7621 SoC >>> >>> OK, we need a few changes here, sorry. There's now migrated CONFIG >>> symbols, most of which are easy to do and I was about to, and then I saw >>> this: >>> #ifdef CONFIG_TPL_BUILD >>> #define CONFIG_SPL_START_S_PATH "arch/mips/mach-mtmips/mt7621/tpl" >>> /* .bss will not be used by TPL */ >>> #define CONFIG_SPL_BSS_START_ADDR 0x80000000 >>> #define CONFIG_SPL_BSS_MAX_SIZE 0 >>> #else >>> #define CONFIG_SPL_START_S_PATH "arch/mips/mach-mtmips/mt7621/spl" >>> #define CONFIG_SPL_BSS_START_ADDR 0x80140000 >>> #define CONFIG_SPL_BSS_MAX_SIZE 0x80000 >>> #define CONFIG_SPL_MAX_SIZE 0x30000 >>> #endif >>> >>> No, you cannot abuse CONFIG_TPL_BUILD to set CONFIG_SPL_foo. Those need >>> to become CONFIG_TPL_foo, and set appropriately. And then for >>> [ST]PL_START_S_PATH, you need to set head-$(CONFIG_ARCH_xxx) to the >>> right file, for SPL/TPL instead. >>> >> >> do you already have patches for converting stuff like >> CONFIG_SPL_BSS_START_ADDR prepared? Than I would wait with the pull request >> until those patches are applied to mainline and I would adapt the MT7621 >> patches. >> >> I could also assist with converting CONFIG_SPL_START_S_PATH because that's >> only used on MIPS and one ARM board. > > See what's in -next already? SPL_BSS_START_ADDR is migrated, but there > were no TPL_BSS_START_ADDR cases. For START_S_PATH, the platform just > needs to be reworked as I suggested above I believe, to achieve the > desired result. > sorry, didn't check the latest updates in -next and the series was too long on the list ;) TPL_BSS_START_ADDR shouldn't be necessary because MT7621 doesn't use BSS in TPL, the defined values where just dummy values. I rechecked and removed all migrated Kconfig options from mt7621.h and pushed an update to u-boot-mips/next. Weijie could you verify that? If all is okay, I'll prepare a new pull request, otherwise please send me a v7 patch series. -- - Daniel