Re: [2.6 patch] drivers/scsi/sg.c: several against 2.6.12-rc1

[Yum Rayan <yum.rayan@gmail.com>]

In the diff

>+	if (old_hdr)
>+		kfree(old_hdr);
>+	return retval;

The check for NULL is not needed.

Thanks,
Rayan


On Mon, 28 Mar 2005 19:48:10 +1000, Douglas Gilbert <dougg@torque.net> wrote:
> The attachment combines the most recent patch from
> Yum Rayan <yum.rayan@gmail.com> (to reduce sg stack
> usage), Adrian Bunk <bunk@stusta.de> (to fix check
> after use) and me (fix elapsed time calculation
> (duration) on ia64 machines).
> 
> I have modified the patch from Yum Rayan so kmalloc()
> in sg_read() is only called for the (rare) code paths
> that need them.
> 
> Changelog:
>   - reduce stack usage in sg_ioctl() and sg_read()
>   - fix check after use in sg_mmap()
>   - hold duration internally in milliseconds and
>     check current time later than held time
> 
> Signed-off-by: Douglas Gilbert <dougg@torque.net>
> 
> 
>