From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A621CFBA for ; Mon, 25 May 2026 13:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779716747; cv=none; b=pY9BFRhnS24JaVB/9d0HMnRf+FoIqz6o44TIjpnPDPHo+k1tQh4+a1rZvhlFeX5E0dHXSiQGLBKKEzOwnEuDCFvz17iWRHDwnGw3MlSf6SpaQjEu2+smOhBOumtHrr/YGbuCqMiVGgIqECcKWs8he3B3NMIfIKerR2izZjjtL2k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779716747; c=relaxed/simple; bh=/MYkTSIm7n+OcGwqd19/UFHKU+18/6PWELZmIJ5DaOU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u77wVQNnEVdW1f896BqSWyh5eAV6kUvKMyUXFR7x+1d09vsqW9RgeBWRTYc8tOMrlS1LYEiriE4d4SQlbHMQSjAHy3fPRHQp95dF2W2r5c+GcYVsiwLkF0XWw7jwHy+pyDHeb2Ss2DWh667lUvr521Z5xggVvfhL560uGWarGck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XccOCVEl; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=SFABcR+j; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=XccOCVEl; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=SFABcR+j; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XccOCVEl"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SFABcR+j"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="XccOCVEl"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="SFABcR+j" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 28D936AFFE; Mon, 25 May 2026 13:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779716744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6L4trA6yvlqeOnpDbhTVf6hAA4JKi6VNVixyDvp5mUg=; b=XccOCVElHpzyF1ejKMl+W0xB5+OaOGFTQKYzZpTdHf21JTjpqWDtal5x3f0xsruzfXcLWF I5sVehBrHjIJbz75N+cL1MupcvJGVNr/BD7odUNWVaQFJ7EUAV77xrYoYquLx8zWCv/bte McTQtS5E7v2Wt6CQeaEzO7YZJ3YqFmE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779716744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6L4trA6yvlqeOnpDbhTVf6hAA4JKi6VNVixyDvp5mUg=; b=SFABcR+jZ7RWpzi+sOMwnszvBHQda7DXw4FwoCf8BHeNfH4ZWlzuFJw8SuTwiuUYe4cDLz h4udJuDUFQN2kUAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XccOCVEl; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=SFABcR+j DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1779716744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6L4trA6yvlqeOnpDbhTVf6hAA4JKi6VNVixyDvp5mUg=; b=XccOCVElHpzyF1ejKMl+W0xB5+OaOGFTQKYzZpTdHf21JTjpqWDtal5x3f0xsruzfXcLWF I5sVehBrHjIJbz75N+cL1MupcvJGVNr/BD7odUNWVaQFJ7EUAV77xrYoYquLx8zWCv/bte McTQtS5E7v2Wt6CQeaEzO7YZJ3YqFmE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1779716744; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6L4trA6yvlqeOnpDbhTVf6hAA4JKi6VNVixyDvp5mUg=; b=SFABcR+jZ7RWpzi+sOMwnszvBHQda7DXw4FwoCf8BHeNfH4ZWlzuFJw8SuTwiuUYe4cDLz h4udJuDUFQN2kUAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CE45359C8D; Mon, 25 May 2026 13:45:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id amhZL4dSFGriBwAAD6G6ig (envelope-from ); Mon, 25 May 2026 13:45:43 +0000 Message-ID: Date: Mon, 25 May 2026 15:45:31 +0200 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4 nf v2] netfilter: synproxy: fix possible write to stale pointer To: netfilter-devel@vger.kernel.org Cc: coreteam@netfilter.org, pablo@netfilter.org, fw@strlen.de, phil@nwl.cc References: <20260525124450.6043-1-fmancera@suse.de> <20260525124450.6043-5-fmancera@suse.de> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260525124450.6043-5-fmancera@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.51 X-Rspamd-Queue-Id: 28D936AFFE X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,suse.de:email,suse.de:mid]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Flag: NO On 5/25/26 2:44 PM, Fernando Fernandez Mancera wrote: > skb_ensure_writable() is called to guarantee that the TCP options area > can be safely modified when adjusting the timestamp. As it expands or > linearize the skb head it might reallocate the data buffer. > > This makes the th pointer passed by the caller stale. The following > writes to the TCP header might be done to a stale pointer. > > Recalculating the th pointer after skb_ensure_writable() prevents this > issue from happening. > > Fixes: 48b1de4c110a ("netfilter: add SYNPROXY core/target") > Signed-off-by: Fernando Fernandez Mancera LOL. I just realized I already reviewed this at: https://lore.kernel.org/netfilter-devel/20260522104257.2008-3-fw@strlen.de/T/#u *facepalm* sorry for the noise, Florian could you ignore this patch but consider the other 3 fixes? Thanks and I apologize again! Fernando.