From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD7EC7EE24 for ; Tue, 6 Jun 2023 10:06:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9538810E327; Tue, 6 Jun 2023 10:06:26 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BC9610E327 for ; Tue, 6 Jun 2023 10:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686045984; x=1717581984; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6oloyQZvNgdh4kknkuLngvKtlBcNeVUDmUMH7N/Ynrw=; b=naLF32L9A8tqrvAWOLt3n6eIuuX9XOofiDliF6AhDKeWM3yOedrLKqub ewLFRea+FnvA5I7D5rPsEjUlIVZzTVR5o/V1BC116QusdFSrdYQ2K6m+z STM4A9JrUj48a3oPc868oXW4VU31can3PpKdsR4HLxiG4QQsyoc6GnGMn UjY+chfCWmFihAmoIBRq6K87nqmlwN4gDUVkR40XkkC9fbMakuFMicD/X lcPOD8W47tn9i0G9Q9eYh4mj2JJMq0rISxQ7hwXIsNqs6VoPajHrrVR2c elN/5dYmQlwEyq4xWzZN2m3vY0HHNZ2ZaeyJpGhgCf7Nds0GvmziPrU4u Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="359940823" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="359940823" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 03:06:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="742088071" X-IronPort-AV: E=Sophos;i="6.00,219,1681196400"; d="scan'208";a="742088071" Received: from wacarey-mobl1.ger.corp.intel.com (HELO [10.213.192.12]) ([10.213.192.12]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jun 2023 03:06:23 -0700 Message-ID: Date: Tue, 6 Jun 2023 11:06:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Jani Nikula , Luca Coelho References: <20230530111534.871403-1-luciano.coelho@intel.com> <168551428578.17615.13321848387509410861@emeril.freedesktop.org> <87r0qqaqz2.fsf@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <87r0qqaqz2.fsf@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLkJBVDogZmFpbHVyZSBmb3IgZHJt?= =?utf-8?q?/i915=3A_implement_internal_workqueues_=28rev3=29?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 05/06/2023 16:06, Jani Nikula wrote: > On Wed, 31 May 2023, Patchwork wrote: >> #### Possible regressions #### >> >> * igt@gem_close_race@basic-process: >> - fi-blb-e6850: [PASS][1] -> [ABORT][2] >> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/fi-blb-e6850/igt@gem_close_race@basic-process.html >> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/fi-blb-e6850/igt@gem_close_race@basic-process.html >> - fi-hsw-4770: [PASS][3] -> [ABORT][4] >> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/fi-hsw-4770/igt@gem_close_race@basic-process.html >> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/fi-hsw-4770/igt@gem_close_race@basic-process.html >> - fi-elk-e7500: [PASS][5] -> [ABORT][6] >> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/fi-elk-e7500/igt@gem_close_race@basic-process.html >> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/fi-elk-e7500/igt@gem_close_race@basic-process.html >> >> * igt@i915_selftest@live@evict: >> - bat-adlp-9: [PASS][7] -> [ABORT][8] >> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/bat-adlp-9/igt@i915_selftest@live@evict.html >> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/bat-adlp-9/igt@i915_selftest@live@evict.html >> - bat-rpls-2: [PASS][9] -> [ABORT][10] >> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/bat-rpls-2/igt@i915_selftest@live@evict.html >> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/bat-rpls-2/igt@i915_selftest@live@evict.html >> - bat-adlm-1: [PASS][11] -> [ABORT][12] >> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/bat-adlm-1/igt@i915_selftest@live@evict.html >> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/bat-adlm-1/igt@i915_selftest@live@evict.html >> - bat-rpls-1: [PASS][13] -> [ABORT][14] >> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13203/bat-rpls-1/igt@i915_selftest@live@evict.html >> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117618v3/bat-rpls-1/igt@i915_selftest@live@evict.html > > This still fails consistently, I have no clue why, and the above aren't > even remotely related to display. > > What now? Tvrtko? Hmm.. <4> [46.782321] Chain exists of: (wq_completion)i915 --> (work_completion)(&i915->mm.free_work) --> &vm->mutex <4> [46.782329] Possible unsafe locking scenario: <4> [46.782332] CPU0 CPU1 <4> [46.782334] ---- ---- <4> [46.782337] lock(&vm->mutex); <4> [46.782340] lock((work_completion)(&i915->mm.free_work)); <4> [46.782344] lock(&vm->mutex); <4> [46.782348] lock((wq_completion)i915); "(wq_completion)i915" So it's not about the new wq even. Perhaps it is this hunk: --- a/drivers/gpu/drm/i915/intel_wakeref.c +++ b/drivers/gpu/drm/i915/intel_wakeref.c @@ -75,7 +75,7 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags) /* Assume we are not in process context and so cannot sleep. */ if (flags & INTEL_WAKEREF_PUT_ASYNC || !mutex_trylock(&wf->mutex)) { - mod_delayed_work(system_wq, &wf->work, + mod_delayed_work(wf->i915->wq, &wf->work, Transformation from this patch otherwise is system_wq with the new unordered wq, so I'd try that first. Regards, Tvrtko