From: Jens Axboe <axboe@kernel.dk>
To: Hao Xu <haoxu.linux@gmail.com>, io-uring@vger.kernel.org
Cc: Pavel Begunkov <asml.silence@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] fast poll multishot mode
Date: Sun, 8 May 2022 06:49:24 -0600 [thread overview]
Message-ID: <df7755df-869d-86a9-bcd5-db0fd2762d31@kernel.dk> (raw)
In-Reply-To: <0b52bbd2-56de-c213-df3f-73f0f83a1f3a@gmail.com>
On 5/7/22 11:21 AM, Hao Xu wrote:
> 在 2022/5/8 上午12:11, Jens Axboe 写道:
>> On 5/7/22 10:05 AM, Hao Xu wrote:
>>>> But we still need to consider direct accept with multishot... Should
>>>> probably be an add-on patch as I think it'd get a bit more complicated
>>>> if we need to be able to cheaply find an available free fixed fd slot.
>>>> I'll try and play with that.
>>>
>>> I'm tending to use a new mail account to send v4 rather than the gmail
>>> account since the git issue seems to be network related.
>>> I'll also think about the fixed fd problem.
>>
>> Two basic attached patches that attempt do just alloc a fixed file
>> descriptor for this case. Not tested at all... We return the fixed file
>> slot in this case since we have to, to let the application know what was
>> picked. I kind of wish we'd done that with direct open/accept to begin
>> with anyway, a bit annoying that fixed vs normal open/accept behave
>> differently.
>>
>> Anyway, something to play with, and I'm sure it can be made better.
>>
> Thanks. I tried to fix the mail account issue, still unclear what is
> wrong, and too late at my timezone now, I'll try to send v4 tomorrow
No worries. IN the meantime, I played with allocated direct descriptors
yesterday and implemented them for openat/openat2/accept:
https://git.kernel.dk/cgit/linux-block/log/?h=fastpoll-mshot
It's independent of multishot accept in the sense that you can use it
without that, but multishot accept requires it with fixed files.
--
Jens Axboe
next prev parent reply other threads:[~2022-05-08 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-07 14:06 [PATCH v3 0/4] fast poll multishot mode Hao Xu
2022-05-07 14:06 ` [PATCH 1/4] io_uring: add IORING_ACCEPT_MULTISHOT for accept Hao Xu
2022-05-07 14:16 ` Jens Axboe
2022-05-07 15:31 ` Hao Xu
2022-05-07 15:38 ` Jens Axboe
2022-05-07 15:52 ` Hao Xu
2022-05-07 15:57 ` Jens Axboe
2022-05-07 16:07 ` Hao Xu
2022-05-07 14:06 ` [PATCH 2/4] io_uring: add REQ_F_APOLL_MULTISHOT for requests Hao Xu
2022-05-07 14:06 ` [PATCH 3/4] io_uring: let fast poll support multishot Hao Xu
2022-05-07 15:28 ` [PATCH v3 0/4] fast poll multishot mode Jens Axboe
2022-05-07 16:05 ` Hao Xu
2022-05-07 16:11 ` Jens Axboe
2022-05-07 17:21 ` Hao Xu
2022-05-08 12:49 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-07 12:38 Hao Xu
2022-05-07 14:06 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df7755df-869d-86a9-bcd5-db0fd2762d31@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=haoxu.linux@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.