From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/19] drm/i915/execlists: Double check rpm wakeref Date: Thu, 17 May 2018 12:04:15 +0100 Message-ID: References: <20180517074055.14638-1-chris@chris-wilson.co.uk> <20180517074055.14638-11-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 82D5F6E7C1 for ; Thu, 17 May 2018 11:04:18 +0000 (UTC) In-Reply-To: <20180517074055.14638-11-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA1LzIwMTggMDg6NDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBBcyB3ZSBhcmUgc3Bs aXR0aW5nIHByb2Nlc3NpbmcgdGhlIENTQiBldmVudHMgZnJvbSBzdWJtaXR0aW5nIHRoZSBFTFNQ LAo+IHdlIGFsc28gbmVlZCB0byBkdXBsaWNhdGUgdGhlIGNoZWNrIHRoYXQgd2UgaG9sZCBhIGRl dmljZSB3YWtlcmVmIGZvciBvdXIKPiBoYXJkd2FyZSBhY2Nlc3MgdG8gdGhlIGRpc2pvaW50IGxv Y2F0aW9ucy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwg MjYgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNl cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ IGluZGV4IDQ5MjhlOWFkNzgyNi4uNmQzYjAzMjk5YjBjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPiBAQCAtNDQ5LDYgKzQ0OSwxNiBAQCBzdGF0aWMgdm9pZCBleGVjbGlzdHNfc3Vi bWl0X3BvcnRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAlzdHJ1Y3QgZXhl Y2xpc3RfcG9ydCAqcG9ydCA9IGV4ZWNsaXN0cy0+cG9ydDsKPiAgIAl1bnNpZ25lZCBpbnQgbjsK PiAgIAo+ICsJLyoKPiArCSAqIFdlIGNhbiBza2lwIGFjcXVpcmluZyBpbnRlbF9ydW50aW1lX3Bt X2dldCgpIGhlcmUgYXMgaXQgd2FzIHRha2VuCj4gKwkgKiBvbiBvdXIgYmVoYWxmIGJ5IHRoZSBy ZXF1ZXN0IChzZWUgaTkxNV9nZW1fbWFya19idXN5KCkpIGFuZCBpdCB3aWxsCj4gKwkgKiBub3Qg YmUgcmVsaW5xdWlzaGVkIHVudGlsIHRoZSBkZXZpY2UgaXMgaWRsZSAoc2VlCj4gKwkgKiBpOTE1 X2dlbV9pZGxlX3dvcmtfaGFuZGxlcigpKS4gQXMgYSBwcmVjYXV0aW9uLCB3ZSBtYWtlIHN1cmUK PiArCSAqIHRoYXQgYWxsIEVMU1AgYXJlIGRyYWluZWQgaS5lLiB3ZSBoYXZlIHByb2Nlc3NlZCB0 aGUgQ1NCLAo+ICsJICogYmVmb3JlIGFsbG93aW5nIG91cnNlbHZlcyB0byBpZGxlIGFuZCBjYWxs aW5nIGludGVsX3J1bnRpbWVfcG1fcHV0KCkuCj4gKwkgKi8KPiArCUdFTV9CVUdfT04oIWVuZ2lu ZS0+aTkxNS0+Z3QuYXdha2UpOwoKSG1tLi4gSSB0aGluayBpdCB3b3VsZCBiZSBiZXR0ZXIgdG8g bGVhdmUgaXQgaW4gdGhlIHRhc2tsZXQgYW5kIGp1c3QgYWRkIAphbm90aGVyIGluc3RhbmNlIHRv IHByb2Nlc3NfY3NiLgoKSGF2aW5nIGl0IG9ubHkgZGVlcCBpbiBleGVjbGlzdHNfc3VibWl0X3Bv cnRzIGNvdWxkIG1pc3MgY29uZnVzaW9ucyB3aGVuIAp1cHBlciBsYXllcnMgd2FudCB0byBzdWJt aXQgYW5kIHN0YXRlIHNheSBpdCBpcyBub3QgcG9zc2libGUgeWV0LgoKPiArCj4gICAJLyoKPiAg IAkgKiBFTFNRIG5vdGU6IHRoZSBzdWJtaXQgcXVldWUgaXMgbm90IGNsZWFyZWQgYWZ0ZXIgYmVp bmcgc3VibWl0dGVkCj4gICAJICogdG8gdGhlIEhXIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHdl IGFsd2F5cyBjbGVhbiBpdCB1cC4gVGhpcyBpcwo+IEBAIC05NTksNiArOTY5LDEyIEBAIHN0YXRp YyB2b2lkIHByb2Nlc3NfY3NiKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAlz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSA9IGVuZ2luZS0+aTkxNTsKPiAgIAlib29sIGZ3 ID0gZmFsc2U7Cj4gICAKPiArCS8qCj4gKwkgKiBXZSBtdXN0IG5ldmVyIHJlbGVhc2Ugb3VyIGRl dmljZSB3YWtlcmVmIHVudGlsIGFmdGVyIHdlIGhhdmUKPiArCSAqIGZpbmlzaGVkIHByb2Nlc3Np bmcgYWxsIHBvdGVudGlhbCBpbnRlcnJ1cHRzIGZyb20gdGhlIGhhcmR3YXJlLgo+ICsJICovCj4g KwlHRU1fQlVHX09OKCFlbmdpbmUtPmk5MTUtPmd0LmF3YWtlKTsKPiArCj4gICAJZG8gewo+ICAg CQkvKiBUaGUgSFdTUCBjb250YWlucyBhIChjYWNoZWFibGUpIG1pcnJvciBvZiB0aGUgQ1NCICov Cj4gICAJCWNvbnN0IHUzMiAqYnVmID0KPiBAQCAtMTEzOSwxNiArMTE1NSw2IEBAIHN0YXRpYyB2 b2lkIGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBkYXRhKQo+ICAg CQkgIGVuZ2luZS0+ZXhlY2xpc3RzLmFjdGl2ZSwKPiAgIAkJICB0ZXN0X2JpdChFTkdJTkVfSVJR X0VYRUNMSVNULCAmZW5naW5lLT5pcnFfcG9zdGVkKSk7Cj4gICAKPiAtCS8qCj4gLQkgKiBXZSBj YW4gc2tpcCBhY3F1aXJpbmcgaW50ZWxfcnVudGltZV9wbV9nZXQoKSBoZXJlIGFzIGl0IHdhcyB0 YWtlbgo+IC0JICogb24gb3VyIGJlaGFsZiBieSB0aGUgcmVxdWVzdCAoc2VlIGk5MTVfZ2VtX21h cmtfYnVzeSgpKSBhbmQgaXQgd2lsbAo+IC0JICogbm90IGJlIHJlbGlucXVpc2hlZCB1bnRpbCB0 aGUgZGV2aWNlIGlzIGlkbGUgKHNlZQo+IC0JICogaTkxNV9nZW1faWRsZV93b3JrX2hhbmRsZXIo KSkuIEFzIGEgcHJlY2F1dGlvbiwgd2UgbWFrZSBzdXJlCj4gLQkgKiB0aGF0IGFsbCBFTFNQIGFy ZSBkcmFpbmVkIGkuZS4gd2UgaGF2ZSBwcm9jZXNzZWQgdGhlIENTQiwKPiAtCSAqIGJlZm9yZSBh bGxvd2luZyBvdXJzZWx2ZXMgdG8gaWRsZSBhbmQgY2FsbGluZyBpbnRlbF9ydW50aW1lX3BtX3B1 dCgpLgo+IC0JICovCj4gLQlHRU1fQlVHX09OKCFlbmdpbmUtPmk5MTUtPmd0LmF3YWtlKTsKPiAt Cj4gICAJLyoKPiAgIAkgKiBQcmVmZXIgZG9pbmcgdGVzdF9hbmRfY2xlYXJfYml0KCkgYXMgYSB0 d28gc3RhZ2Ugb3BlcmF0aW9uIHRvIGF2b2lkCj4gICAJICogaW1wb3NpbmcgdGhlIGNvc3Qgb2Yg YSBsb2NrZWQgYXRvbWljIHRyYW5zYWN0aW9uIHdoZW4gc3VibWl0dGluZyBhCj4gCgpSZWdhcmRz LAoKVHZydGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=