From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD726E7718C for ; Thu, 19 Dec 2024 16:21:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tOJFT-0001nD-R9; Thu, 19 Dec 2024 11:19:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOHqQ-0003wS-4f for qemu-devel@nongnu.org; Thu, 19 Dec 2024 09:49:42 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tOHqO-0003BU-Hu for qemu-devel@nongnu.org; Thu, 19 Dec 2024 09:49:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734619779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YeKKHU/ajVLrrPJBKu8upioH7pGc7GBIsSqRFh8BLRY=; b=TnU3HUl+pyxH+0NXIt9YglEvbFAxALa4Wcf94eRVH8+3GcOUcbwWDn+Npyoji051/Py7HC eajEr46DmWdQUYpS3Q0T78+x1PHRzlOwWQsgaIvORIBYu2NZTiPnfqkWd1pcycE7/TkCC+ SYoGL0Yyen98gYOf9zVqYdX2Oz6I6lg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-3Td_xYnTMK224Y0kCEL8RA-1; Thu, 19 Dec 2024 09:49:38 -0500 X-MC-Unique: 3Td_xYnTMK224Y0kCEL8RA-1 X-Mimecast-MFC-AGG-ID: 3Td_xYnTMK224Y0kCEL8RA Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4361b090d23so5509075e9.0 for ; Thu, 19 Dec 2024 06:49:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734619777; x=1735224577; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YeKKHU/ajVLrrPJBKu8upioH7pGc7GBIsSqRFh8BLRY=; b=XiDkBrR4vybBU4s6uf4d/N4OCoiiQIhvUpQt92bFQZm78STboXcRXfLcEnnNgr8yIA nPfZymSXtLRJZNF4cov5jZWyTi6GvR8m02NRireY+i/AvjfuzBM3kIYAAKst9+f0jQrj GI6W21DraMT4zdQ8MCeuohcHciv5hcAyShXCz9TWGmkmWCQ049nnwdknPMEwyOsaeLUZ 8NxBjtyFl/quCH6Lri4IPT/PsyaV9qsKfX03YR/4IA/SnD7Q23e7irlupX5YUYpJ0/le jr7ptcdzPI2fBOycFc7RDUdZptPFpMel2X97vXM6+BgIuMD1neyienHcHPAIC4OgXbvV 513g== X-Forwarded-Encrypted: i=1; AJvYcCXlG0bmXGnZXeItqTiOdqUdoUkB+iXcIThT1D/Dxz+enyfimBZ4rrbJdP9L4fYSFPHJemvtoIqQ0brf@nongnu.org X-Gm-Message-State: AOJu0Yylx3/0M8QTSC8VEXIKOqg8Cmo4jdlpwDvjVRARM+16E1CqcBsg gA+zB0C415h7mO5q5P5LKPvoOuoXBKutJvpx29HcjmdOxdYXYYkoD5P0A42rl48HkXs1qYvDumR Xv/iwYPzsG7UnvartErrdf0a4DOmQTZIKIpGpCYkUv7nwiTmtwYzf X-Gm-Gg: ASbGncvI9vMgFda/7kdguoIFr40Sb67vlSP1tcJRUFyu9LBQTq0I2gFxtuLGPgeMvPk KCzoV/PZLnfFRMtQtG0euYvx/SHchA5YaY+RMgVILxQ0jb/0dJCeqWm0uCOiXUpjsZRqjxFaatS YNlfBImV6won7y+TmMaTeuNfbmc9GiQGrglXe9i7zAzrjdtUi5X4tIrDcvIkTv51Z3fMVez9NS9 dUMmhcwDrEwJ84zMd9bSBmMR4ZRoMTmj2/EPTZayokm42gswKXVFEZkm62xA5ddPp5GDrLpb/37 gwWJuGH5zq5VFCAo8tCCuyG8+Tq1qtRggZXTZwu1CaCOmRVtA/IzHn/OTKL82vf8jSb3Vk0h+jg LSJI84A== X-Received: by 2002:a05:600c:458e:b0:431:54d9:da57 with SMTP id 5b1f17b1804b1-4365c7dbe67mr37042645e9.30.1734619776895; Thu, 19 Dec 2024 06:49:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4GpGzymNrQqDlt2csAvyDDB064d5Q9DHQzKQSbx6B7AdWYzbjVTryIbU8wzNoGcs7t5fQrQ== X-Received: by 2002:a05:600c:458e:b0:431:54d9:da57 with SMTP id 5b1f17b1804b1-4365c7dbe67mr37042335e9.30.1734619776498; Thu, 19 Dec 2024 06:49:36 -0800 (PST) Received: from ?IPV6:2003:cb:c749:6600:b73a:466c:e610:686? (p200300cbc7496600b73a466ce6100686.dip0.t-ipconnect.de. [2003:cb:c749:6600:b73a:466c:e610:686]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43656b3b1f6sm55004405e9.31.2024.12.19.06.49.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Dec 2024 06:49:36 -0800 (PST) Message-ID: Date: Thu, 19 Dec 2024 15:49:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 00/14] s390x: virtio-mem support To: Christian Borntraeger , Thomas Huth , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Paolo Bonzini , Halil Pasic , Eric Farman , Richard Henderson , Nina Schoetterl-Glausch , Heiko Carstens , Ilya Leoshkevich , Janosch Frank , "Michael S. Tsirkin" , Cornelia Huck References: <20241008105455.2302628-1-david@redhat.com> <07ca4492-1590-4cc6-94a1-0eea417da59e@redhat.com> <7e1025b4-c246-432c-b70d-e7156afb6519@redhat.com> <8d06030b-37a2-4c41-9907-8e072dde47f7@redhat.com> <9089e146-d665-471b-a918-2571a212c99b@redhat.com> <15947eee-1e01-4b8a-b750-417250899ecd@redhat.com> <9d912aae-2ac0-483e-814c-3a064a53b5a2@linux.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <9d912aae-2ac0-483e-814c-3a064a53b5a2@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1.116, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 18.12.24 17:48, Christian Borntraeger wrote: > Am 16.12.24 um 22:18 schrieb David Hildenbrand: >> Thanks, queued to >> >> https://github.com/davidhildenbrand/qemu.git mem-next >> On 13.12.24 15:26, David Hildenbrand wrote: >>> On 13.12.24 13:35, Thomas Huth wrote: >>>> On 12/12/2024 22.52, David Hildenbrand wrote: >>>>> On 13.11.24 15:46, David Hildenbrand wrote: >>>>>> On 08.10.24 12:54, David Hildenbrand wrote: >>>>>>> Based on current master. >>>>>>> >>>>>>> There is really not much left to do on s390x, because virtio-mem already >>>>>>> implements most things we need today (e.g., early-migration, >>>>>>> unplugged-inaccessible). The biggest part of this series is just doing what >>>>>>> we do with virtio-pci, wiring it up in the machine hotplug handler and ... >>>>>>> well, messing with the physical memory layout where we can now exceed >>>>>>> initial RAM size and have sparsity (memory holes). >>>>>>> >>>>>>> I tested a lot of things, including: >>>>>>>      * Memory hotplug/unplug >>>>>>>      * Device hotplug/unplug >>>>>>>      * System resets / reboots >>>>>>>      * Migrate to/from file (including storage attributes under KVM) >>>>>>>      * Basic live migration >>>>>>>      * Basic postcopy live migration >>>>>>> >>>>>>> More details on how to use it on s390x -- which is pretty much how >>>>>>> we use it on other architectures, except >>>>>>> s/virtio-mem-pci/virtio-mem-ccw/ --- is in the last patch. >>>>>>> >>>>>>> This series introduces a new diag(500) "STORAGE LIMIT" subcode that will >>>>>>> be documented in the kernel and at [2] once this+kernel part go upstream. >>>>>>> >>>>>>> There are not many s390x-specific virtio-mem future work items, except: >>>>>>> * Storage attribute migration might be improved >>>>>>> * We might want to reset storage attributes of unplugged memory >>>>>>>       (might or might not be required for upcoming page table reclaim in >>>>>>>        Linux; TBD) >>>>>>> >>>>>>> The Linux driver is available at [3]. >>>>>>> >>>>>>> [1] https://lkml.kernel.org/r/20240906101658.514470-1-pbonzini@redhat.com >>>>>>> [2] https://gitlab.com/davidhildenbrand/s390x-os-virt-spec >>>>>>> [3] https://lkml.kernel.org/r/20240910191541.2179655-6-david@redhat.com >>>>>> >>>>>> Gentle ping (and thanks to Thomas for the review!). >>>>>> >>>>>> I assume the kernel portion will go upstream in the next merge window. >>>>>> I'd like get the QEMU parts merged soon after that. >>>>>> >>>>>> 9.2 is going to get released in roughly one month, so there is still time. >>>>> >>>>> In the meantime, 9.2 was released. I don't have any changes planned. Series >>>>> still applies to current master, I'll do a quick test tomorrow. >>>>> >>>>>> >>>>>> @Thomas, this is mostly s390x stuff, so I guess it should go through the >>>>>> s390x tree? But I could also take this through my "memory devices" tree. >>>>> >>>>> @Thomas, any thoughts? >>>> >>>> I'm fine either way - feel free to put it into your tree, otherwise I'll >>>> pick it up likely sometime next week. >>> >>> Okay, let me let this sit here for a couple days longer and retest it >>> next week. I can queue it then, as another required patch ("virtio-mem: >>> unplug memory only during system resets, not device resets") still sits >>> in my tree all-lonely. :) >> >> Testing revealed no surprised. >> >> Queued to >> >> https://github.com/davidhildenbrand/qemu.git mem-next > > Thank you for doing it. Awesome work. Thanks! ... took a while to figure out how to make all weird configs happy. Sent a v3 ... -- Cheers, David / dhildenb