From: Sinan Kaya <okaya@kernel.org>
To: Lukas Wunner <lukas@wunner.de>,
Bjorn Helgaas <helgaas@kernel.org>,
linux-pci@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 3/9] PCI: pciehp: Drop hotplug_slot_ops wrappers
Date: Sun, 19 Aug 2018 18:01:04 -0400 [thread overview]
Message-ID: <df979e53-e0ca-56dd-ca1b-b3818a60e9cd@kernel.org> (raw)
In-Reply-To: <f430b343ae47e0587401a2b0c6d24f3c6f90cdfd.1534686485.git.lukas@wunner.de>
On 8/19/2018 10:29 AM, Lukas Wunner wrote:
> pciehp's ->enable_slot, ->disable_slot, ->get_attention_status and
> ->reset_slot callbacks are currently implemented by wrapper functions
> that do nothing else but call down to a backend function. The backends
> are not called from anywhere else, so drop the wrappers and use the
> backends directly as callbacks, thereby shaving off a few lines of
> unnecessary code.
>
> No functional change intended.
>
> Signed-off-by: Lukas Wunner<lukas@wunner.de>
Great work. I was surprised by the number of steps we need to
jump in order to reach to real code here. Simplification is welcome.
next prev parent reply other threads:[~2018-08-19 22:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-19 14:29 [PATCH 0/9] PCI hotplug diet Lukas Wunner
2018-08-19 14:29 ` Lukas Wunner
2018-08-19 14:29 ` [PATCH 3/9] PCI: pciehp: Drop hotplug_slot_ops wrappers Lukas Wunner
2018-08-19 22:01 ` Sinan Kaya [this message]
2018-08-19 14:29 ` [PATCH 6/9] PCI: hotplug: Constify hotplug_slot_ops Lukas Wunner
2018-08-19 14:29 ` Lukas Wunner
2018-08-20 8:10 ` Rafael J. Wysocki
2018-08-20 8:10 ` Rafael J. Wysocki
2018-08-21 0:38 ` Tyrel Datwyler
2018-08-21 0:38 ` Tyrel Datwyler
2018-08-19 14:29 ` [PATCH 1/9] PCI: Simplify disconnected marking Lukas Wunner
2018-08-19 21:56 ` Sinan Kaya
2018-08-19 14:29 ` [PATCH 2/9] PCI: pciehp: Drop unnecessary includes Lukas Wunner
2018-08-19 14:29 ` [PATCH 4/9] PCI: pciehp: Unify controller and slot structs Lukas Wunner
2018-08-19 21:59 ` Sinan Kaya
2018-08-20 9:09 ` Lukas Wunner
2018-08-20 17:34 ` Sinan Kaya
2018-09-05 22:30 ` Bjorn Helgaas
2018-09-06 7:38 ` Lukas Wunner
2018-09-06 18:54 ` Bjorn Helgaas
2018-09-17 22:37 ` Bjorn Helgaas
2018-09-18 19:46 ` Lukas Wunner
2018-08-19 14:29 ` [PATCH 5/9] PCI: pciehp: Reshuffle controller struct for clarity Lukas Wunner
2018-08-19 14:29 ` [PATCH 8/9] PCI: hotplug: Embed hotplug_slot Lukas Wunner
2018-08-19 14:29 ` Lukas Wunner
2018-08-20 8:17 ` Rafael J. Wysocki
2018-08-20 8:17 ` Rafael J. Wysocki
2018-08-21 0:43 ` Tyrel Datwyler
2018-08-21 0:43 ` Tyrel Datwyler
2018-09-03 17:54 ` Sebastian Ott
2018-09-03 17:54 ` Sebastian Ott
2018-08-19 14:29 ` [PATCH 9/9] PCI: hotplug: Document TODOs Lukas Wunner
2018-08-19 14:29 ` [PATCH 7/9] PCI: hotplug: Drop hotplug_slot_info Lukas Wunner
2018-08-19 14:29 ` Lukas Wunner
2018-08-20 8:14 ` Rafael J. Wysocki
2018-08-20 8:14 ` Rafael J. Wysocki
2018-08-21 0:41 ` Tyrel Datwyler
2018-08-21 0:41 ` Tyrel Datwyler
2018-09-03 17:52 ` Sebastian Ott
2018-09-03 17:52 ` Sebastian Ott
2018-08-30 8:50 ` [PATCH 0/9] PCI hotplug diet Andy Shevchenko
2018-08-30 8:50 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df979e53-e0ca-56dd-ca1b-b3818a60e9cd@kernel.org \
--to=okaya@kernel.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.