From: Sean Anderson <sean.anderson@linux.dev>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net] net: cadence: macb: Synchronize stats calculations
Date: Thu, 20 Feb 2025 15:02:23 -0500 [thread overview]
Message-ID: <df9e0dea-bfcf-4199-ac26-55f04f72ae2c@linux.dev> (raw)
In-Reply-To: <32f5cc19-e4e6-4750-9942-e57126b0bad7@lunn.ch>
On 2/20/25 14:48, Andrew Lunn wrote:
>> Yeah, looks like I missed this. Although I tested on a kernel with
>> lockdep enabled, and I thought that was supposed to catch this sort of
>> thing. Will send a v2.
>
> It might be you need the sleep in atomic option, not lockdep. Better
> still, just enable them all :-)
>
> Andrew
I think the issue was that the lock is only taken in an error path and I
didn't trigger it during my testing. So lockdep never saw that this lock
could be taken in an interrupt.
--Sean
prev parent reply other threads:[~2025-02-20 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 19:50 [PATCH net] net: cadence: macb: Synchronize stats calculations Sean Anderson
2025-02-19 8:48 ` Maxime Chevallier
2025-02-20 16:02 ` Sean Anderson
2025-02-20 19:48 ` Andrew Lunn
2025-02-20 20:02 ` Sean Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9e0dea-bfcf-4199-ac26-55f04f72ae2c@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.