Re: Bug Report: IPtables 1.2.* segfaulted by iptables 1.3.* [PATCH]

[Robert de Bath <list-netfilter@debath.co.uk>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 872 bytes --]

On Fri, 29 Jul 2005, Harald Welte wrote:

> On Thu, Jul 28, 2005 at 11:53:49AM +0100, Robert de Bath wrote:
>> Hi all,
>> I've been mixing iptables 1.2.8/1.2.11 and 1.3.1/2 tools and unlike I would

> other issues with this as well (one has been added to INCOMPATIBILITIES
> recently).
Yup, spotted that but nfcache is per entry so it doesn't break _this_.

> If the fix is non-intrusive and doesn't reaquire a lot of additional
> computational complexity, I would accept such a patch.  Otherwise I
> don't really think it's worth supporting such a setup.  Usually you have
> one version of iptables installed, not multiple.

<grin> The change was a _lot_ easier than I thought, looks like it's a
real bug too. [attached]

-- 
Rob.                          (Robert de Bath <robert$ @ debath.co.uk>)
                                              <http://www.debath.co.uk/>

[-- Attachment #2: Type: TEXT/PLAIN, Size: 422 bytes --]

--- libiptc/libiptc.c.orig	2005-07-19 23:03:49.000000000 +0100
+++ libiptc/libiptc.c	2005-07-30 07:59:06.312238644 +0100
@@ -399,7 +399,7 @@
 	/* sort only user defined chains */
 	if (!c->hooknum) {
 		list_for_each_entry(tmp, &h->chains, list) {
-			if (strcmp(c->name, tmp->name) <= 0) {
+			if (!tmp->hooknum && strcmp(c->name, tmp->name) <= 0) {
 				list_add(&c->list, tmp->list.prev);
 				return;
 			}