From: Yonghong Song <yonghong.song@linux.dev>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>, bpf@vger.kernel.org
Cc: Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Eduard Zingerman <eddyz87@gmail.com>,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support
Date: Fri, 16 Oct 2026 09:22:27 -0700 [thread overview]
Message-ID: <dfa562d4-23fb-46ff-bbf9-5a56d2e51860@linux.dev> (raw)
In-Reply-To: <DM6DYYV4XVKO.G5S77C0FGIYG@gmail.com>
On 10/16/26 9:00 AM, Alexei Starovoitov wrote:
> On Fri, Oct 16, 2026 at 08:50 AM Yonghong Song <yonghong.song@linux.dev> wrote:
>>> This is not enabled on s390, right?
>> Okay, I will enable s390.
> No need.
> I meant that all users of LO/HI are x86 and arm64 only,
> so it's dead code. Just drop it.
> s390 JIT has no bpf_jit_supports_stack_args(), so with clang that
> has stack args tracing_struct_int128_tgt.c won't load there.
> s390 can be a follow up if there is a real use case.
In patch 7, we have the following code:
+__noinline __u64 callee_odd(__u64 a, struct int128_arg v, __u64 b)
+{
+ return a + (__u64)v.v * 2 + (__u64)((unsigned __int128)v.v >> 64) * 3 +
+ b * 4;
+}
This one can exercise for s390x, x86_64 and arm64. Do you think it is worthwhile?
Two other bpf functions, which has stack arguments, need rejection with
... && !defined(__TARGET_ARCH_s390)
next prev parent reply other threads:[~2026-10-16 16:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 17:09 [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 01/11] bpf, x86: Pass a trampoline's stack arguments by the calling convention Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 02/11] selftests/bpf: Test trampoline stack args in a program that can tail call Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 03/11] selftests/bpf: Test by-value __int128 kfunc arguments at an odd slot Yonghong Song
2026-10-13 17:09 ` [PATCH bpf-next v3 04/11] bpf: Describe a BPF function to its trampoline as one u64 per slot Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 05/11] bpf, x86: Place trampoline arguments by the x86-64 calling convention Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 06/11] selftests/bpf: Test trampoline args around a 16-byte aligned stack arg Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 07/11] selftests/bpf: Test trampoline args of a BPF function at an odd slot Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 08/11] bpf: Refuse a trampoline on an unreliable static function with stack args Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 09/11] selftests/bpf: Test trampolines on more BPF functions " Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 10/11] bpf, x86: Give a kfunc's stack argument the 16-byte alignment it needs Yonghong Song
2026-10-16 2:46 ` Alexei Starovoitov
2026-10-16 15:45 ` Yonghong Song
2026-10-13 17:10 ` [PATCH bpf-next v3 11/11] selftests/bpf: Test that a kfunc gets its __int128 stack argument aligned Yonghong Song
2026-10-16 2:48 ` [PATCH bpf-next v3 00/11] bpf: Follow up by-value struct and __int128 argument support Alexei Starovoitov
2026-10-16 15:50 ` Yonghong Song
2026-10-16 16:00 ` Alexei Starovoitov
2026-10-16 16:22 ` Yonghong Song [this message]
2026-10-16 16:34 ` Alexei Starovoitov
2026-10-16 16:56 ` Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dfa562d4-23fb-46ff-bbf9-5a56d2e51860@linux.dev \
--to=yonghong.song@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.