From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 471D5C77B75 for ; Mon, 17 Apr 2023 23:16:33 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by mx.groups.io with SMTP id smtpd.web11.12645.1681773384169815133 for ; Mon, 17 Apr 2023 16:16:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ti.com header.s=ti-com-17q1 header.b=e8kvRhXZ; spf=pass (domain: ti.com, ip: 198.47.19.141, mailfrom: rs@ti.com) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33HNGKbb120509; Mon, 17 Apr 2023 18:16:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681773380; bh=tuK81nhJCcFc4lh2qf42VGRM5Z1eJkFi+kECHYin2oE=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=e8kvRhXZnmZW9dMlk6nGKnPLPpLrTkaRRr+l9IbhGzq9/WFwzxKUj02OrPcbIPrId Y68Xcn9qBlXIqX5839r6WHcsXPo8lNHkZ45bHAIS0v9pd3JNaq2yl7/z20Pq0g50PN HrNHV7VabCFhLrYw9vNp1qYic2AtuPzXJ31qRd0Q= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33HNGKkZ003690 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 Apr 2023 18:16:20 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Mon, 17 Apr 2023 18:16:19 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Mon, 17 Apr 2023 18:16:19 -0500 Received: from [10.247.19.36] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33HNGJhf042407; Mon, 17 Apr 2023 18:16:19 -0500 Message-ID: Date: Mon, 17 Apr 2023 18:16:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [DISCUSSION] Weston-Init and non-root weston Content-Language: en-US To: Andrew Davis , Denys Dmytriyenko , Ryan Eatmon CC: References: <1241ddde-7f9c-d8ff-2c15-d300f5c5a24a@ti.com> <02df0607-5aad-f70d-62d2-ffdce916201b@ti.com> <05fd037d-f77c-f2d7-7e92-ef11cb395e63@ti.com> <94b6af33-a7ed-e5d3-de44-81ca8a58fb2c@ti.com> From: Randolph Sapp In-Reply-To: <94b6af33-a7ed-e5d3-de44-81ca8a58fb2c@ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 17 Apr 2023 23:16:33 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/14321 On 4/17/23 18:08, Andrew Davis wrote: > On 4/17/23 6:01 PM, Randolph Sapp wrote: >> On 4/17/23 17:52, Andrew Davis wrote: >>> On 4/17/23 5:43 PM, Randolph Sapp wrote: >>>> On 4/17/23 17:39, Andrew Davis wrote: >>>>> On 4/17/23 5:32 PM, Randolph Sapp wrote: >>>>>> Finally getting around to weston-init issue I highlighted a while >>>>>> back and there's only one real issue preventing us from reusing >>>>>> the base weston-init recipe -- our touchscreen auto-configuration >>>>>> script. >>>>>> >>>>>> That script has to have root access to setup and reload udev rules >>>>>> and as we know setuid won't work for shell scripts. >>>>>> >>>>>> I propose we rewrite it in something that can use setuid (perl or >>>>>> c or something of the sort). I'm currently looking at perl as >>>>>> there's already quite a few core recipes that rdepend on it. >>>>>> >>>>>> Then we just need to inject it into the runWeston script and >>>>>> adjust the two init scripts to point at that. >>>>>> >>>>>> Any concerns or objections? >>>>> >>>>> Why not just drop out that old touchscreen script, it is a >>>>> non-standard way of doing >>>>> this task and should be removed. >>>>> >>>>> Andrew >>>> >>>> It's non-standard, but that's because there really isn't a good >>>> standard for calibrating touch screens under Weston. AFAIK this is >>>> still useful. >>> >>> https://wiki.st.com/stm32mpu/wiki/How_to_calibrate_the_touchscreen >>> >>> This seems like the standard ^^ >>> >>> Andrew >> >> That does save the config for the user running weston. Currently our >> script saves and loads the config for all users. This could >> technically be seen as a regression, but it doesn't seem that bad to me. > > Better question than does it provide "any benefit at all": Does the > benefit outweigh the hacky-ness and effort needed to maintain > and document it?.. > > Andrew I would say no, it doesn't outweigh the hacky-ness. Our script force-reloads Weston adding an unnecessary delay for every recalibration. Denys, any input here? Anyone you know of expecting this behavior downstream?