Re: [PATCH 1/3] acl: Make it compatible with externalsrc

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

Except for the questions asked and answered below, is there 
anything else preventing these three patches from being merged?

//Peter

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> Sent: den 2 oktober 2018 12:26
> To: Richard Purdie <richard.purdie@linuxfoundation.org>; openembedded-
> core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with
> externalsrc
> 
> *ping*
> 
> //Peter
> 
> > -----Original Message-----
> > From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> > core-bounces@lists.openembedded.org> On Behalf Of Peter Kjellerstedt
> > Sent: den 25 september 2018 11:17
> > To: Richard Purdie <richard.purdie@linuxfoundation.org>; openembedded-core@lists.openembedded.org
> > Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with externalsrc
> >
> > > -----Original Message-----
> > > From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> > > core-bounces@lists.openembedded.org> On Behalf Of Richard Purdie
> > > Sent: den 25 september 2018 10:13
> > > To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>; openembedded-
> > > core@lists.openembedded.org
> > > Subject: Re: [OE-core] [PATCH 1/3] acl: Make it compatible with
> > > externalsrc
> > >
> > > On Mon, 2018-09-24 at 21:03 +0200, Peter Kjellerstedt wrote:
> > > > Make the subdir fetch path for configure.ac relative. This avoids the
> > > > following error after having done `devtool modify acl`:
> > > >
> > > > ERROR: acl-2.2.52-r0 do_unpack: Unpack failure for URL:
> > > > 'file://configure.ac;subdir=.../builds/qemux86-64/workspace/sources/acl'.
> > > > subdir argument isn't a subdirectory of unpack root
> > > > .../builds/qemux86-64/tmp/work/core2-64-poky-linux/acl/2.2.52-r0
> > > >
> > > > Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> > > > ---
> > > >  meta/recipes-support/attr/acl_2.2.52.bb | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-support/attr/acl_2.2.52.bb b/meta/recipes-support/attr/acl_2.2.52.bb
> > > > index 8f3dc45cf7..8b89de9b42 100644
> > > > --- a/meta/recipes-support/attr/acl_2.2.52.bb
> > > > +++ b/meta/recipes-support/attr/acl_2.2.52.bb
> > > > @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://doc/COPYING;md5=c781d70ed2b4d48995b790403217a249 \
> > > >  DEPENDS = "attr"
> > > >
> > > >  SRC_URI = "${SAVANNAH_GNU_MIRROR}/acl/${BP}.src.tar.gz \
> > > > -           file://configure.ac;subdir=${S} \
> > > > +           file://configure.ac;subdir=${BP} \
> > > >             file://run-ptest \
> > > >             file://acl-fix-the-order-of-expected-output-of-getfacl.patch \
> > > >             file://test-fix-insufficient-quoting-of.patch \
> > >
> > > This isn't making sense to me. Doesn't externalsrc set ${S} to the
> > > external source location?
> >
> > Yes, it does, but it does not change ${WORKDIR}. So when it tries
> > to unpack to the absolute path ${S}, which is outside ${WORKDIR}
> > when externalsrc is in use, then the above error occurs. Using a
> > relative path avoids the problem.
> >
> > > Also, doesn't it remove the do_unpack task?
> >
> > No, it keeps the task but removes everything except file:// URLs
> > and URLs with type=kmeta from the SRC_URI. This is also why I had
> > to check for externalsrc in the do_unpack task of lsof.
> >
> > > Cheers,
> > >
> > > Richard
> >
> > //Peter