From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BF33C001B0 for ; Mon, 14 Aug 2023 14:09:21 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C96AF83B; Mon, 14 Aug 2023 16:08:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C96AF83B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692022159; bh=7S1IyHGHSebJast9hBeMM//N2B1gf7ilFZZS88LviEI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=Ctv4+fyTiCnGbyy0aHyEyzhUkj6qiQhcXw1v25gT/7Prdx1ot60PuF0XiZ78AKBVv LbBie2oeW3Z4fDZMglvPxOoqfa96yO5Wimtv33+VsHlRBW4dCskvXv84LoCbAkmhTi ynCr/TbcYOCYgF+rtVQzHghWQrLDcIKE74epATxg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EA63AF80564; Mon, 14 Aug 2023 16:07:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7D785F80551; Mon, 14 Aug 2023 16:07:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 14F81F80290; Mon, 14 Aug 2023 16:07:36 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 253B0F80074 for ; Mon, 14 Aug 2023 16:07:27 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 253B0F80074 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=H7FvVsN/ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692022049; x=1723558049; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=7S1IyHGHSebJast9hBeMM//N2B1gf7ilFZZS88LviEI=; b=H7FvVsN/kHcF9M6VY3G7e9qxSGo56jiF2RZAABcxk+S/yO7RseGG/6If mSMFh9Jp9BSu3bW611VUl/SDdcd48/7shBngU6/57osWXswSO32/Sal/U NmCWmVlzCgRuhhACYRhMlL9bcD5x3kXK/2qsjYhqSRI2BxIDFBG5xnTFY 0+YoD04QzLHx/VHmCwjh92zGCf5aICuMJ+kR0tHjHMoj9OCA0SrTNXpW1 11cMyH+3IoLdxzBMgWRBZLLRCXeYSubGsBxlf+lQzGJQyrX3a+Da2zsSH bEvbMEOdiXHzDqHlgbCnIl/38NHjXYJ6wxgTyUQubYqmc1xdulCCQ1++m w==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="370943675" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="370943675" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 07:07:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="798825220" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="798825220" Received: from ryana2x-mobl.amr.corp.intel.com (HELO [10.212.126.76]) ([10.212.126.76]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 07:07:23 -0700 Message-ID: Date: Mon, 14 Aug 2023 08:54:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH] ALSA: hda: intel-dsp-cfg: Add Chromebook quirk to ADL/RPL Content-Language: en-US To: Brady Norander , alsa-devel@alsa-project.org, broonie@kernel.org, Curtis Malainey Cc: cezary.rojewski@intel.com, amadeuszx.slawinski@linux.intel.com, perex@perex.cz, tiwai@suse.de References: <20230814012637.487602-1-bradynorander@gmail.com> From: Pierre-Louis Bossart In-Reply-To: <20230814012637.487602-1-bradynorander@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: MUMPCTGB2QSMVDE6VXVP3QYZ4UNTVDTL X-Message-ID-Hash: MUMPCTGB2QSMVDE6VXVP3QYZ4UNTVDTL X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/13/23 20:26, Brady Norander wrote: > AlderLake and RaptorLake Chromebooks currently use the HDA driver by > default. Add a quirk to use the SOF driver on these platforms, which is > needed for functional internal audio. that would be wise indeed, I must admit not recalling why this isn't the case. Curtis? > + { > + .flags = FLAG_SOF, > + .device = PCI_DEVICE_ID_INTEL_HDA_ADL_PX, Humm, that doesn't seem like a supported configuration, IIRC all the PX skews are for embedded Linux stuff. > + .dmi_table = (const struct dmi_system_id []) { > + { > + .ident = "Google Chromebooks", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Google"), > + } > + }, > + {} > + } > + }, > { > .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, > .device = PCI_DEVICE_ID_INTEL_HDA_RPL_M, > }, > + { > + .flags = FLAG_SOF, > + .device = PCI_DEVICE_ID_INTEL_HDA_RPL_PX, same here, I don't think we can blindly add quirks. One might argue it doesn't hurt but not all SKUs are supported by Chrome. > + .dmi_table = (const struct dmi_system_id []) { > + { > + .ident = "Google Chromebooks", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Google"), > + } > + }, > + {} > + } > + }, > { > .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE, > .device = PCI_DEVICE_ID_INTEL_HDA_RPL_PX,