All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mfgtools: bump to 0.02
Date: Mon, 25 Dec 2017 13:14:47 +0100	[thread overview]
Message-ID: <dfec903f-ffef-d840-62f4-39f0dabcdd8c@gmail.com> (raw)
In-Reply-To: <20171224161029.smqyft5nh2ec23mt@sapphire.tkos.co.il>

Hi Baruch,

Le 24/12/2017 ? 17:10, Baruch Siach a ?crit?:
> Hi Romain,
> 
> On Sun, Dec 24, 2017 at 11:20:29AM +0100, Romain Naour wrote:
>> Bump mfgtools to include the fix [1] for the C++ build issue reported
>> by the autobuilders.
>>
>> This bump include only 4 small commit fixing memory leak and this
>> build issue.
>>
>> Remove CPOL.htm (removed upstream) from MFGTOOLS_LICENSE_FILES.
>> Add license file hash.
>>
>> [1] https://github.com/codeauroraforum/mfgtools/commit/b370a43e548440025d274ff2abbb25342bbaa78c
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/7c2bbbe13ab315684f3502afd96958a76879b1d5
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
>> ---
>> This patch should be backported to stable branches 2017.02 and 2017.08.
>> ---
>>  package/mfgtools/mfgtools.hash | 3 ++-
>>  package/mfgtools/mfgtools.mk   | 4 ++--
>>  2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/mfgtools/mfgtools.hash b/package/mfgtools/mfgtools.hash
>> index e73a7fa13a..4d36ed809c 100644
>> --- a/package/mfgtools/mfgtools.hash
>> +++ b/package/mfgtools/mfgtools.hash
>> @@ -1,2 +1,3 @@
>>  # locally computed
>> -sha256  6ce93a33c269282df305cf7e517d2d14fde78203537d8ea75b064966afe48464  mfgtools-b219fc219a35c365010897ed093c40750f8cdac6.tar.gz
>> +sha256  055d71227d18883d6e8bc9e854c076015f9a7749820a94272e19071bf0b25c89  mfgtools-v0.02.tar.gz
>> +sha256  2655559a6bb1179eae514f5c7166f4ede4f2453efa9cf4dc3c045cab5d57dede  LICENSE
>> diff --git a/package/mfgtools/mfgtools.mk b/package/mfgtools/mfgtools.mk
>> index 00a011af85..865364eece 100644
>> --- a/package/mfgtools/mfgtools.mk
>> +++ b/package/mfgtools/mfgtools.mk
>> @@ -4,11 +4,11 @@
>>  #
>>  ################################################################################
>>  
>> -MFGTOOLS_VERSION = b219fc219a35c365010897ed093c40750f8cdac6
>> +MFGTOOLS_VERSION = v0.02
>>  MFGTOOLS_SITE = $(call github,NXPmicro,mfgtools,$(MFGTOOLS_VERSION))
> 
> This redirects to https://github.com/codeauroraforum/mfgtools. Should _SITE be 
> update?

Indeed, thanks for noticing this.

> 
>>  MFGTOOLS_SUBDIR = MfgToolLib
>>  MFGTOOLS_LICENSE = BSD-3-Clause or CPOL
> 
> Should the license be updates as well with the removal of COPL?

The CPOL file was removed but the CPOL license is still valid.
See the Readme file from this version:

Licenses:
- CPOL: MfgToolLib/XmlLite.CPP and XmlLite.h
- BSD: Others.

I hesitated to add these files in MFGTOOLS_LICENSE_FILES since their content
(hash) are likely to be modified between each version.

Thoughts?

Best regards,
Romain

> 
>> -MFGTOOLS_LICENSE_FILES = LICENSE CPOL.htm
>> +MFGTOOLS_LICENSE_FILES = LICENSE
>>  HOST_MFGTOOLS_DEPENDENCIES = host-libusb
>>  
>>  HOST_MFGTOOLS_CFLAGS = \
> 
> baruch
> 

  reply	other threads:[~2017-12-25 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-24 10:20 [Buildroot] [PATCH] package/mfgtools: bump to 0.02 Romain Naour
2017-12-24 16:10 ` Baruch Siach
2017-12-25 12:14   ` Romain Naour [this message]
2017-12-25 12:29     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dfec903f-ffef-d840-62f4-39f0dabcdd8c@gmail.com \
    --to=romain.naour@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.