Re: [PATCH v3] monitor: Refine 'info tlb' command

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

On 3/9/26 22:44, Dr. David Alan Gilbert wrote:
> Hi Markus,
> 
> * Dr. David Alan Gilbert (dave@treblig.org) wrote:
>> * Marc-André Lureau (marcandre.lureau@gmail.com) wrote:
>>> Hi
>>>
>>> On Tue, Aug 18, 2026 at 5:30 PM <AlanoSong@163.com> wrote:
>>>>
>>>> When booting an i386 target, the 'info tlb' command
>>>> may walk the entire page table hierarchy and emit
>>>> an enormous amount of output. It will take dozens of
>>>> minutes to print all the info, and
>>>> The same situation also occurred on sparc32 and
>>>> m68k targets.
>>>>
>>>> So this change do the following:
>>>> 1) Add a address range argument to help user control
>>>>     the number of output items.
>>>> 2) Add warning note in help message that such address
>>>>     range argument only supported on target i386,
>>>>     sparc32 and m68k.
>>>> 3) Print ignore warning when user add such address
>>>>     range argument on other targets (sh4, sparc64,
>>>>     ppc and xtensa). Those targets only print limited
>>>>     tlb info.
>>>>
>>>> Signed-off-by: Alano Song <AlanoSong@163.com>
>>>
>>> lgtm overall
>>>
>>> - m68k print_address_zone() used to be called with page-aligned zones,
>>> but now it is clipped to arbitrary user ranges, which may not be
>>> aligned. 1 byte range will be reported as 0kb. We may want to handle
>>> the case for small ranges. Btw that code could use the macros KiB for
>>> readability
>>>
>>> - A later patch could prune non-overlapping ranges during traversal,
>>> not just during printing
>>
>> Yeh I'd say it's OK, two thoughts:
>>    a) I'd have split the patch into a series with more managable chunks
>>    b) There's quite a bit of repetition which feels like a common helper
>>     might have removed.
>>
>> But:
>>
>> Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
> 
> Can you pick this one up please?

Doesn't this series need a rebase on top of commit
93b9a2436564a9df25a0b978c8245fed255264f2 (Make HMP optional)?

> 
> Dave
> 
>> Dave
>>
>>>> ---
>>>>   hmp-commands-info.hx      | 17 ++++++--
>>>>   target/i386/monitor.c     | 92 ++++++++++++++++++++++++++++-----------
>>>>   target/m68k/cpu.h         |  2 +-
>>>>   target/m68k/helper.c      | 55 +++++++++++++++--------
>>>>   target/m68k/monitor.c     | 15 ++++++-
>>>>   target/ppc/monitor.c      |  6 +++
>>>>   target/sh4/monitor.c      |  5 +++
>>>>   target/sparc/cpu.h        |  3 ++
>>>>   target/sparc/mmu_helper.c | 40 +++++++++++++----
>>>>   target/sparc/monitor.c    | 23 ++++++++++
>>>>   target/xtensa/monitor.c   |  6 +++
>>>>   11 files changed, 206 insertions(+), 58 deletions(-)