From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A766C2D0A3 for ; Mon, 9 Nov 2020 12:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0828C2074F for ; Mon, 9 Nov 2020 12:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cABhk27F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729697AbgKIMgP (ORCPT ); Mon, 9 Nov 2020 07:36:15 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51170 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729693AbgKIMgN (ORCPT ); Mon, 9 Nov 2020 07:36:13 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A9Ca6jS002188; Mon, 9 Nov 2020 06:36:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604925366; bh=95DTtXkfRsBVcuCi7o8HWOM6vEleEq3iPsJLfzylSFw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=cABhk27F9dcCrPbnbsUSmtQl5A3/oVFXPewl4+t8S5gnSmitofhnmOy/K6HkUt8Qc vOUeYUqSvL22k+HVYDS3WRKq4+fO7Zr8h+WNhp/bkMsCmUOOR5/PgIB9I0qeYGLVNT FdHsapsUQNBx/ETdJeDCzo7klRTHzyGHOhrB7pSI= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A9Ca6Gn069552 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Nov 2020 06:36:06 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 9 Nov 2020 06:36:06 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 9 Nov 2020 06:36:06 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A9Ca3s9035270; Mon, 9 Nov 2020 06:36:03 -0600 Subject: Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback To: Vinod Koul CC: , , , , , , , , , , References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-2-peter.ujfalusi@ti.com> <20201007054404.GR2968@vkoul-mobl> <20201007155533.GZ2968@vkoul-mobl> <45adb88b-1ef8-1fbf-08c1-9afc6ea4c6f0@ti.com> <20201028055531.GH3550@vkoul-mobl> <20201109114534.GH3171@vkoul-mobl> <7a7cb455-dd09-b71f-6ecc-fd6108d37051@ti.com> <20201109122306.GO3171@vkoul-mobl> From: Peter Ujfalusi Message-ID: Date: Mon, 9 Nov 2020 14:36:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <20201109122306.GO3171@vkoul-mobl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 09/11/2020 14.23, Vinod Koul wrote: > HI Peter, > > On 09-11-20, 14:09, Peter Ujfalusi wrote: >> Hi Vinod, >> >> On 09/11/2020 13.45, Vinod Koul wrote: >>>> Without a channel number I can not do anything. >>>> It is close to a chicken and egg problem. >>> >>> We get 'channel' in xlate, so wont that help? I think I am still missing >>> something here :( >> >> Yes, we get channel in xlate, but we get the channel after >> ofdma->of_dma_route_allocate() > > That is correct, so you need this info in allocate somehow.. To know the event number the router must send to trigger the channel I need the router to 'craft' the dmaspec which can be used to request the channel. To request a bcdma channel to be triggered by global trigger 0: [A] <&main_bcdma 1 0 15> main_bcdma - phandle to BCDMA 1 - triggered by global trigger0 0 - ignored 15 - ASEL value A peripheral can not really use this binding directly as we need to configure the get the event to be sent to the given channel's trigger0. The binding for the router (l2g if INTA in this case): [B] <&inta_l2g 21 0 15> inta_l2g - phandle to therouter 21 - local event index (input event/signal) 0 - event detection mode (pulsed/rising) 15 - ASEL value The of_dma_router_xlate() receives the dmaspec for [B}, the router driver creates the dmaspec for [A]. The xlate can not request the channel first as it needs the dmaspec from the router to do so. - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B3DAC388F7 for ; Mon, 9 Nov 2020 12:36:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1C4920659 for ; Mon, 9 Nov 2020 12:36:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LpZWFVXT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="cABhk27F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1C4920659 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yRp1a1qLCGXBCCSqgghc26J1MOLBwhVXKqJE5DmwAJw=; b=LpZWFVXTBQAfZzA8EJSIwchlB O4YmniPwYJ6EQcitu1Jli/gT8VSKz9Tr+URaacmYChNgpyMZd7A8fZjTOpx8kjNuZoqAgIIvVB7UI 0wXBUYHHENn6XquQ+4Zxll8YG79Dq4nK2dJ8OS7HsUoae5vmWpD3NlSPeH1q9OrnFaYlMFZ1TQir/ E5JqQkLN166PrZNdQkAek09JXwigCZbDTP5nN6VAuv7p0GCG5u61NlSSKjU5GG9EC5BoV8W0rMX1J MSWYmyQIIDD2nOyU2onS/WfAG3Cjhouh0fWu20yUAqfFX0hwhW4wZwWsFYtM9TvT6eGHjRIDQDeij ruTlj61vg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc6P8-0004Ax-QI; Mon, 09 Nov 2020 12:36:14 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc6P5-00049n-Hq for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 12:36:12 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0A9Ca6jS002188; Mon, 9 Nov 2020 06:36:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1604925366; bh=95DTtXkfRsBVcuCi7o8HWOM6vEleEq3iPsJLfzylSFw=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=cABhk27F9dcCrPbnbsUSmtQl5A3/oVFXPewl4+t8S5gnSmitofhnmOy/K6HkUt8Qc vOUeYUqSvL22k+HVYDS3WRKq4+fO7Zr8h+WNhp/bkMsCmUOOR5/PgIB9I0qeYGLVNT FdHsapsUQNBx/ETdJeDCzo7klRTHzyGHOhrB7pSI= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0A9Ca6Gn069552 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 9 Nov 2020 06:36:06 -0600 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 9 Nov 2020 06:36:06 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 9 Nov 2020 06:36:06 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0A9Ca3s9035270; Mon, 9 Nov 2020 06:36:03 -0600 Subject: Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback To: Vinod Koul References: <20200930091412.8020-1-peter.ujfalusi@ti.com> <20200930091412.8020-2-peter.ujfalusi@ti.com> <20201007054404.GR2968@vkoul-mobl> <20201007155533.GZ2968@vkoul-mobl> <45adb88b-1ef8-1fbf-08c1-9afc6ea4c6f0@ti.com> <20201028055531.GH3550@vkoul-mobl> <20201109114534.GH3171@vkoul-mobl> <7a7cb455-dd09-b71f-6ecc-fd6108d37051@ti.com> <20201109122306.GO3171@vkoul-mobl> From: Peter Ujfalusi Message-ID: Date: Mon, 9 Nov 2020 14:36:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: <20201109122306.GO3171@vkoul-mobl> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_073611_749600_53E7BB19 X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, devicetree@vger.kernel.org, vigneshr@ti.com, lokeshvutla@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, ssantosh@kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAwOS8xMS8yMDIwIDE0LjIzLCBWaW5vZCBLb3VsIHdyb3RlOgo+IEhJIFBldGVyLAo+IAo+ IE9uIDA5LTExLTIwLCAxNDowOSwgUGV0ZXIgVWpmYWx1c2kgd3JvdGU6Cj4+IEhpIFZpbm9kLAo+ Pgo+PiBPbiAwOS8xMS8yMDIwIDEzLjQ1LCBWaW5vZCBLb3VsIHdyb3RlOgo+Pj4+IFdpdGhvdXQg YSBjaGFubmVsIG51bWJlciBJIGNhbiBub3QgZG8gYW55dGhpbmcuCj4+Pj4gSXQgaXMgY2xvc2Ug dG8gYSBjaGlja2VuIGFuZCBlZ2cgcHJvYmxlbS4KPj4+Cj4+PiBXZSBnZXQgJ2NoYW5uZWwnIGlu IHhsYXRlLCBzbyB3b250IHRoYXQgaGVscD8gSSB0aGluayBJIGFtIHN0aWxsIG1pc3NpbmcKPj4+ IHNvbWV0aGluZyBoZXJlIDooCj4+Cj4+IFllcywgd2UgZ2V0IGNoYW5uZWwgaW4geGxhdGUsIGJ1 dCB3ZSBnZXQgdGhlIGNoYW5uZWwgYWZ0ZXIKPj4gb2ZkbWEtPm9mX2RtYV9yb3V0ZV9hbGxvY2F0 ZSgpCj4gCj4gVGhhdCBpcyBjb3JyZWN0LCBzbyB5b3UgbmVlZCB0aGlzIGluZm8gaW4gYWxsb2Nh dGUgc29tZWhvdy4uCgpUbyBrbm93IHRoZSBldmVudCBudW1iZXIgdGhlIHJvdXRlciBtdXN0IHNl bmQgdG8gdHJpZ2dlciB0aGUgY2hhbm5lbCBJCm5lZWQgdGhlIHJvdXRlciB0byAnY3JhZnQnIHRo ZSBkbWFzcGVjIHdoaWNoIGNhbiBiZSB1c2VkIHRvIHJlcXVlc3QgdGhlCmNoYW5uZWwuCgpUbyBy ZXF1ZXN0IGEgYmNkbWEgY2hhbm5lbCB0byBiZSB0cmlnZ2VyZWQgYnkgZ2xvYmFsIHRyaWdnZXIg MDoKCltBXQo8Jm1haW5fYmNkbWEgMSAwIDE1PgoKbWFpbl9iY2RtYSAtIHBoYW5kbGUgdG8gQkNE TUEKMSAtIHRyaWdnZXJlZCBieSBnbG9iYWwgdHJpZ2dlcjAKMCAtIGlnbm9yZWQKMTUgLSBBU0VM IHZhbHVlCgpBIHBlcmlwaGVyYWwgY2FuIG5vdCByZWFsbHkgdXNlIHRoaXMgYmluZGluZyBkaXJl Y3RseSBhcyB3ZSBuZWVkIHRvCmNvbmZpZ3VyZSB0aGUgZ2V0IHRoZSBldmVudCB0byBiZSBzZW50 IHRvIHRoZSBnaXZlbiBjaGFubmVsJ3MgdHJpZ2dlcjAuClRoZSBiaW5kaW5nIGZvciB0aGUgcm91 dGVyIChsMmcgaWYgSU5UQSBpbiB0aGlzIGNhc2UpOgoKW0JdCjwmaW50YV9sMmcgMjEgMCAxNT4K CmludGFfbDJnIC0gcGhhbmRsZSB0byB0aGVyb3V0ZXIKMjEgLSBsb2NhbCBldmVudCBpbmRleCAo aW5wdXQgZXZlbnQvc2lnbmFsKQowIC0gZXZlbnQgZGV0ZWN0aW9uIG1vZGUgKHB1bHNlZC9yaXNp bmcpCjE1IC0gQVNFTCB2YWx1ZQoKVGhlIG9mX2RtYV9yb3V0ZXJfeGxhdGUoKSByZWNlaXZlcyB0 aGUgZG1hc3BlYyBmb3IgW0J9LCB0aGUgcm91dGVyCmRyaXZlciBjcmVhdGVzIHRoZSBkbWFzcGVj IGZvciBbQV0uCgpUaGUgeGxhdGUgY2FuIG5vdCByZXF1ZXN0IHRoZSBjaGFubmVsIGZpcnN0IGFz IGl0IG5lZWRzIHRoZSBkbWFzcGVjIGZyb20KdGhlIHJvdXRlciB0byBkbyBzby4KCi0gUMOpdGVy CgpUZXhhcyBJbnN0cnVtZW50cyBGaW5sYW5kIE95LCBQb3Jra2FsYW5rYXR1IDIyLCAwMDE4MCBI ZWxzaW5raS4KWS10dW5udXMvQnVzaW5lc3MgSUQ6IDA2MTU1MjEtNC4gS290aXBhaWtrYS9Eb21p Y2lsZTogSGVsc2lua2kKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK