From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Duffy Subject: Re: [PATCH] network-bridge script support for multiple external interfaces Date: Fri, 14 Oct 2005 19:51:34 -0500 Message-ID: References: <434FE495.8020209@blueyonder.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <434FE495.8020209@blueyonder.co.uk> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org David Hopwood wrote: > Charles Duffy wrote: >> # antispoof Whether to use iptables to prevent spoofing (default yes). > [...] >> antispoof=${antispoof:-no} > > The antispoof default is not consistent with the comment. > Quite so. (That's original behavior, though, and so any fix for it should be checked in as a separate changeset -- from my revision-control-nazi days I still have a strong preference for keeping different fixes in different changesets so that they can be merged, accepted or rejected, and otherwise handled individually).