From: Milton Miller <miltonm@bga.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Denis Turischev <denis@compulab.co.il>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86.
Date: Thu, 12 Jan 2012 03:22:05 -0600 [thread overview]
Message-ID: <document-depends-on-reason@mdm.bga.com> (raw)
In-Reply-To: <1326309371-10757-1-git-send-email-grant.likely@secretlab.ca>
On Wed Jan 11 2012 - 14:16:36 EST, Grant Likely wrote:
> This driver does an unconditional read of io space during module init which
> causes a bad dereference on ARM. It looks to me like this is an x86 only
> drivers, so restrict it to only compile on x86.
> config GPIO_IT8761E
> tristate "IT8761E GPIO support"
> + depends on X86
> help
> Say yes here to support GPIO functionality of IT8761E super I/O chip.
Please add a comment to the Kconfig stanza with the reason for the
dependancy so people don't have to be git blame masters to know why
its there.
Something like
depends on X86 # unconditional read of io space during module init
thanks,
milton
next prev parent reply other threads:[~2012-01-12 9:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 19:16 [PATCH] gpio/it8761e: Restrict it8761e gpio driver to x86 Grant Likely
2012-01-12 9:22 ` Milton Miller [this message]
2012-01-12 14:56 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=document-depends-on-reason@mdm.bga.com \
--to=miltonm@bga.com \
--cc=denis@compulab.co.il \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.