From: Horms <horms@verge.net.au>
To: xen-devel@lists.xensource.com
Subject: [PATCH] Make delaration and definition of xc_linux_save() the same
Date: Thu, 12 Jan 2006 07:00:12 +0000 (UTC) [thread overview]
Message-ID: <dq4ups$c8q$1@sea.gmane.org> (raw)
8604:a51fcb5de470 introduced a discrepancy between the declaration
and definition of xc_linux_save(). In particular the argument for
the suspend pointer to function was null in one and int in the other.
On inspection, int seemed to be correct, so I went with this.
I also fixed up a few other cosmetic discrepancies.
Signed-Off-By: Horms <horms@verge.net.au>
diff -r 1b89e2aed730 -r aa6c2e55dea5 tools/libxc/xc_ia64_stubs.c
--- a/tools/libxc/xc_ia64_stubs.c Thu Jan 12 04:05:05 2006
+++ b/tools/libxc/xc_ia64_stubs.c Thu Jan 12 06:54:59 2006
@@ -23,7 +23,8 @@
}
int xc_linux_save(int xc_handle, int io_fd, uint32_t dom, uint32_t max_iters,
- uint32_t max_factor, uint32_t flags, int (*suspend)(void))
+ uint32_t max_factor, uint32_t flags /* XCFLAGS_xxx */,
+ int (*suspend)(int domid))
{
PERROR("xc_linux_save not implemented\n");
return -1;
diff -r 1b89e2aed730 -r aa6c2e55dea5 tools/libxc/xenguest.h
--- a/tools/libxc/xenguest.h Thu Jan 12 04:05:05 2006
+++ b/tools/libxc/xenguest.h Thu Jan 12 06:54:59 2006
@@ -21,9 +21,9 @@
* @parm dom the id of the domain
* @return 0 on success, -1 on failure
*/
-int xc_linux_save(int xc_handle, int fd, uint32_t dom, uint32_t max_iters,
+int xc_linux_save(int xc_handle, int fd_fd, uint32_t dom, uint32_t max_iters,
uint32_t max_factor, uint32_t flags /* XCFLAGS_xxx */,
- int (*suspend)(int));
+ int (*suspend)(int domid));
/**
next reply other threads:[~2006-01-12 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 7:00 Horms [this message]
2006-01-12 12:14 ` [PATCH] Make delaration and definition of xc_linux_save() the same Ewan Mellor
2006-01-13 2:23 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='dq4ups$c8q$1@sea.gmane.org' \
--to=horms@verge.net.au \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.