All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Williams <steve@icarus.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Re: [Patch] JSE SDRAM size probing
Date: Sat, 21 Jan 2006 08:32:55 -0800	[thread overview]
Message-ID: <dqtnno$3c4$1@sea.gmane.org> (raw)
In-Reply-To: <20060121101212.56F7E352B1E@atlas.denx.de>

Wolfgang Denk wrote:
> In message <dqs4i8$srl$1@sea.gmane.org> you wrote:
>> Uh, because I can't find it? This board doesn't have an SPD bus, if
>> that is what you mean.
> 
> That's not what I  mean.  I  was  thinking  of  common/memsize.c  and
> post/memory.c,  for  example.  Eventually  about  CFG_ALT_MEMTEST  in
> common/cmd_mem.c, too.

Oh. Well, besides the point that only 8 lines of my function are the
memory size probe (3 writes into memory and 1 read per bank) the
get_ram_size function doesn't address mapping of two banks once the
sizes are detected. That is where most of my effort went.

Also, Stefan Roese points out the cpu/ppc4xx/sdram.c file, but
that only handles 1 bank (and so obviously doesn't do mapping,
which is largely what I worried about) and uses hard coded timings
different from those appropriate for my board.

So I'll stick with my code for now, although  I'll keep a watch on
the changes that Stefan suggests are coming.

Thanks,
-- 
Steve Williams                "The woods are lovely, dark and deep.
steve at icarus.com           But I have promises to keep,
http://www.icarus.com         and lines to code before I sleep,
http://www.picturel.com       And lines to code before I sleep."

  parent reply	other threads:[~2006-01-21 16:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-20 23:05 [U-Boot-Users] [Patch] JSE SDRAM size probing Stephen Williams
2006-01-20 23:09 ` Wolfgang Denk
2006-01-21  0:04 ` [U-Boot-Users] " Stephen Williams
2006-01-21  1:39   ` Wolfgang Denk
2006-01-21  1:59     ` Stephen Williams
2006-01-21 10:12       ` Wolfgang Denk
2006-01-21 13:16         ` [U-Boot-Users] New Boards uboot at sundmangroup.com
2006-01-21 13:38           ` Wolfgang Denk
2006-01-21 16:32         ` Stephen Williams [this message]
2006-01-21 17:59           ` [U-Boot-Users] Re: [Patch] JSE SDRAM size probing Wolfgang Denk
2006-01-21 18:49             ` Stephen Williams
2006-01-21 20:55               ` Wolfgang Denk
2006-01-21 12:24       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='dqtnno$3c4$1@sea.gmane.org' \
    --to=steve@icarus.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.