From: Rob Duncan <rduncan@tesla.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: More snd_pcm_ioplug_avail_update() questions
Date: Thu, 26 Jul 2018 08:02:33 -0700 [thread overview]
Message-ID: <dw77emeffqca5y.fsf@tesla.com> (raw)
In-Reply-To: <s5hmuueysfk.wl-tiwai@suse.de>
At 07:37 on Thu, Jul 26 2018, Takashi wrote:
> OK, I seem to have misunderstood about what you meant as committed in
> the context. Yes, if the available is partial, it might be not
> committed. But I don't understand the next part.
>
> How will it be discarded at the next snd_pcm_ioplug_avail_update()?
> The data remains on the buffer, and applptr isn't changed.
Yes, that's the problem. Because when snd_pcm_ioplug_avail_update() is
subsequently called it uses snd_pcm_mmap_begin() to get the offset into
the mmap for the destination of the capture transfer operation. This is
essentially appl_ptr, which means that the data that has not yet been
commited will be overwritten by the transfer.
I guess that the offset could somehow be adjusted to point to after the
uncommitted data but I don't see a straightforward way to do that. A
scheme along these lines would also have to adjust the size parameter
accordingly, of course. This would sometimes mean that we cannot
transfer all the available data from the IO plugin. Would that cause
any issues?
Rob.
next prev parent reply other threads:[~2018-07-26 15:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 21:52 More snd_pcm_ioplug_avail_update() questions Rob Duncan
2018-07-26 7:04 ` Takashi Iwai
2018-07-26 14:19 ` Rob Duncan
2018-07-26 14:37 ` Takashi Iwai
2018-07-26 15:02 ` Rob Duncan [this message]
2018-07-26 15:14 ` Takashi Iwai
2018-07-30 18:55 ` Rob Duncan
2018-07-31 8:21 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dw77emeffqca5y.fsf@tesla.com \
--to=rduncan@tesla.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.