From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3961CC433EF for ; Sat, 19 Feb 2022 09:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=91KHbE1gQucuxtPPehdHULuKH3mmysKJuepvzRIrx0w=; b=usRAC0XXo0E2me Ivs/wmgkH8vZ6vB2g+AOrNRFXeFtaD3eecmErdjLzH6GaOC+ZNJlMAcij6H01OA71gNMLSGuRZ+oD vNeV7o0HXuI4sM43dsvI0fw6sx/+F7JCT/UWhWFk25l5D7y825ccRHLrSkosI4LRAkzsj2QAJbqrQ SEFmOOl4R2csnlNnAZdl0w/DCAMAuGO3leIUA3p8l4lgK08iXroC7ddILC6leg7RH5ZnexgkfWCZL p7NsJearDfkcIvg5B0KrxNjH0gfSI2sbrDZjYOalb9ISpNKyraeQB9HMTX89oYPmhPRvsafKLy6P/ J6R8cYCOqUWOVBX3gvxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nLM6H-00GYx4-Ga; Sat, 19 Feb 2022 09:32:21 +0000 Received: from mx2.securetransport.de ([188.68.39.254]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nLM6B-00GYvi-Sk for linux-arm-kernel@lists.infradead.org; Sat, 19 Feb 2022 09:32:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1645262931; bh=DvnMBoMWrC5tP4JUDp+kdkLkR3C1ZbkLyCFQs1NdNCk=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Wv2IOrZkyiFSsKKPGMtfvR8NPaBt4CECR+RYwjtyhKcngGGl2UbUpoL+JV/SR2Cxn 4UDhPCAk2jOm7OUHufB7BLchwddpDRJeEF/JfHn1AWBFQsnw6RBiVb6rnnyALmPcpG UU7PLigW7gVvsS5Y1Kvsnpe85kHIgZoIqogx+M5/IzeDFnNL1zfqtk+KlfyhzYLRMT 1T7r7de7HrdEdX4f0sQJYpqp4M3etsH1AyI4YQYhJLhnSPHfmjDyVm0azMa0sRO9Jx jID60SP7eMydYjMeF3WzvzAywU05S87uvLenE8Q91DzmfaTqPkzGZxhBVjTk8yQJsK a4tpx2MANYFnA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Max Krummenacher , "dri-devel@lists.freedesktop.org" CC: "Marek MV. Vasut" , David Airlie , "Sascha Hauer" , Boris Brezillon , NXP Linux Team , "Shawn Guo" , Pengutronix Kernel Team , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Thread-Topic: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Thread-Index: AQHYF2Auyje+6f9Uv0ak20m5iGounayK8fGAgA/C3CA= Date: Sat, 19 Feb 2022 09:28:44 +0000 Message-ID: References: <20220201113643.4638-1-cniedermaier@dh-electronics.com> <36f517300a15b2460a02512ef3c5814ad0ed2290.camel@gmail.com> In-Reply-To: <36f517300a15b2460a02512ef3c5814ad0ed2290.camel@gmail.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220219_013216_245969_2EAAE9D5 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Max Krummenacher [mailto:max.oss.09@gmail.com] Sent: Wednesday, February 9, 2022 10:38 AM >> If display timings were read from the devicetree using >> of_get_display_timing() and pixelclk-active is defined >> there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is >> automatically generated. Through the function >> drm_bus_flags_from_videomode() e.g. called in the >> panel-simple driver this flag got into the bus flags, >> but then in imx_pd_bridge_atomic_check() the bus flag >> check failed and will not initialize the display. The >> original commit fe141cedc433 does not explain why this >> check was introduced. So remove the bus flags check, >> because it stops the initialization of the display with >> valid bus flags. >> >> Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") >> Signed-off-by: Christoph Niedermaier >> Cc: Marek Vasut >> Cc: Boris Brezillon >> Cc: Philipp Zabel >> Cc: David Airlie >> Cc: Daniel Vetter >> Cc: Shawn Guo >> Cc: Sascha Hauer >> Cc: Pengutronix Kernel Team >> Cc: Fabio Estevam >> Cc: NXP Linux Team >> Cc: linux-arm-kernel@lists.infradead.org >> To: dri-devel@lists.freedesktop.org >> --- >> V2: - Add Boris to the Cc list >> --- >> drivers/gpu/drm/imx/parallel-display.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c >> index a8aba0141ce7..06cb1a59b9bc 100644 >> --- a/drivers/gpu/drm/imx/parallel-display.c >> +++ b/drivers/gpu/drm/imx/parallel-display.c >> @@ -217,14 +217,6 @@ static int imx_pd_bridge_atomic_check(struct drm_bridge *bridge, >> if (!imx_pd_format_supported(bus_fmt)) >> return -EINVAL; >> >> - if (bus_flags & >> - ~(DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_DE_HIGH | >> - DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | >> - DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)) { >> - dev_warn(imxpd->dev, "invalid bus_flags (%x)\n", bus_flags); >> - return -EINVAL; >> - } >> - >> bridge_state->output_bus_cfg.flags = bus_flags; >> bridge_state->input_bus_cfg.flags = bus_flags; >> imx_crtc_state->bus_flags = bus_flags; > > Tested on a Colibri iMX6DL with a panel-dpi based panel. > > Tested-by: Max Krummenacher I still ask myself why this bus flag check is in the code. Is there a reason not to remove that? Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FA81C433F5 for ; Sat, 19 Feb 2022 10:03:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E69DA10F6B8; Sat, 19 Feb 2022 10:03:07 +0000 (UTC) X-Greylist: delayed 584 seconds by postgrey-1.36 at gabe; Sat, 19 Feb 2022 09:41:44 UTC Received: from mx2.securetransport.de (mx2.securetransport.de [188.68.39.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 43DFE10F355 for ; Sat, 19 Feb 2022 09:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1645262931; bh=DvnMBoMWrC5tP4JUDp+kdkLkR3C1ZbkLyCFQs1NdNCk=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Wv2IOrZkyiFSsKKPGMtfvR8NPaBt4CECR+RYwjtyhKcngGGl2UbUpoL+JV/SR2Cxn 4UDhPCAk2jOm7OUHufB7BLchwddpDRJeEF/JfHn1AWBFQsnw6RBiVb6rnnyALmPcpG UU7PLigW7gVvsS5Y1Kvsnpe85kHIgZoIqogx+M5/IzeDFnNL1zfqtk+KlfyhzYLRMT 1T7r7de7HrdEdX4f0sQJYpqp4M3etsH1AyI4YQYhJLhnSPHfmjDyVm0azMa0sRO9Jx jID60SP7eMydYjMeF3WzvzAywU05S87uvLenE8Q91DzmfaTqPkzGZxhBVjTk8yQJsK a4tpx2MANYFnA== X-secureTransport-forwarded: yes From: Christoph Niedermaier Complaints-To: abuse@cubewerk.de To: Max Krummenacher , "dri-devel@lists.freedesktop.org" Subject: RE: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Thread-Topic: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Thread-Index: AQHYF2Auyje+6f9Uv0ak20m5iGounayK8fGAgA/C3CA= Date: Sat, 19 Feb 2022 09:28:44 +0000 Message-ID: References: <20220201113643.4638-1-cniedermaier@dh-electronics.com> <36f517300a15b2460a02512ef3c5814ad0ed2290.camel@gmail.com> In-Reply-To: <36f517300a15b2460a02512ef3c5814ad0ed2290.camel@gmail.com> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 19 Feb 2022 10:01:55 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Marek MV. Vasut" , David Airlie , Sascha Hauer , Boris Brezillon , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RnJvbTogTWF4IEtydW1tZW5hY2hlciBbbWFpbHRvOm1heC5vc3MuMDlAZ21haWwuY29tXQ0KU2Vu dDogV2VkbmVzZGF5LCBGZWJydWFyeSA5LCAyMDIyIDEwOjM4IEFNDQo+PiBJZiBkaXNwbGF5IHRp bWluZ3Mgd2VyZSByZWFkIGZyb20gdGhlIGRldmljZXRyZWUgdXNpbmcNCj4+IG9mX2dldF9kaXNw bGF5X3RpbWluZygpIGFuZCBwaXhlbGNsay1hY3RpdmUgaXMgZGVmaW5lZA0KPj4gdGhlcmUsIHRo ZSBmbGFnIERJU1BMQVlfRkxBR1NfU1lOQ19QT1NFREdFL05FR0VER0UgaXMNCj4+IGF1dG9tYXRp Y2FsbHkgZ2VuZXJhdGVkLiBUaHJvdWdoIHRoZSBmdW5jdGlvbg0KPj4gZHJtX2J1c19mbGFnc19m cm9tX3ZpZGVvbW9kZSgpIGUuZy4gY2FsbGVkIGluIHRoZQ0KPj4gcGFuZWwtc2ltcGxlIGRyaXZl ciB0aGlzIGZsYWcgZ290IGludG8gdGhlIGJ1cyBmbGFncywNCj4+IGJ1dCB0aGVuIGluIGlteF9w ZF9icmlkZ2VfYXRvbWljX2NoZWNrKCkgdGhlIGJ1cyBmbGFnDQo+PiBjaGVjayBmYWlsZWQgYW5k IHdpbGwgbm90IGluaXRpYWxpemUgdGhlIGRpc3BsYXkuIFRoZQ0KPj4gb3JpZ2luYWwgY29tbWl0 IGZlMTQxY2VkYzQzMyBkb2VzIG5vdCBleHBsYWluIHdoeSB0aGlzDQo+PiBjaGVjayB3YXMgaW50 cm9kdWNlZC4gU28gcmVtb3ZlIHRoZSBidXMgZmxhZ3MgY2hlY2ssDQo+PiBiZWNhdXNlIGl0IHN0 b3BzIHRoZSBpbml0aWFsaXphdGlvbiBvZiB0aGUgZGlzcGxheSB3aXRoDQo+PiB2YWxpZCBidXMg ZmxhZ3MuDQo+Pg0KPj4gRml4ZXM6IGZlMTQxY2VkYzQzMyAoImRybS9pbXg6IHBkOiBVc2UgYnVz IGZvcm1hdC9mbGFncyBwcm92aWRlZCBieSB0aGUgYnJpZGdlIHdoZW4gYXZhaWxhYmxlIikNCj4+ IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waCBOaWVkZXJtYWllciA8Y25pZWRlcm1haWVyQGRoLWVs ZWN0cm9uaWNzLmNvbT4NCj4+IENjOiBNYXJlayBWYXN1dCA8bWFyZXhAZGVueC5kZT4NCj4+IENj OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPg0KPj4gQ2M6 IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+DQo+PiBDYzogRGF2aWQgQWly bGllIDxhaXJsaWVkQGxpbnV4LmllPg0KPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZnds bC5jaD4NCj4+IENjOiBTaGF3biBHdW8gPHNoYXduZ3VvQGtlcm5lbC5vcmc+DQo+PiBDYzogU2Fz Y2hhIEhhdWVyIDxzLmhhdWVyQHBlbmd1dHJvbml4LmRlPg0KPj4gQ2M6IFBlbmd1dHJvbml4IEtl cm5lbCBUZWFtIDxrZXJuZWxAcGVuZ3V0cm9uaXguZGU+DQo+PiBDYzogRmFiaW8gRXN0ZXZhbSA8 ZmVzdGV2YW1AZ21haWwuY29tPg0KPj4gQ2M6IE5YUCBMaW51eCBUZWFtIDxsaW51eC1pbXhAbnhw LmNvbT4NCj4+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4+IFRv OiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+PiAtLS0NCj4+IFYyOiAtIEFkZCBC b3JpcyB0byB0aGUgQ2MgbGlzdA0KPj4gLS0tDQo+PiAgZHJpdmVycy9ncHUvZHJtL2lteC9wYXJh bGxlbC1kaXNwbGF5LmMgfCA4IC0tLS0tLS0tDQo+PiAgMSBmaWxlIGNoYW5nZWQsIDggZGVsZXRp b25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pbXgvcGFyYWxsZWwt ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2lteC9wYXJhbGxlbC1kaXNwbGF5LmMNCj4+IGlu ZGV4IGE4YWJhMDE0MWNlNy4uMDZjYjFhNTliOWJjIDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2lteC9wYXJhbGxlbC1kaXNwbGF5LmMNCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p bXgvcGFyYWxsZWwtZGlzcGxheS5jDQo+PiBAQCAtMjE3LDE0ICsyMTcsNiBAQCBzdGF0aWMgaW50 IGlteF9wZF9icmlkZ2VfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsDQo+ PiAgICAgICBpZiAoIWlteF9wZF9mb3JtYXRfc3VwcG9ydGVkKGJ1c19mbXQpKQ0KPj4gICAgICAg ICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+DQo+PiAtICAgICBpZiAoYnVzX2ZsYWdzICYNCj4+ IC0gICAgICAgICB+KERSTV9CVVNfRkxBR19ERV9MT1cgfCBEUk1fQlVTX0ZMQUdfREVfSElHSCB8 DQo+PiAtICAgICAgICAgICBEUk1fQlVTX0ZMQUdfUElYREFUQV9EUklWRV9QT1NFREdFIHwNCj4+ IC0gICAgICAgICAgIERSTV9CVVNfRkxBR19QSVhEQVRBX0RSSVZFX05FR0VER0UpKSB7DQo+PiAt ICAgICAgICAgICAgIGRldl93YXJuKGlteHBkLT5kZXYsICJpbnZhbGlkIGJ1c19mbGFncyAoJXgp XG4iLCBidXNfZmxhZ3MpOw0KPj4gLSAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCj4+IC0g ICAgIH0NCj4+IC0NCj4+ICAgICAgIGJyaWRnZV9zdGF0ZS0+b3V0cHV0X2J1c19jZmcuZmxhZ3Mg PSBidXNfZmxhZ3M7DQo+PiAgICAgICBicmlkZ2Vfc3RhdGUtPmlucHV0X2J1c19jZmcuZmxhZ3Mg PSBidXNfZmxhZ3M7DQo+PiAgICAgICBpbXhfY3J0Y19zdGF0ZS0+YnVzX2ZsYWdzID0gYnVzX2Zs YWdzOw0KPiANCj4gVGVzdGVkIG9uIGEgQ29saWJyaSBpTVg2REwgd2l0aCBhIHBhbmVsLWRwaSBi YXNlZCBwYW5lbC4NCj4gDQo+IFRlc3RlZC1ieTogTWF4IEtydW1tZW5hY2hlciA8bWF4LmtydW1t ZW5hY2hlckB0b3JhZGV4LmNvbT4NCg0KSSBzdGlsbCBhc2sgbXlzZWxmIHdoeSB0aGlzIGJ1cyBm bGFnIGNoZWNrIGlzIGluIHRoZSBjb2RlLg0KSXMgdGhlcmUgYSByZWFzb24gbm90IHRvIHJlbW92 ZSB0aGF0Pw0KDQpSZWdhcmRzDQpDaHJpc3RvcGgNCg==