From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gKWQJ-00042G-Eh for ath10k@lists.infradead.org; Wed, 07 Nov 2018 22:35:44 +0000 MIME-Version: 1.0 Date: Wed, 07 Nov 2018 14:35:29 -0800 From: Rajkumar Manoharan Subject: Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs In-Reply-To: <87va59uegc.fsf@toke.dk> References: <1540033534-11211-1-git-send-email-rmanohar@codeaurora.org> <1540033534-11211-4-git-send-email-rmanohar@codeaurora.org> <8736ssbxp9.fsf@toke.dk> <9c2b790132a9a89fecd7dd79dc67d891@codeaurora.org> <87woq2843q.fsf@toke.dk> <8fd3524bfe022ccd2a8b61a3314ed32b@codeaurora.org> <5d8415fe50e8505eb62c5a0d1b40bb2a@codeaurora.org> <87h8gzpy9t.fsf@toke.dk> <10b644b6c7f436a892e3e9f4fd5e179d@codeaurora.org> <87va59uegc.fsf@toke.dk> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOC0xMS0wNyAwNjo1MywgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFJh amt1bWFyIE1hbm9oYXJhbiA8cm1hbm9oYXJAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiAKPj4g TWVhbndoaWxlIHdlIGRpZCBzb21lIG1vcmUgZXhwZXJpbWVudHMgd2l0aCBib3RoIG1vZGVzLiBU aGUgZXhwZXJpbWVudAo+PiB3YXMgZG9uZSBpbiBvcGVuIGVudmlyb25tZW50IGFuZCBmaXhlZCBy YXRlIGFuZCBVRFAgdHJhZmZpYyByYW4gZm9yIDYwCj4+IHNlY29uZHMuCj4+IAo+PiBTZWVtcyBs aWtlIHB1c2ggbW9kZSBub3QgaG9ub3JpbmcgdGhlIGNvbmZpZ3VyZWQgd2VpZ2h0LiBBbHdheXMg dGhlCj4+IGFpcnRpbWUgd2FzIGFsbW9zdCBzYW1lIHdoZXJlYXMgaW4gcHVsbC1tb2RlIGFpcnRp bWUgaXMgY2hhbmdpbmcgYmFzZWQKPj4gb24gY29uZmlndXJlZCB3ZWlnaHQuIEhlbmNlIEkgd291 bGQgbGlrZSB0byBrbm93IHlvdXIgcmVzdWx0cy4KPiAKPiBSaWdodCwgc28gSSB2ZXJpZmllZCB0 aGF0IHRoZSBjdXJyZW50IHZlcnNpb24gb2YgdGhlIHBhdGNoIHNldCBzdGlsbAo+IHdvcmtzIHdp dGggYXRoOWsuIEhvd2V2ZXIsIHRoZSBhdGgxMGsgY2FyZCBJIGhhdmUgZG9lc24ndCBzZWVtIHRv Cj4gc3VwcG9ydCBwZWVyIHN0YXRzLCBzbyBJIGNhbid0IHRlc3QgYXRoMTBrLgo+IAo+ICQgbHNw Y2kgfCBncmVwIFF1YWxjb21tCj4gMDM6MDAuMCBOZXR3b3JrIGNvbnRyb2xsZXI6IFF1YWxjb21t IEF0aGVyb3MgUUNBOTg2eC85ODh4IDgwMi4xMWFjCj4gV2lyZWxlc3MgTmV0d29yayBBZGFwdGVy Cj4gCj4gJCBjYXQgL3N5cy9rZXJuZWwvZGVidWcvaWVlZTgwMjExL3BoeTEvYXRoMTBrL2NoaXBf aWQKPiAweDA0MzIwMmZmCj4gCj4gJCBjYXQgL3N5cy9rZXJuZWwvZGVidWcvaWVlZTgwMjExL3Bo eTEvYXRoMTBrL3dtaV9zZXJ2aWNlcyAgfCBncmVwIFBFRVIKPiBXTUlfU0VSVklDRV9QRUVSX0NB Q0hJTkcgICAgICAgICAgICAgICAgIC0KPiBXTUlfU0VSVklDRV9QRUVSX1NUQVRTICAgICAgICAg ICAgICAgICAgIC0KPiAKCk9vcHMuLi4gWWVhaCA5ODh4IGZpcm13YXJlICgxMC4yLjQpIGRvZXMg bm90IGhhdmUgcGVlciBzdGF0cyBzdXBwb3J0LgoKPiAKPiBJcyB0aGVyZSBhIHdheSB0byBmb3Jj ZS1lbmFibGUgYWlydGltZSBzdXBwb3J0LCBpcyB0aGlzIGEgaGFyZHdhcmUgCj4gaXNzdWU/Cj4g ClVuZm9ydHVuYXRlbHkgbm90LiBUaGVyZSBpcyBvbmUgbW9yZSBwZW5kaW5nIGNoYW5nZSB0aGF0 IGhhbmRsZXMgYWlydGltZSAKcmVwb3J0CmZyb20gSFRUIHR4LWNvbXBsLiBBZ2FpbiBpdCBkZXBl bmRzIGZpcm13YXJlIHN1cHBvcnQuIFRoZXNlIGV4cGVyaW1lbnRzIAphcmUKdGFrZW4gd2l0aCB0 aGlzIGYvdyBpbnRlcmZhY2UuIFdpbGwgcG9zdCB0aGUgY2hhbmdlLgoKPj4gCQlzdGExCQlzdGEy CQlzdGEzCQlzdGE0Cj4+IHB1bGwtbW9kZQk4cygyMDV1cykJMThzKDMuMm1zKQk4cygyMDV1cykJ MTRzKDQxMHVzKQo+PiAJCTEycygyNTZ1cykJMTJzKDI1NnVzKQkxM3MoMjU2dXMpCTEycygyNTZ1 cykKPj4gCQkxNHMoNG1zKQkxM3MoNG1zKQkxNHMoNG1zKQkxM3MoNG1zKQo+PiAKPj4gcHVzaC1t b2RlCTE1cygyMDV1cykJMTJzKDMuMm1zKQkxNnMoMjA1dXMpCTEycyg0MTB1cykKPj4gCQkxNXMo MjU2dXMpCTEycygyNTZ1cykJMTZzKDI1NnVzKQkxMnMoMjU2dXMpCj4+IAkJMTRzKDRtcykJMTNz KDRtcykJMTZzKDRtcykJMTJzKDRtcykKPiAKPiBSaWdodCwgc28gdGhlIHB1bGwtbW9kZSByZXN1 bHRzIGFyZSBlbmNvdXJhZ2luZyEgKlNvbWV0aGluZyogaXMKPiBoYXBwZW5pbmcsIGF0IGxlYXN0 LCBldmVuIHRob3VnaCB0aGUgYWdncmVnYXRlIGFpcnRpbWUgZG9lc24ndCBxdWl0ZQo+IG1hdGNo IHRoZSByYXRpb3Mgb2YgdGhlIGNvbmZpZ3VyZWQgd2VpZ2h0cy4KPiAKPiBBcmUgeW91IHJ1bm5p bmcgdGhlIFVEUCBnZW5lcmF0b3Igb24gdGhlIEFQIGl0c2VsZiwgb3Igb24gYSBzZXBhcmF0ZQo+ IGRldmljZSwgQlRXPyBJZiBpdCdzIG9uIHRoZSBBUCwgdGhlIHVzZXJzcGFjZSBzb2NrZXQgY2Fu IGdldCB0aHJvdHRsZWQsCj4gd2hpY2ggd2lsbCBpbnRlcmZlcmUgd2l0aCByZXN1bHRzLCBzbyBp dCdzIGJldHRlciB0byBoYXZlIGl0IG9uIGEKPiBzZXBhcmF0ZSBkZXZpY2UgKGNvbm5lY3RlZCB2 aWEgZXRoZXJuZXQpLgo+IApUcmFmZmljIGIvdyB3aXJlZCBjbGllbnQgKHZpYSBldGhlcm5ldCkg YW5kIHdpcmVsZXNzIGNsaWVudHMuCgo+IEFzIGZvciBwdXNoLW1vZGUsIGNvdWxkIHRoaXMgYmUg YmVjYXVzZSBvZiBiYWQgYnVmZmVyIG1hbmFnZW1lbnQ/IEkuZS4sCj4gYmVjYXVzZSB0aGVyZSdz IGEgbGFnIGJldHdlZW4gdGhlIHRpbWUgYWlydGltZSBpcyByZWdpc3RlcmVkLCBhbmQgdGhlCj4g dGltZSB0aGF0IGFpcnRpbWUgdXNhZ2UgaXMgcmVwb3J0ZWQsIHRoZSBkcml2ZXIganVzdCBwdXNo ZXMgYSB3aG9sZQo+IGJ1bmNoIG9mIHBhY2tldHMgdG8gdGhlIGZpcm13YXJlIHdoZW4gaXQgZ2V0 cyB0aGUgY2hhbmNlLCB3aGljaCAKPiBwcmV2ZW50cwo+IHRoZSBzY2hlZHVsZXIgZnJvbSB0aHJv dHRsaW5nIHByb3Blcmx5LiBUaGlzIGNvdWxkIGFsc28gZXhwbGFpbiB0aGUKPiBiZXR0ZXIsIGJ1 dCBub3QgcXVpdGUgcGVyZmVjdCwgcmVzdWx0cyBpbiBwdWxsIG1vZGUsIGFzc3VtaW5nIHRoYXQg cHVsbAo+IG1vZGUgcmVzdWx0cyBpbiBiZXR0ZXIgZmlybXdhcmUgYnVmZmVyIG1hbmFnZW1lbnQg d2hpY2ggcmVkdWNlcywgYnV0Cj4gZG9lc24ndCBxdWl0ZSByZW1vdmUsIHRoZSBsYWcuCj4gCkht bS4uLiBJIGFncmVlIHRoYXQgbGFnIGluIHJlcG9ydGluZyBhaXJ0aW1lIG1heSBjYXVzZSBtb3Jl IGRhdGEgcHVzaCB0byAKaHcuClJpZ2h0IG5vdyBib3RoIHR4IGFuZCB0eC1jb21wbCBhcmUgc2Vy aWFsaXplZCBieSBhY3RpdmVfdHhxX2xvY2suIFNvIApvbmNlCmxvY2sgYWNxdWlyZWQgYnkgdHgg cGF0aCwgaXQgd2lsbCBkb3dubG9hZCBhbGwgZnJhbWVzLiBpLmUgaXQgaXMgZXZlbiAKdHJ1ZSBm b3IKYXRoOWsgZHJpdmVyLiBIZW5jZSBJIGFtIHdvbmRlcmluZyBob3cgaXQgaXMgd29ya2luZyBv bmx5IHdpdGggYXRoOWsuCgpJbiBhdGgxMGssIFRoZSBhaXJ0aW1lIGFsd2F5cyBiZSByZXBvcnRl ZCBpbiB0eC1jb21wbGV0aW9uLiBJIGRvbnQgc2VlIAptdWNoIGxhZwpmcm9tIG15IGV4cGVyaW1l bnRzLgoKPiBJZiB0aGlzIGlzIGluZGVlZCB0aGUgcmVhc29uLCB0aGUgcXVldWUgbGltaXQgcGF0 Y2hlcyBzaG91bGQgaG9wZWZ1bGx5Cj4gYmUgYSBzb2x1dGlvbi4gU28gZ3Vlc3Mgd2UgbmVlZCB0 byBnZXQgdGhvc2Ugd29ya2luZyBhcyB3ZWxsIDopCj4gCkkgd291bGQgcHJlZmVyIHRvIGJhc2Vs aW5lIHRoZSBiYXNpYyBpbmZyYSBpbnRvIHVwc3RyZWFtIGZpcnN0IGFuZCBkbyAKZW5oYW5jZW1l bnQKb24gdG9wIG9mIHRoYXQuIEkgcmVxdWVzdCB5b3UgdG8gcmV2aXNpdCBtYWludGFpbmluZyBw ZXIgZHJpdmVyIGRlZmF1bHQuIApPdGhlcndpc2UKdGhlcmUgd291bGQgYmUgcGVyZm9ybWFuY2Ug aW1wYWN0IHdpdGggMjU2dXMuIDooCgotUmFqa3VtYXIKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194E9C0044C for ; Wed, 7 Nov 2018 22:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C978C2086C for ; Wed, 7 Nov 2018 22:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cBQxF+mI"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="OViGGgoM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C978C2086C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728030AbeKHIH7 (ORCPT ); Thu, 8 Nov 2018 03:07:59 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:46086 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727694AbeKHIH7 (ORCPT ); Thu, 8 Nov 2018 03:07:59 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1D17660741; Wed, 7 Nov 2018 22:35:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541630130; bh=6DNhox7PrMGjZlSIVUTzt2m9O8W8svFV3wZI4+DS/4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cBQxF+mIz/80JzfFNdCD0x5Rm9z2kmIlwHvyTnHe7w4ByayedevZu5twuYO9AhYyy CN2mPRc0/TO21GqUgWB88L/iHsJI/LIPbwDat/16Zn9wsbNPqTc6GsWtyTtubFJ5Rl g3vpUVAYST72xXTstQGYvfYZ3oIRz/cRZkLdLdV4= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 5CFB5603D2; Wed, 7 Nov 2018 22:35:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541630129; bh=6DNhox7PrMGjZlSIVUTzt2m9O8W8svFV3wZI4+DS/4g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OViGGgoM8BRMqMroX572hQ2FQ5agJj+nw9i5iMpD01p04vaiQWXdSO36uin/vVTxY HwMjHFFSE6edKLwpCJJyy+OFm/u7UmKuvJ5qPUpTvowqmkoo8a3WlNTreUwMa0c618 NN3VSOQ9/v0tEGj3EKiv3R0TOot8bs8rpaHsIzes= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 07 Nov 2018 14:35:29 -0800 From: Rajkumar Manoharan To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 3/6] mac80211: Add airtime accounting and scheduling to TXQs In-Reply-To: <87va59uegc.fsf@toke.dk> References: <1540033534-11211-1-git-send-email-rmanohar@codeaurora.org> <1540033534-11211-4-git-send-email-rmanohar@codeaurora.org> <8736ssbxp9.fsf@toke.dk> <9c2b790132a9a89fecd7dd79dc67d891@codeaurora.org> <87woq2843q.fsf@toke.dk> <8fd3524bfe022ccd2a8b61a3314ed32b@codeaurora.org> <5d8415fe50e8505eb62c5a0d1b40bb2a@codeaurora.org> <87h8gzpy9t.fsf@toke.dk> <10b644b6c7f436a892e3e9f4fd5e179d@codeaurora.org> <87va59uegc.fsf@toke.dk> Message-ID: X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2018-11-07 06:53, Toke Høiland-Jørgensen wrote: > Rajkumar Manoharan writes: > >> Meanwhile we did some more experiments with both modes. The experiment >> was done in open environment and fixed rate and UDP traffic ran for 60 >> seconds. >> >> Seems like push mode not honoring the configured weight. Always the >> airtime was almost same whereas in pull-mode airtime is changing based >> on configured weight. Hence I would like to know your results. > > Right, so I verified that the current version of the patch set still > works with ath9k. However, the ath10k card I have doesn't seem to > support peer stats, so I can't test ath10k. > > $ lspci | grep Qualcomm > 03:00.0 Network controller: Qualcomm Atheros QCA986x/988x 802.11ac > Wireless Network Adapter > > $ cat /sys/kernel/debug/ieee80211/phy1/ath10k/chip_id > 0x043202ff > > $ cat /sys/kernel/debug/ieee80211/phy1/ath10k/wmi_services | grep PEER > WMI_SERVICE_PEER_CACHING - > WMI_SERVICE_PEER_STATS - > Oops... Yeah 988x firmware (10.2.4) does not have peer stats support. > > Is there a way to force-enable airtime support, is this a hardware > issue? > Unfortunately not. There is one more pending change that handles airtime report from HTT tx-compl. Again it depends firmware support. These experiments are taken with this f/w interface. Will post the change. >> sta1 sta2 sta3 sta4 >> pull-mode 8s(205us) 18s(3.2ms) 8s(205us) 14s(410us) >> 12s(256us) 12s(256us) 13s(256us) 12s(256us) >> 14s(4ms) 13s(4ms) 14s(4ms) 13s(4ms) >> >> push-mode 15s(205us) 12s(3.2ms) 16s(205us) 12s(410us) >> 15s(256us) 12s(256us) 16s(256us) 12s(256us) >> 14s(4ms) 13s(4ms) 16s(4ms) 12s(4ms) > > Right, so the pull-mode results are encouraging! *Something* is > happening, at least, even though the aggregate airtime doesn't quite > match the ratios of the configured weights. > > Are you running the UDP generator on the AP itself, or on a separate > device, BTW? If it's on the AP, the userspace socket can get throttled, > which will interfere with results, so it's better to have it on a > separate device (connected via ethernet). > Traffic b/w wired client (via ethernet) and wireless clients. > As for push-mode, could this be because of bad buffer management? I.e., > because there's a lag between the time airtime is registered, and the > time that airtime usage is reported, the driver just pushes a whole > bunch of packets to the firmware when it gets the chance, which > prevents > the scheduler from throttling properly. This could also explain the > better, but not quite perfect, results in pull mode, assuming that pull > mode results in better firmware buffer management which reduces, but > doesn't quite remove, the lag. > Hmm... I agree that lag in reporting airtime may cause more data push to hw. Right now both tx and tx-compl are serialized by active_txq_lock. So once lock acquired by tx path, it will download all frames. i.e it is even true for ath9k driver. Hence I am wondering how it is working only with ath9k. In ath10k, The airtime always be reported in tx-completion. I dont see much lag from my experiments. > If this is indeed the reason, the queue limit patches should hopefully > be a solution. So guess we need to get those working as well :) > I would prefer to baseline the basic infra into upstream first and do enhancement on top of that. I request you to revisit maintaining per driver default. Otherwise there would be performance impact with 256us. :( -Rajkumar