Re: [OE-core] [PATCH v3 06/13] libjpeg-turbo: Fix build on mips/clang

[Khem Raj <raj.khem@gmail.com>]

On 5/29/25 2:22 AM, Richard Purdie wrote:
> On Thu, 2025-05-22 at 20:52 -0700, Khem Raj via lists.openembedded.org
> wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   meta/recipes-graphics/jpeg/libjpeg-turbo_3.1.0.bb | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/meta/recipes-graphics/jpeg/libjpeg-turbo_3.1.0.bb
>> b/meta/recipes-graphics/jpeg/libjpeg-turbo_3.1.0.bb
>> index
>> 8533bd8525311e783572cbafb6fccf240db9e0e8..90aa2ef43956f0a1e64f8e08e47
>> d953bf5773e19 100644
>> --- a/meta/recipes-graphics/jpeg/libjpeg-turbo_3.1.0.bb
>> +++ b/meta/recipes-graphics/jpeg/libjpeg-turbo_3.1.0.bb
>> @@ -47,6 +47,12 @@ EXTRA_OECMAKE:append:class-target:powerpc64le = "
>> ${@bb.utils.contains("TUNE_FEA
>>   DEBUG_OPTIMIZATION:append:armv4 = "
>> ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-
>> pointer', '', d)}"
>>   DEBUG_OPTIMIZATION:append:armv5 = "
>> ${@bb.utils.contains('TUNE_CCARGS', '-mthumb', '-fomit-frame-
>> pointer', '', d)}"
>>   
>> +# libjpeg-turbo-2.0.2/simd/mips/jsimd_dspr2.S
>> +# <instantiation>:13:5: error: invalid token in expression
>> +# .if $17 != 0
>> +# ^
>> +CFLAGS:append:toolchain-clang:mipsarch = " -no-integrated-as"
>> +
>>   PACKAGES =+ "jpeg-tools libturbojpeg"
> 
> I noticed you use "-no-integrated-as" but in the next patch in pixman,
> you use "-fno-integrated-as". Should we be consistent or are these
> different?

they are effectively same. -no-integrated-as is legacy clang option 
format while -fno-integrated-as is more in line with gcc options
it's generally better to use -fno-integrated-as since it follows the 
conventional flag naming pattern that other compilers might also recognize.

I will change it in a follow up for consistency.

> 
> Cheers,
> 
> Richard