Re: [PATCH 1/3] dt-bindings: Add ROHM BM1390 pressure sensor

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 9/7/23 13:08, Conor Dooley wrote:
> On Wed, Sep 06, 2023 at 03:37:19PM +0300, Matti Vaittinen wrote:
>> BM1390GLV-Z is a pressure sensor which performs internal temperature
>> compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa
>> and sample averaging and IIR filtering is built in sensor. Temperature
>> measurement is also supported.
>>
>> Add dt-bindings for the sensor.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>> ---
>>   .../bindings/iio/pressure/rohm,bm1390.yaml    | 52 +++++++++++++++++++
>>   1 file changed, 52 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
>> new file mode 100644
>> index 000000000000..d681fdd0f5ea
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/pressure/rohm,bm1390.yaml
>> @@ -0,0 +1,52 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/iio/pressure/rohm,bm1390.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ROHM BM1390 pressure sensor
>> +
>> +maintainers:
>> +  - Matti Vaittinen <mazziesaccount@gmail.com>
>> +
>> +description: |
> 
> You've got no formatting to preserve the | is not needed.
> 
>> +  BM1390GLV-Z is a pressure sensor which performs internal temperature
>> +  compensation for the MEMS. Pressure range is from 300 hPa to 1300 hPa
>> +  and sample averaging and IIR filtering is built in sensor.
> 
> nit: "built in to the sensor." or just "built-in."
> 
> Otherwise this seems alright to me,
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>


Thanks Conor! I'll fix them for v2 :)

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~