Re: [PATCH 2/2] dt-bindigs: leds: is31fl32xx: add optional properties section

[Krzysztof Kozlowski <krzk@kernel.org>]

On 19/06/2025 15:19, Pawel Zalewski wrote:
> Add optional support for is31fl3236a PWM frequency switch.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
> ---
>  Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt | 6 ++++++

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>


>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt b/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
> index 926c2117942c..aa38a0638bad 100644
> --- a/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
> +++ b/Documentation/devicetree/bindings/leds/leds-is31fl32xx.txt
> @@ -7,6 +7,7 @@ Each LED is represented as a sub-node of the device.
>  Required properties:
>  - compatible: one of
>  	issi,is31fl3236
> +	issi,is31fl3236a
>  	issi,is31fl3235
>  	issi,is31fl3218
>  	issi,is31fl3216
> @@ -16,6 +17,11 @@ Required properties:
>  - address-cells : must be 1
>  - size-cells : must be 0
>  
> +Optional properties:
> +- is31fl32xx,22kHz-pwm : When present, the chip's PWM will operate at

No new properties for TXT. Convert first to DT schema.

Also, there is no such thing as is31fl32xx company.

> +	~22kHz as opposed to ~3kHz to move the operating frequency out of the
> +	audible range.
> +
>  LED sub-node properties:
>  - reg : LED channel number (1..N)
>  - label :  (optional)


Best regards,
Krzysztof