From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E74EEC43461 for ; Tue, 8 Sep 2020 14:08:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C98820936 for ; Tue, 8 Sep 2020 14:08:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C98820936 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFeI6-0002Mx-SX; Tue, 08 Sep 2020 14:08:10 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kFeI5-0002Ms-Eg for xen-devel@lists.xenproject.org; Tue, 08 Sep 2020 14:08:09 +0000 X-Inumbo-ID: e34f1ecc-24f3-492e-8986-3d08fafd8391 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id e34f1ecc-24f3-492e-8986-3d08fafd8391; Tue, 08 Sep 2020 14:08:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8AAA5AD0F; Tue, 8 Sep 2020 14:08:07 +0000 (UTC) Subject: Re: [PATCH] Arm64: fix build with gcc 10 To: Bertrand Marquis Cc: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini References: <4c3c3f21-29bf-268c-039e-5adecff05f3a@suse.com> From: Jan Beulich Message-ID: Date: Tue, 8 Sep 2020 16:08:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 08.09.2020 15:05, Bertrand Marquis wrote: >> On 8 Sep 2020, at 13:53, Jan Beulich wrote: >> >> With gcc10 inlining is (no longer?) the default for certain atomics. >> >> Suggested-by: Julien Grall >> Signed-off-by: Jan Beulich >> --- a/xen/arch/arm/arch.mk >> +++ b/xen/arch/arm/arch.mk >> @@ -12,6 +12,7 @@ CFLAGS-$(CONFIG_ARM_32) += -mcpu=cortex- >> >> CFLAGS-$(CONFIG_ARM_64) += -mcpu=generic >> CFLAGS-$(CONFIG_ARM_64) += -mgeneral-regs-only # No fp registers etc >> +$(call cc-option-add,CFLAGS-$(CONFIG_ARM_64),CC,-mno-outline-atomics) > > Why not adding this before with the other “call cc-option” ? I elected to group it with the other Arm64 specific ones. > Also it might be a good idea to have a sentence in the commit message with the > error happening when this is not added: > undefined reference to `__aarch64_ldadd4_acq_rel’ > > Because some might need to backport this to other Xen releases if they switch to > a new compiler (although i could not reproduce that with Xen 4.14). I guess I'll go with Julien's suggested description (with some minor adjustments perhaps). Jan