From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EB22C2BB85 for ; Tue, 14 Apr 2020 16:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA8022075E for ; Tue, 14 Apr 2020 16:27:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JU9OD2Gm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391594AbgDNQ1x (ORCPT ); Tue, 14 Apr 2020 12:27:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2391589AbgDNQ1r (ORCPT ); Tue, 14 Apr 2020 12:27:47 -0400 Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE259C061A0E; Tue, 14 Apr 2020 09:27:46 -0700 (PDT) Received: by mail-lf1-x143.google.com with SMTP id m2so233890lfo.6; Tue, 14 Apr 2020 09:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wItdl1kg1ho/UCt0W/llhzqoO/4ewYoe347wz3vvN28=; b=JU9OD2GmTJxJzR7SI4BSza5QS7a+nLF2rIyiM0O4JOYm9/yfjrce7nyvTUJAljDxk6 GRc9hWnVaw+cOR+LpQ+1qk9iB19WdQ3H6n0OVUvOGIkqqB3Ym0e6RVZ+gLDmvuCk/tBU v62qrV8mqw/y2a0RuWQy80IS0Sb7KXoXQ3UYICIqe9e+dKFaHLsMzwAO2sToe/0CQzmk Nq9utwFgN5ecpsTm4jVcTNmd/1/gsXgpw2lXmK7PLAgpggIZqXZgv7GnU5Uv+1QJO905 S1HWQ9CdgXvR2h36WKVxPz0P6alNB2fk3VotkD5dnUTdp5PxDNOBx/DrlpxlhJi+04Ha ezHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wItdl1kg1ho/UCt0W/llhzqoO/4ewYoe347wz3vvN28=; b=Ry6zNU2qRwAC0jjmur6gMPZwHoPOuR7ThYysXX4EVySNuxYa5FVio+wbZeWc0jzP1A JZ8eGYdhzuJaCFuPaIpk8m4p8EDcLyemqeY+yQGdCoN2uca7HseT4d69EuuK4nyYj7P5 yxMcNFBJ1epEWGIRN0qe5iZEXOOecJSc1o5YfVmXZDSvqUjfPWrEcuGAtYeZbDViDApr 6hqX9fg3wafo3lschsEmevxOKwrsMX+ftrwA4dOZQ/MIjN2YGw5on2nc2AtmP1aCaKVx UPzZSCahTelRb37b1tBeVgJSoWFOizL2Lol4C52kBtqRryeWjkK38uBFbD/EsTyUIX70 B9Mw== X-Gm-Message-State: AGi0PuZgVnKbSwcpMdpV5SQnJ19gdkW5a0ME6EcdRIdq2BvH5qUV93DG f83DmZ0FDOaYxPfJBgRYIsw= X-Google-Smtp-Source: APiQypLfq8BURObkeqYvmT3aWY78Mdp4f1m77k1SBUPP6KkCEAuVyA/nceq/cBM66WxaiSQA/ECeuQ== X-Received: by 2002:a19:760a:: with SMTP id c10mr394527lff.126.1586881665309; Tue, 14 Apr 2020 09:27:45 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id x29sm10673621lfn.64.2020.04.14.09.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2020 09:27:44 -0700 (PDT) Subject: Re: [PATCH v6 10/14] memory: tegra: Add EMC scaling sequence code for Tegra210 To: Thierry Reding Cc: Rob Herring , Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-11-thierry.reding@gmail.com> <682c661d-ea3a-7b9a-42f0-d5473b969aa2@gmail.com> <20200414154526.GP3593749@ulmo> From: Dmitry Osipenko Message-ID: Date: Tue, 14 Apr 2020 19:27:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414154526.GP3593749@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 14.04.2020 18:45, Thierry Reding пишет: ... >> What about to try to replace this massive egyptian construction with a >> single "u32 val;" ? > > I actually tried that after condensing what this used to look like into > the above. The result was a huge failure because some of these temporary > values end up being reused, so I ended up writing bogus values into some > of these registers. It should be fine to keep those variables that are getting re-used. It looks like there are much more variables that are never re-used, and thus, they could be replaced. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 10/14] memory: tegra: Add EMC scaling sequence code for Tegra210 Date: Tue, 14 Apr 2020 19:27:43 +0300 Message-ID: References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-11-thierry.reding@gmail.com> <682c661d-ea3a-7b9a-42f0-d5473b969aa2@gmail.com> <20200414154526.GP3593749@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200414154526.GP3593749@ulmo> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Rob Herring , Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-tegra@vger.kernel.org 14.04.2020 18:45, Thierry Reding пишет: ... >> What about to try to replace this massive egyptian construction with a >> single "u32 val;" ? > > I actually tried that after condensing what this used to look like into > the above. The result was a huge failure because some of these temporary > values end up being reused, so I ended up writing bogus values into some > of these registers. It should be fine to keep those variables that are getting re-used. It looks like there are much more variables that are never re-used, and thus, they could be replaced. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E36C2BA19 for ; Tue, 14 Apr 2020 16:27:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 560E42076B for ; Tue, 14 Apr 2020 16:27:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G75Kz/ep"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JU9OD2Gm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 560E42076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FjPmrvGJg3rDdHI0oFEZcbLiTArUE0GbZvKVdHh7S/c=; b=G75Kz/ep8g7IL+ iRjTqdWbRd0vzz7yVCx4qs2/a89CbeaXrqkjgPyGWpxEcmuE0wZhrkJdae69rnFIhlpKVrrxCltqw 719lC3H7+w/vBJXUvG8hcJHVaYTGEomEYiEzg6w4N29Ug/Z8MzXKVmxcL9KRsm3rpGQ2J7DOr03ib ITYPg9DVUulHnJqB41AcwglbugJXZaUkMXOM2+SejT2Lh2l7XvXLgSCt+9Fg06OKh21ttS2ZT0BYp Vn9G7yB8K0IJqsZXNSrihuMpPkD2F5C8fNQxVlNyIuksRiCa3QPIBQK9BGa5ockpwRVOKB+J49HKI 80JkmbdnZzk5eicuUyYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOOPe-0000Uv-PM; Tue, 14 Apr 2020 16:27:50 +0000 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOOPb-0000UA-B5 for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 16:27:48 +0000 Received: by mail-lf1-x142.google.com with SMTP id 198so226988lfo.7 for ; Tue, 14 Apr 2020 09:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wItdl1kg1ho/UCt0W/llhzqoO/4ewYoe347wz3vvN28=; b=JU9OD2GmTJxJzR7SI4BSza5QS7a+nLF2rIyiM0O4JOYm9/yfjrce7nyvTUJAljDxk6 GRc9hWnVaw+cOR+LpQ+1qk9iB19WdQ3H6n0OVUvOGIkqqB3Ym0e6RVZ+gLDmvuCk/tBU v62qrV8mqw/y2a0RuWQy80IS0Sb7KXoXQ3UYICIqe9e+dKFaHLsMzwAO2sToe/0CQzmk Nq9utwFgN5ecpsTm4jVcTNmd/1/gsXgpw2lXmK7PLAgpggIZqXZgv7GnU5Uv+1QJO905 S1HWQ9CdgXvR2h36WKVxPz0P6alNB2fk3VotkD5dnUTdp5PxDNOBx/DrlpxlhJi+04Ha ezHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wItdl1kg1ho/UCt0W/llhzqoO/4ewYoe347wz3vvN28=; b=NjHjDOG/A0hsF4HgL1GCKbHRAEdNcS6hqDpUKovwsyo7FxVBV7uE/N6rqzMJ7jJ48U x4h4TQPZdOwT7YtX3yAMr1fpgJHiID5hGnFLmxLkDsAP7kenod+eVzCtHW47JK3vqjmz toGJJDGApoBs1AnOs4hEFFBNRf7+u9sPptCcSK5VsUXgCdjRsCFMoWw0fWSkB7z5du3m aFmLOThYACqpvO3cZqCg4RLjaFrBjrYuEQZN5R2eHF/9CvyYTN76AWlSlHc0FEcAyjw8 WOX76anJiEoPruW7sns85xZDw8KjsqxCQHUKddcHf5ngRd2A0OJXvTykEQefSgVd9Kfn E1KA== X-Gm-Message-State: AGi0Pubg5ExCnzdQ+Ix99hDhHIZOqHGhsyQe9tWXGZerKbr9g1OC2UPx nxOe8HcKHAZsVODOs2fmgCmLBFBY X-Google-Smtp-Source: APiQypLfq8BURObkeqYvmT3aWY78Mdp4f1m77k1SBUPP6KkCEAuVyA/nceq/cBM66WxaiSQA/ECeuQ== X-Received: by 2002:a19:760a:: with SMTP id c10mr394527lff.126.1586881665309; Tue, 14 Apr 2020 09:27:45 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id x29sm10673621lfn.64.2020.04.14.09.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2020 09:27:44 -0700 (PDT) Subject: Re: [PATCH v6 10/14] memory: tegra: Add EMC scaling sequence code for Tegra210 To: Thierry Reding References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-11-thierry.reding@gmail.com> <682c661d-ea3a-7b9a-42f0-d5473b969aa2@gmail.com> <20200414154526.GP3593749@ulmo> From: Dmitry Osipenko Message-ID: Date: Tue, 14 Apr 2020 19:27:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414154526.GP3593749@ulmo> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_092747_379687_71E4FAB9 X-CRM114-Status: GOOD ( 12.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Rob Herring , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MTQuMDQuMjAyMCAxODo0NSwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4+IFdoYXQg YWJvdXQgdG8gdHJ5IHRvIHJlcGxhY2UgdGhpcyBtYXNzaXZlIGVneXB0aWFuIGNvbnN0cnVjdGlv biB3aXRoIGEKPj4gc2luZ2xlICJ1MzIgdmFsOyIgPwo+IAo+IEkgYWN0dWFsbHkgdHJpZWQgdGhh dCBhZnRlciBjb25kZW5zaW5nIHdoYXQgdGhpcyB1c2VkIHRvIGxvb2sgbGlrZSBpbnRvCj4gdGhl IGFib3ZlLiBUaGUgcmVzdWx0IHdhcyBhIGh1Z2UgZmFpbHVyZSBiZWNhdXNlIHNvbWUgb2YgdGhl c2UgdGVtcG9yYXJ5Cj4gdmFsdWVzIGVuZCB1cCBiZWluZyByZXVzZWQsIHNvIEkgZW5kZWQgdXAg d3JpdGluZyBib2d1cyB2YWx1ZXMgaW50byBzb21lCj4gb2YgdGhlc2UgcmVnaXN0ZXJzLgoKSXQg c2hvdWxkIGJlIGZpbmUgdG8ga2VlcCB0aG9zZSB2YXJpYWJsZXMgdGhhdCBhcmUgZ2V0dGluZyBy ZS11c2VkLiBJdApsb29rcyBsaWtlIHRoZXJlIGFyZSBtdWNoIG1vcmUgdmFyaWFibGVzIHRoYXQg YXJlIG5ldmVyIHJlLXVzZWQsIGFuZAp0aHVzLCB0aGV5IGNvdWxkIGJlIHJlcGxhY2VkLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=