All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwan <M.Schwan@phytec.de>
To: Wadim Egorov <W.Egorov@phytec.de>,
	"trini@konsulko.com" <trini@konsulko.com>,
	Dominik Haller <D.Haller@phytec.de>,
	"peng.fan@nxp.com" <peng.fan@nxp.com>,
	"jh80.chung@samsung.com" <jh80.chung@samsung.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
	"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [PATCH 4/7] include: env: phytec: Drop legacy RAUC boot logic
Date: Wed, 13 May 2026 14:10:19 +0000	[thread overview]
Message-ID: <e08226f57898346f0401b04dfd042175ce4a4857.camel@phytec.de> (raw)
In-Reply-To: <20260513071905.83522-5-w.egorov@phytec.de>

Reviewed-by: Martin Schwan <m.schwan@phytec.de>

On Wed, 2026-05-13 at 09:19 +0200, Wadim Egorov wrote:
> RAUC slot selection is now handled by the RAUC bootmeth, which all
> phytec K3 boards use. Remove the unused env-based logic.
> 
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
>  include/env/phytec/k3_mmc.env |  4 +--
>  include/env/phytec/rauc.env   | 52 ---------------------------------
> --
>  2 files changed, 1 insertion(+), 55 deletions(-)
>  delete mode 100644 include/env/phytec/rauc.env
> 
> diff --git a/include/env/phytec/k3_mmc.env
> b/include/env/phytec/k3_mmc.env
> index 95d0204b6da..8129b35ea5e 100644
> --- a/include/env/phytec/k3_mmc.env
> +++ b/include/env/phytec/k3_mmc.env
> @@ -7,15 +7,13 @@
>  /* Logic for TI K3 based SoCs to boot from a MMC device. */
>  
>  #include <env/phytec/overlays.env>
> -#include <env/phytec/rauc.env>
>  
>  mmcargs=setenv bootargs console=${console} earlycon=${earlycon}
> -	root=/dev/mmcblk${mmcdev}p${mmcroot} ${raucargs} rootwait rw
> +	root=/dev/mmcblk${mmcdev}p${mmcroot} rootwait rw
>  	${optargs}
>  mmcloadimage=load mmc ${mmcdev}:${mmcpart} ${kernel_addr_r} Image
>  mmcloadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr_r} ${fdtfile}
>  mmcboot=echo DEPRECATION WARNING: mmcboot will be removed in future
> versions. Use standard boot instead.;
> -	if test ${doraucboot} = 1; then run raucinit; fi;
>  	run mmcargs;
>  	mmc dev ${mmcdev};
>  	mmc rescan;
> diff --git a/include/env/phytec/rauc.env
> b/include/env/phytec/rauc.env
> deleted file mode 100644
> index 89e17ff70ec..00000000000
> --- a/include/env/phytec/rauc.env
> +++ /dev/null
> @@ -1,52 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -
> -/* Logic to select a boot partition based on environment variables
> and switch
> - * to the other if the boot fails. */
> -
> -doraucboot=0
> -
> -raucbootpart0=1
> -raucrootpart0=5
> -raucbootpart1=2
> -raucrootpart1=6
> -
> -raucinit=
> -	echo Booting RAUC A/B system;
> -	test -n "${BOOT_ORDER}" || env set BOOT_ORDER "system0
> system1";
> -	test -n "${BOOT_system0_LEFT}" || env set BOOT_system0_LEFT
> 3;
> -	test -n "${BOOT_system1_LEFT}" || env set BOOT_system1_LEFT
> 3;
> -	env set raucstatus;
> -	for BOOT_SLOT in "${BOOT_ORDER}"; do
> -		if test "x${raucstatus}" != "x"; then
> -			echo Skipping remaing slots!;
> -		elif test "x${BOOT_SLOT}" = "xsystem0"; then
> -			if test ${BOOT_system0_LEFT} -gt 0; then
> -				echo Found valid slot A,
> ${BOOT_system0_LEFT} attempts remaining;
> -				setexpr BOOT_system0_LEFT
> ${BOOT_system0_LEFT} - 1;
> -				env set mmcpart ${raucbootpart0};
> -				env set mmcroot ${raucrootpart0};
> -				env set raucargs rauc.slot=system0;
> -				env set raucstatus success;
> -			fi;
> -		elif test "x${BOOT_SLOT}" = "xsystem1"; then
> -			if test ${BOOT_system1_LEFT} -gt 0; then
> -				echo Found valid slot B,
> ${BOOT_system1_LEFT} attempts remaining;
> -				setexpr BOOT_system1_LEFT
> ${BOOT_system1_LEFT} - 1;
> -				env set mmcpart ${raucbootpart1};
> -				env set mmcroot ${raucrootpart1};
> -				env set raucargs rauc.slot=system1;
> -				env set raucstatus success;
> -			fi;
> -		fi;
> -	done;
> -	if test -n "${raucstatus}"; then
> -		env delete raucstatus;
> -		env save;
> -	else
> -		echo WARN: No valid slot found;
> -		env set BOOT_system0_LEFT 3;
> -		env set BOOT_system1_LEFT 3;
> -		env delete raucstatus;
> -		env save;
> -		reset;
> -	fi;

  reply	other threads:[~2026-05-13 14:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  7:18 [PATCH 0/7] board: phytec: Update rm-cfgs, env and docs Wadim Egorov
2026-05-13  7:18 ` [PATCH 1/7] board: phytec: phycore_am62x: Add tifs-rm-cfg Wadim Egorov
2026-05-13  7:19 ` [PATCH 2/7] arm: dts: k3-am625-phycore-som-binman: Enable tifs-rm-cfg Wadim Egorov
2026-05-13  7:19 ` [PATCH 3/7] board: phytec: phycore_am68x: Update rm-cfg Wadim Egorov
2026-05-13  7:19 ` [PATCH 4/7] include: env: phytec: Drop legacy RAUC boot logic Wadim Egorov
2026-05-13 14:10   ` Martin Schwan [this message]
2026-05-13  7:19 ` [PATCH 5/7] doc: board: phytec: Fix typos and copy-paste errors in K3 docs Wadim Egorov
2026-05-13  7:19 ` [PATCH 6/7] doc: board: phytec: k3: Document boot flow and watchdog Wadim Egorov
2026-05-13  7:19 ` [PATCH 7/7] doc: board: phytec: Document DDR size override Kconfigs Wadim Egorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e08226f57898346f0401b04dfd042175ce4a4857.camel@phytec.de \
    --to=m.schwan@phytec.de \
    --cc=D.Haller@phytec.de \
    --cc=W.Egorov@phytec.de \
    --cc=jh80.chung@samsung.com \
    --cc=peng.fan@nxp.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream@lists.phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.